Hey Andy, On Wed, Jan 25, 2023 at 02:20:43PM +0000, Andy Chiu wrote: > These are small and likely to be frequently called so implement as > inline routines (vs. function call). > > Co-developed-by: Guo Ren > Signed-off-by: Guo Ren > Co-developed-by: Vincent Chen > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > Signed-off-by: Vineet Gupta > [vineetg: create new patch from meshup, introduced asm variant] > Signed-off-by: Andy Chiu > [andy.chiu: remove calls from asm thus remove asm vaiant] Again, these chains are odd but a reflection of the series' history I guess. > --- > arch/riscv/include/asm/vector.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/riscv/include/asm/vector.h b/arch/riscv/include/asm/vector.h > index 917c8867e702..0fda0faf5277 100644 > --- a/arch/riscv/include/asm/vector.h > +++ b/arch/riscv/include/asm/vector.h > @@ -11,12 +11,23 @@ > #ifdef CONFIG_RISCV_ISA_V > > #include > +#include > > static __always_inline bool has_vector(void) > { > return static_branch_likely(&riscv_isa_ext_keys[RISCV_ISA_EXT_KEY_VECTOR]); This likely will need to drop the static branch due to Jisheng's series. See here for what the equivalent change to has_fpu() was: https://lore.kernel.org/all/20230115154953.831-1-jszhang@kernel.org/ Hopefully that series has been queued by the time you are resubmitting this one. > } > > +static __always_inline void rvv_enable(void) I'm not keen on these function names. IMO, they should be riscv_v_{en,dis}able() to match other riscv specific functions, like those of zicbom or sbi stuff. Other parts of this series use riscv_v_foo & riscv_vfoo. Some of the kvm bits spell out vector rather than v. Consistent naming of functions etc would be appreciated. Thanks, Conor.