From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32BECC61D97 for ; Fri, 27 Jan 2023 09:26:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232543AbjA0J0L (ORCPT ); Fri, 27 Jan 2023 04:26:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231954AbjA0J0K (ORCPT ); Fri, 27 Jan 2023 04:26:10 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49EA5BB0; Fri, 27 Jan 2023 01:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674811541; x=1706347541; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ilQhCfGq1xZNQal4i+hMA+lgv7nyH3GuwzD1R+yoQjE=; b=c8L60Pb4ur0+s+dSXKteXZvZyxcF/F9xvQ1uuNrq4SDnvwHXQH/XqkUR 1y86vTysIvXBsp2wCNy7ixAAVWRg1dMsPglIR5M5/WNl6fPKBAMeqxl+Z 86eKbDLc46SBpmoZSTamfVGu34zutEeg8k06TiF4EMI4WsDHrOAFF+OOU 4tA80HiNRn3BlQs1vzpp9hPOsgm8oeJyMT99SrGgYZhLE/kDYdL1iQUBb CSR4E8tv+M1EBiFgqiMSa/sHPskXL5qf2q5hTulEouLW5n6HmxzIYy2aP RAAh8oyIxftgxHUSCunnjiuU1lBTGnUtx+wYJnGQv+DqPxTacwAYfpnZw w==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="307397784" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="307397784" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:25:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="693653004" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="693653004" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 27 Jan 2023 01:25:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLKys-00FtRL-0p; Fri, 27 Jan 2023 11:25:10 +0200 Date: Fri, 27 Jan 2023 11:25:09 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127001141.407071-4-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jan 26, 2023 at 04:11:30PM -0800, Saravana Kannan wrote: > The OF_POPULATED flag was set to let fw_devlink know that the device > tree node will not have a struct device created for it. This information > is used by fw_devlink to avoid deferring the probe of consumers of this > device tree node. > > Let's use fwnode_dev_initialized() instead because it achieves the same > effect without using OF specific flags. This allows more generic code to > be written in driver core. ... > - of_node_set_flag(np, OF_POPULATED); > + fwnode_dev_initialized(&np->fwnode, true); of_fwnode_handle(np) ? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6962C61D97 for ; Fri, 27 Jan 2023 09:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o7jfKM95l9BrTzhjo3W+9ZFX4Utj5Ytfj0sR+b3qt5A=; b=30RFuO4qLTA9ms GvVcay7eKvq+kq4wfgWs6lU9g143NaAMfZ9b0ZOuPuyhtRxpwcuZHQXHW5R2LKdfWC8P6uNWPvXu2 OEizuLCt0ysu1XEfxQlAY4zIvFZatzdcZHR3iI+9LWBhcm+sn6+Ofu/GN0wJqdHMT45x9UsioJiN0 PTGVS62ejnfJ6yHMebvKPOEuhp+GB4FmN4WxuT7SoG04Z8+izMAlUhHHWk/23mS0cdxXlkRQaAYyu gj5j02jzzrGLlLMD2ZSqeDsi7BR3ppTOosDNEu75mbqfdHdT3yIu8rtE+31xKsevcRFNcsib/Z9T9 oIeanocB3cUCtCpFWdmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLKzT-00DdyS-9x; Fri, 27 Jan 2023 09:25:47 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLKzM-00Ddvv-Fj for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 09:25:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674811540; x=1706347540; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ilQhCfGq1xZNQal4i+hMA+lgv7nyH3GuwzD1R+yoQjE=; b=M+FRzLi2wsZ+NwGleLqsBkjKPz1USOk/lfNM4fk2J105fV6rt3JJPr5R oGTY4c5HPnjzhre4N1KEVHg/DnmzdLRN8/V2LIQZ3C4ivtINMt7RnigsP UqNM0OI49wWrBIhaqd4FVDGKILqv6qU4SJ7sHYeqZ3ja0Mbj6TtEiPW+B 0+JU9owjeV9PRHoTMdGI2+k1oVFp07wxutv0EfgQz79+T7KHNiSXPw1YA 78TghpC7qwP4JtQ7ftmIk69G1YfJiRioNI0PmzvcNVMK8KXzge1g+PLwb b/aWrAJw9LVv6B0FEIOaw6oTkmks3wAR4I8fRMONmvwqJWdz0fVhqobm3 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="307397800" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="307397800" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:25:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="693653004" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="693653004" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 27 Jan 2023 01:25:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLKys-00FtRL-0p; Fri, 27 Jan 2023 11:25:10 +0200 Date: Fri, 27 Jan 2023 11:25:09 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127001141.407071-4-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_012540_736205_DEEEA29F X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 26, 2023 at 04:11:30PM -0800, Saravana Kannan wrote: > The OF_POPULATED flag was set to let fw_devlink know that the device > tree node will not have a struct device created for it. This information > is used by fw_devlink to avoid deferring the probe of consumers of this > device tree node. > > Let's use fwnode_dev_initialized() instead because it achieves the same > effect without using OF specific flags. This allows more generic code to > be written in driver core. ... > - of_node_set_flag(np, OF_POPULATED); > + fwnode_dev_initialized(&np->fwnode, true); of_fwnode_handle(np) ? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel