From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BF1C61D97 for ; Fri, 27 Jan 2023 09:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233024AbjA0JbH (ORCPT ); Fri, 27 Jan 2023 04:31:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233034AbjA0JbD (ORCPT ); Fri, 27 Jan 2023 04:31:03 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 669A1783F0; Fri, 27 Jan 2023 01:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674811839; x=1706347839; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YVXnhJELanJZz6sXbyycPESVDj38yXwx4kC0cB5HFeM=; b=iSEE2B+lPoDHy9Grbiqgatub3OuZPl6LnAMbbpNZ09/QyMB1hDJyD+yZ s+cCL1PrgjQpqFVwTwshYL/2ALKM1pjNtDj6x5j8AskT0DHLgUKR+xw1x 8GSmvWo+4ni9fbNGt20R6gk3x3nS9Ky4lfcn2vo3RxUfbctASVi04DhaD 2RUmNXGizyFizwsc6ETIxROzNbwb80Xa3x2c0o6wxU1lQnKbf3EZYUQF9 tOIyyXTZeP73JR+ftnvwGPGEKTwjZ8ZF4oqun9cGOB4FhEiE4FZi8nBqv b/kq+mhiPnQtb3ftriZ9L2/6QoJMHpmMIhCt+qrVf0jDi1Yf7k8JAu/K/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="306702210" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="306702210" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:30:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="731791328" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="731791328" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 27 Jan 2023 01:30:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLL3s-00FtXI-0O; Fri, 27 Jan 2023 11:30:20 +0200 Date: Fri, 27 Jan 2023 11:30:19 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 05/11] driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-6-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jan 27, 2023 at 11:29:43AM +0200, Andy Shevchenko wrote: > On Thu, Jan 26, 2023 at 04:11:32PM -0800, Saravana Kannan wrote: ... > > DL_FLAG_AUTOREMOVE_SUPPLIER | \ > > DL_FLAG_AUTOPROBE_CONSUMER | \ > > DL_FLAG_SYNC_STATE_ONLY | \ > > - DL_FLAG_INFERRED) > > + DL_FLAG_INFERRED | \ > > + DL_FLAG_CYCLE) > > You can make less churn by squeezing the new one above the last one. Or even define a mask with all necessary bits in the header and use it. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D4ABC38142 for ; Fri, 27 Jan 2023 09:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OUC/KaYvHHruzDIAnNxoKJ0XTUDNUrOpxoSGYkdp9lg=; b=z1lwxlDh1TFiSA qIjN6FhCyUDg0HzxoLmP8wic8NN8iv4QSAJSeyQC+bQWfNUAqWrwO5mMqhRJ3I+cFQxMTBk3ptsXF Hxkgr0ao9Z9ENQFZTxRgbCj8qW9uM7F5xktQF+l3whOljVAgvq2EDi4OJDCOqx2mGUuMdIhW2Q5Uc oDrpIdubmvbjaITBI2lGSKNLIpxQubEjfBJTBwIF6uuULhqrNclz5dT6eJTIl63wixUeBZZ5jKiBc +vJ2839z3tdDXvD6b1HanacPX/vPfDlSo5Z+XaF0WtovIQMGPuvfhFM24Xj3ME7BiyiSCbTL8kBFG ynqI+VXXwfkwdpovI8uQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLL4I-00DfdS-Tq; Fri, 27 Jan 2023 09:30:49 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLL48-00Dfaj-9x for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 09:30:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674811836; x=1706347836; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YVXnhJELanJZz6sXbyycPESVDj38yXwx4kC0cB5HFeM=; b=AMKauNiRgHUMgXUkc16wDV/I5YG0EHSBNMU4vZbssGXkjY0XU9GP/DuW p3JMFTT2Tg8NL9b3qwFdjpJ5IgsD9/skVKoportzbrlAHusFixCvir91U AtGNfcHsZIdckWlhVqQ5mKyS8C7txwiSGD1WYjijk0Y4Tp4t76VGYOmYe hzh6/+MmkyXL+6XqKWK0xwlqOrgeRJyBRUGj+mkFGZNd7KxMhS7Q9lL9j gl52Q94NZwzLJocIVMcpCXFD+2/EPntq8on2FyQT2u/s76UW8A0Jj3yAD jhh09wJz2lJZQcVFrZfqnsRqHQ4zQDsvoakCyUhwfZTiR7WCsaOQZcBjk g==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="306702218" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="306702218" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:30:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="731791328" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="731791328" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 27 Jan 2023 01:30:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLL3s-00FtXI-0O; Fri, 27 Jan 2023 11:30:20 +0200 Date: Fri, 27 Jan 2023 11:30:19 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 05/11] driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-6-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_013036_392193_8E43B804 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 11:29:43AM +0200, Andy Shevchenko wrote: > On Thu, Jan 26, 2023 at 04:11:32PM -0800, Saravana Kannan wrote: ... > > DL_FLAG_AUTOREMOVE_SUPPLIER | \ > > DL_FLAG_AUTOPROBE_CONSUMER | \ > > DL_FLAG_SYNC_STATE_ONLY | \ > > - DL_FLAG_INFERRED) > > + DL_FLAG_INFERRED | \ > > + DL_FLAG_CYCLE) > > You can make less churn by squeezing the new one above the last one. Or even define a mask with all necessary bits in the header and use it. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel