From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4C39C61DB3 for ; Fri, 27 Jan 2023 09:34:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233061AbjA0JeN (ORCPT ); Fri, 27 Jan 2023 04:34:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232160AbjA0JeN (ORCPT ); Fri, 27 Jan 2023 04:34:13 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F29529E07; Fri, 27 Jan 2023 01:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674812024; x=1706348024; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mwCyMlAJfonCrHYzpmJJHccfkoSdmotmHtS5TBMdU+k=; b=cj6NrjfhKZh3eK2SVTd8241zK827Wf3bQJo/DT2wO19e9p3E7PAWQBy6 plnfIBv7LVU+7FvG2jPDZyOEjRtFgMpuU+hbZmtpr/tHVZkSWhOWwED/Y 0RFH6/3Rvuv9aR1oEax7PEBqvIbPM415/pcJWfGKwIy5NIESIVgbwcPon KcaSTFAb2Lx75Sp3k6j5uaKfNbR5YOiaMCK7a7RgWIHUYRFk6hPjQKR7/ sCxF3duCAovGegqfTM4Sdvm9eA+dlh6GdbPbpNECMDx9sl86ABtHNm2Fp Eel/7TQWKL+Vvj2kp5E5JrYgKXMWVR30pacl6jEFkNdK1SAKRIS9zpZvk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="306702685" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="306702685" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:33:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="731791790" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="731791790" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 27 Jan 2023 01:33:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLL6u-00Ftar-2t; Fri, 27 Jan 2023 11:33:28 +0200 Date: Fri, 27 Jan 2023 11:33:28 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 06/11] driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-7-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127001141.407071-7-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jan 26, 2023 at 04:11:33PM -0800, Saravana Kannan wrote: > To improve detection and handling of dependency cycles, we need to be > able to mark fwnode links as being part of cycles. fwnode links marked > as being part of a cycle should not block their consumers from probing. ... > + list_for_each_entry(link, &fwnode->suppliers, c_hook) { > + if (link->flags & FWLINK_FLAG_CYCLE) > + continue; > + return link->supplier; Hmm... if (!(link->flags & FWLINK_FLAG_CYCLE)) return link->supplier; ? > + } > + > + return NULL; ... > - if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) && > - !fw_devlink_is_permissive()) { > - sup_fw = list_first_entry(&dev->fwnode->suppliers, > - struct fwnode_link, > - c_hook)->supplier; > + sup_fw = fwnode_links_check_suppliers(dev->fwnode); dev_fwnode() ? ... > - val = !list_empty(&dev->fwnode->suppliers); > + mutex_lock(&fwnode_link_lock); > + val = !!fwnode_links_check_suppliers(dev->fwnode); Ditto? > + mutex_unlock(&fwnode_link_lock); -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B65EC61DB3 for ; Fri, 27 Jan 2023 09:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xvf6cm0dU1vBq3Dm7iH3+JEGN3IVsUc+faPlnbXK/+w=; b=XudWGXco/3McEB rJbheKFwRce1TQoWTZc7OI8OU7A5S2McCON5Zed1aa66GUq4TUNGO8s7sXyc+atagL+cga+nP2/7U w5kxvG++/6dY9HwE83oyUCw948HhuBB/sXuJ09MKE4XU8UdrZJeKzWmDpff4yYQ0USTE9tFBoNaJq ehE5ovv6jDDvU8CKhtaYqZ9cVDChnAGwVph7oCCFFwrvqqUD5Qwgt1ptCoTCmLpaIMsIC5G8/+mcp 9MwlFr5F7aC1OR0fxbd5ZmR72+wabzbmyjjYlK9D9wGbpSQtA+bs6804bymz0cAQI6hvedkEuVgHg AcXGWwQAcbf4MFIOK4pQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLLAW-00DhzB-KU; Fri, 27 Jan 2023 09:37:14 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLL7A-00DghE-OS for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 09:33:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674812024; x=1706348024; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mwCyMlAJfonCrHYzpmJJHccfkoSdmotmHtS5TBMdU+k=; b=cj6NrjfhKZh3eK2SVTd8241zK827Wf3bQJo/DT2wO19e9p3E7PAWQBy6 plnfIBv7LVU+7FvG2jPDZyOEjRtFgMpuU+hbZmtpr/tHVZkSWhOWwED/Y 0RFH6/3Rvuv9aR1oEax7PEBqvIbPM415/pcJWfGKwIy5NIESIVgbwcPon KcaSTFAb2Lx75Sp3k6j5uaKfNbR5YOiaMCK7a7RgWIHUYRFk6hPjQKR7/ sCxF3duCAovGegqfTM4Sdvm9eA+dlh6GdbPbpNECMDx9sl86ABtHNm2Fp Eel/7TQWKL+Vvj2kp5E5JrYgKXMWVR30pacl6jEFkNdK1SAKRIS9zpZvk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="306702694" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="306702694" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:33:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="731791790" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="731791790" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 27 Jan 2023 01:33:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLL6u-00Ftar-2t; Fri, 27 Jan 2023 11:33:28 +0200 Date: Fri, 27 Jan 2023 11:33:28 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 06/11] driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-7-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127001141.407071-7-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_013344_881953_18A0E56A X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 26, 2023 at 04:11:33PM -0800, Saravana Kannan wrote: > To improve detection and handling of dependency cycles, we need to be > able to mark fwnode links as being part of cycles. fwnode links marked > as being part of a cycle should not block their consumers from probing. ... > + list_for_each_entry(link, &fwnode->suppliers, c_hook) { > + if (link->flags & FWLINK_FLAG_CYCLE) > + continue; > + return link->supplier; Hmm... if (!(link->flags & FWLINK_FLAG_CYCLE)) return link->supplier; ? > + } > + > + return NULL; ... > - if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) && > - !fw_devlink_is_permissive()) { > - sup_fw = list_first_entry(&dev->fwnode->suppliers, > - struct fwnode_link, > - c_hook)->supplier; > + sup_fw = fwnode_links_check_suppliers(dev->fwnode); dev_fwnode() ? ... > - val = !list_empty(&dev->fwnode->suppliers); > + mutex_lock(&fwnode_link_lock); > + val = !!fwnode_links_check_suppliers(dev->fwnode); Ditto? > + mutex_unlock(&fwnode_link_lock); -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel