From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B65C61DA7 for ; Fri, 27 Jan 2023 09:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233210AbjA0JpF (ORCPT ); Fri, 27 Jan 2023 04:45:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231969AbjA0JpE (ORCPT ); Fri, 27 Jan 2023 04:45:04 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8A56761F9; Fri, 27 Jan 2023 01:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674812703; x=1706348703; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qVG3SO3/mw1Za7KIPJqbPMkWrirnnDCNx1aYcVedBMY=; b=VmoFcCYL/V5hZ4+O+K0sTip9tuFwjzGmtekPy9372nVufBYyAS7bzuPF P2ooTJBTOief0Il0obQrpjHBi2hadWpcBJoXwV9l/NM0Xg/xILDL2EWKb K+ZPctdO4KggQNIEmwcBertcJtjbVm0UbdFbU5Jx3qFeqUJgnvc+rofvI 0ZiLoQcDe8rsm5yBrsCp7zP24HYnSP8NCEUeIjvoQgoDOGonSLMl10PiT ejfGaDtXkJ80uu59biMXJGMzVBmDCR4sHRnAmBCVO3+xMiw/wJ0xv9CZ9 6D/bstbiq2/8XU/t7Q/Wm8ONQ4BCvW0sQqzBxWocV4z+5ZMBgjsZLp12I Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="413277656" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="413277656" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:45:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="908614631" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="908614631" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 27 Jan 2023 01:44:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLLHs-00FtoI-1i; Fri, 27 Jan 2023 11:44:48 +0200 Date: Fri, 27 Jan 2023 11:44:48 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jan 27, 2023 at 10:30:35AM +0100, Geert Uytterhoeven wrote: > On Fri, Jan 27, 2023 at 10:25 AM Andy Shevchenko > wrote: > > On Thu, Jan 26, 2023 at 04:11:30PM -0800, Saravana Kannan wrote: ... > > > - of_node_set_flag(np, OF_POPULATED); > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > of_fwnode_handle(np) ? > > Or of_node_to_fwnode(). Not really. > Looks like we have (at least) two of them... Yes, and the latter one is IRQ subsystem invention. Should gone in favour of the generic helper. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B89C4C54EAA for ; Fri, 27 Jan 2023 09:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=92h4FHNdeKmG9WEVVk3bQRNJL0/XICOgMOcbiZzQjKI=; b=bTW7Ai3GaV9FI3 czYFt6gsiXP6SkUAkgPw+SI+ZC2G2gMoKv9l30VGdXlS1KCmiS/2UC3KXoodGiBHkEsseYleYC1Bn BlN2ZO8T+ZtRjw+60CNNwYKbOdTWR/zl2NSPmuWvej8mhFXgbouOHEXuz4b1cchec8m4lxVjVibeT h5/4MGAImwcb1NjzHga+Tmk+LMvQt+MfxABFU9BRMtvSy0IVGYYS0M372lYzIjBlVc6bpCm/It6u8 uT3+jtByTQ5aeyBMrh6WQDM858LTTxFo7RLpW9TqjOO2bWg+qXWrZ+4DaagpEFZBtgyIH0AxBzGcV 2UCZkt2nffuUZ0DuI3rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLLIE-00Dktj-Lw; Fri, 27 Jan 2023 09:45:10 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLLIA-00DkrW-O2 for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 09:45:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674812706; x=1706348706; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qVG3SO3/mw1Za7KIPJqbPMkWrirnnDCNx1aYcVedBMY=; b=bT59ijHTHSQWzJy/33H2JZtuGhauZwOXW9T6biUPEe6N2/uSm0WNH8Jw 1UWpiH3M/CNnjexQSHRqnnSpmU42mO5PXHLA3Wi1XLRS1RmagppCdgPT2 LsVoYVPnJiERWkCiaPa1D51CsN+EGrVofkclxxHFvX9ueL3v7ZX8ZwPlp qWy9qj9vjlQROptorYjPOrfRnFeGz1JGKqRlpGRJqamg9z30S6mflYowS CzHy5PNoH8h8YO8v+kGEL5TSrs678NakuMtrtyqseeKrO45ZEvOb2dwcn QBZp2bN1A2ugSkpn9G+jtBddhSh7QtmGDBqbcvtJW+I8KO2nDlXCJXNT1 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="413277664" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="413277664" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:45:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="908614631" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="908614631" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 27 Jan 2023 01:44:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLLHs-00FtoI-1i; Fri, 27 Jan 2023 11:44:48 +0200 Date: Fri, 27 Jan 2023 11:44:48 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_014506_886754_1C32376E X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 10:30:35AM +0100, Geert Uytterhoeven wrote: > On Fri, Jan 27, 2023 at 10:25 AM Andy Shevchenko > wrote: > > On Thu, Jan 26, 2023 at 04:11:30PM -0800, Saravana Kannan wrote: ... > > > - of_node_set_flag(np, OF_POPULATED); > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > of_fwnode_handle(np) ? > > Or of_node_to_fwnode(). Not really. > Looks like we have (at least) two of them... Yes, and the latter one is IRQ subsystem invention. Should gone in favour of the generic helper. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel