From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 082B7C61DA7 for ; Fri, 27 Jan 2023 09:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231874AbjA0Jvr (ORCPT ); Fri, 27 Jan 2023 04:51:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231743AbjA0Jvq (ORCPT ); Fri, 27 Jan 2023 04:51:46 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA87D2713; Fri, 27 Jan 2023 01:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674813105; x=1706349105; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZWP6U/h1buqDvrZDQgJO3Y6rjFGk3hK7uUv26Hnc6SY=; b=iG/mm3HDa6YzH977juVQVf4trYcEdd8jVS0WF3burG1WprMo9WQCWdPt zagbVhQUsR9mR7/ell8Y3vYl+oQ41n8hsj7i9awshob4mvyyGMLp8crmj oJ3S0DRuThF5x8uz8Kxz2qozBw0il417AGHIoYwkfHeZD8dtb+UTsmd9d RcEZ38fnHMQpkveLcxhe5CgEgorJZNJeb/tHK6VeEbzASN2PotlTycrlK aCAT3J/b5QPWeJt+VWUo5vBXwsMLi1OiH2zwhs79XD1r96LTEWXXVb5rt 7KzMZ0IqB3adllrPiYYyHwkSucUds7KX7yg8/3Ft4eZEPlu1nWjgnXmuV g==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="389428691" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="389428691" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:51:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="771520372" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="771520372" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 27 Jan 2023 01:51:26 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLLOE-00Fu2l-0h; Fri, 27 Jan 2023 11:51:22 +0200 Date: Fri, 27 Jan 2023 11:51:21 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 10/11] irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-11-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127001141.407071-11-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jan 26, 2023 at 04:11:37PM -0800, Saravana Kannan wrote: > Since this device is only partially initialized by the irqchip driver, > we need to mark the fwnode device as not initialized. This is to let > fw_devlink know that the device will be completely initialized at a > later point. That way, fw_devlink will continue to defer the probe of > the power domain consumers till the power domain driver successfully > binds to the struct device and completes the initialization of the > device. ... > pd_pdev->dev.of_node = np; > + pd_pdev->dev.fwnode = of_fwnode_handle(np); Instead, device_set_node(&pd_dev->dev, of_fwnode_handle(np)); -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE632C54EAA for ; Fri, 27 Jan 2023 09:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OA1gnzSaeWgEAEh3cNiov7Alu6uGbSrVE6wK6FurCPU=; b=h405tfHEq56iq0 EEAePuzhRR5yGG3sbBcAs6DBvfdG4en9xKYUmamNJNbyMRm23K7TxB86y2ClXGLl39JrkVdZF6wrc CCptkWwSdBF6GFKfyNkKd0EpOy1eWKRe7AvvUcE8utU44qzI/IxWV7MkWROYC/f/RynU5tUAsA47V aLxZS0sgKq5QLDeviIBkXHdndjWB3F9hSBiVLqj8rTG1AMR4wn3S3GdTqlMTNXPxXvi34XcVQbTS+ CfWvq7fb9LwORyMEN3qhtDEZzfk4D9cZwiwQoooZfptBellyiQz1ktndu1tepUm6OVUDT++/Gyh6r qLQ8yo3Z4wRjlW6YuATw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLLOe-00DnAx-8f; Fri, 27 Jan 2023 09:51:48 +0000 Received: from mga06b.intel.com ([134.134.136.31] helo=mga06.intel.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLLOb-00Dn9c-AC for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 09:51:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674813105; x=1706349105; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZWP6U/h1buqDvrZDQgJO3Y6rjFGk3hK7uUv26Hnc6SY=; b=iG/mm3HDa6YzH977juVQVf4trYcEdd8jVS0WF3burG1WprMo9WQCWdPt zagbVhQUsR9mR7/ell8Y3vYl+oQ41n8hsj7i9awshob4mvyyGMLp8crmj oJ3S0DRuThF5x8uz8Kxz2qozBw0il417AGHIoYwkfHeZD8dtb+UTsmd9d RcEZ38fnHMQpkveLcxhe5CgEgorJZNJeb/tHK6VeEbzASN2PotlTycrlK aCAT3J/b5QPWeJt+VWUo5vBXwsMLi1OiH2zwhs79XD1r96LTEWXXVb5rt 7KzMZ0IqB3adllrPiYYyHwkSucUds7KX7yg8/3Ft4eZEPlu1nWjgnXmuV g==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="389428689" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="389428689" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:51:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="771520372" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="771520372" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 27 Jan 2023 01:51:26 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLLOE-00Fu2l-0h; Fri, 27 Jan 2023 11:51:22 +0200 Date: Fri, 27 Jan 2023 11:51:21 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 10/11] irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-11-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127001141.407071-11-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_015145_420581_AD64BE86 X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 26, 2023 at 04:11:37PM -0800, Saravana Kannan wrote: > Since this device is only partially initialized by the irqchip driver, > we need to mark the fwnode device as not initialized. This is to let > fw_devlink know that the device will be completely initialized at a > later point. That way, fw_devlink will continue to defer the probe of > the power domain consumers till the power domain driver successfully > binds to the struct device and completes the initialization of the > device. ... > pd_pdev->dev.of_node = np; > + pd_pdev->dev.fwnode = of_fwnode_handle(np); Instead, device_set_node(&pd_dev->dev, of_fwnode_handle(np)); -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel