From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, ysato@users.sourceforge.jp, dalias@libc.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h include
Date: Sat, 28 Jan 2023 20:56:27 +0100 [thread overview]
Message-ID: <Y9V963IQhnL9ieLk@corigine.com> (raw)
In-Reply-To: <Y9VNY2C1CuHHo6WY@corigine.com>
On Sat, Jan 28, 2023 at 05:29:37PM +0100, Simon Horman wrote:
> On Sat, Jan 28, 2023 at 05:16:48PM +0100, Simon Horman wrote:
> > On Fri, Jan 27, 2023 at 11:31:08PM -0800, Jakub Kicinski wrote:
> > > SuperH does not include uaccess.h, even tho it calls access_ok().
> >
> > I see that is true.
> > But it's less clear to me why that is a problem.
>
> Ok, now I see the kernel test robot splat.
> Let me try and reproduce it for my own edification.
Done. Unsurprisingly, your patch resolves the problem.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Tested-by: Simon Horman <simon.horman@corigine.com>
For the record, the splat is here:
- https://lore.kernel.org/netdev/202301281438.ZNGVwW6S-lkp@intel.com/
next prev parent reply other threads:[~2023-01-28 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 7:31 [PATCH net-next] sh: checksum: add missing linux/uaccess.h include Jakub Kicinski
2023-01-28 16:16 ` Simon Horman
2023-01-28 16:29 ` Simon Horman
2023-01-28 19:56 ` Simon Horman [this message]
2023-01-31 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9V963IQhnL9ieLk@corigine.com \
--to=simon.horman@corigine.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.