From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3739AC61DA4 for ; Sat, 28 Jan 2023 19:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233902AbjA1TKD (ORCPT ); Sat, 28 Jan 2023 14:10:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233816AbjA1TKC (ORCPT ); Sat, 28 Jan 2023 14:10:02 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A139A25291; Sat, 28 Jan 2023 11:10:01 -0800 (PST) Date: Sat, 28 Jan 2023 20:09:57 +0100 From: Pablo Neira Ayuso To: Vlad Buslov Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, ozsh@nvidia.com, marcelo.leitner@gmail.com, simon.horman@corigine.com Subject: Re: [PATCH net-next v5 2/7] netfilter: flowtable: fixup UDP timeout depending on ct state Message-ID: References: <20230127183845.597861-1-vladbu@nvidia.com> <20230127183845.597861-3-vladbu@nvidia.com> <87mt62ejd1.fsf@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87mt62ejd1.fsf@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jan 28, 2023 at 06:03:37PM +0200, Vlad Buslov wrote: > > On Sat 28 Jan 2023 at 16:27, Pablo Neira Ayuso wrote: > > Hi, > > > > On Fri, Jan 27, 2023 at 07:38:40PM +0100, Vlad Buslov wrote: > >> Currently flow_offload_fixup_ct() function assumes that only replied UDP > >> connections can be offloaded and hardcodes UDP_CT_REPLIED timeout value. > >> Allow users to modify timeout calculation by implementing new flowtable > >> type callback 'timeout' and use the existing algorithm otherwise. > >> > >> To enable UDP NEW connection offload in following patches implement > >> 'timeout' callback in flowtable_ct of act_ct which extracts the actual > >> connections state from ct->status and set the timeout according to it. > > > > I found a way to fix the netfilter flowtable after your original v3 > > update. > > > > Could you use your original patch in v3 for this fixup? > > Sure, please send me the fixup. What I mean is if you could use your original v3 2/7 for this conntrack timeout fixup: https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230119195104.3371966-3-vladbu@nvidia.com/ I will send a patch for netfilter's flowtable datapath to address the original issue I mentioned, so there is no need for this new timeout callback.