All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Oleksandr Tymoshenko <ovt@google.com>
Cc: stable@vger.kernel.org, Baokun Li <libaokun1@huawei.com>,
	"Darrick J . Wong" <djwong@kernel.org>, Jan Kara <jack@suse.cz>,
	stable@kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 5.15 1/1] ext4: fix bad checksum after online resize
Date: Mon, 30 Jan 2023 11:07:53 +0100	[thread overview]
Message-ID: <Y9eW+QZmt14x2GXJ@kroah.com> (raw)
In-Reply-To: <20230124090632.4185289-2-ovt@google.com>

On Tue, Jan 24, 2023 at 09:06:32AM +0000, Oleksandr Tymoshenko wrote:
> From: Baokun Li <libaokun1@huawei.com>
> 
> commit a408f33e895e455f16cf964cb5cd4979b658db7b upstream.
> 
> When online resizing is performed twice consecutively, the error message
> "Superblock checksum does not match superblock" is displayed for the
> second time. Here's the reproducer:
> 
> 	mkfs.ext4 -F /dev/sdb 100M
> 	mount /dev/sdb /tmp/test
> 	resize2fs /dev/sdb 5G
> 	resize2fs /dev/sdb 6G
> 
> To solve this issue, we moved the update of the checksum after the
> es->s_overhead_clusters is updated.
> 
> Fixes: 026d0d27c488 ("ext4: reduce computation of overhead during resize")
> Fixes: de394a86658f ("ext4: update s_overhead_clusters in the superblock during an on-line resize")
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Cc: stable@kernel.org
> Link: https://lore.kernel.org/r/20221117040341.1380702-2-libaokun1@huawei.com
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Any reason you forwarded on a modified patch and did not sign off on it
yourself?  Please fix that up and send it again.

thanks,

greg k-h

      reply	other threads:[~2023-01-30 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24  9:06 [PATCH 5.15 0/1] ext4: backport online resize fix Oleksandr Tymoshenko
2023-01-24  9:06 ` [PATCH 5.15 1/1] ext4: fix bad checksum after online resize Oleksandr Tymoshenko
2023-01-30 10:07   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9eW+QZmt14x2GXJ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=djwong@kernel.org \
    --cc=jack@suse.cz \
    --cc=libaokun1@huawei.com \
    --cc=ovt@google.com \
    --cc=stable@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.