From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14638C636CD for ; Mon, 30 Jan 2023 12:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236819AbjA3MK5 (ORCPT ); Mon, 30 Jan 2023 07:10:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236722AbjA3MKk (ORCPT ); Mon, 30 Jan 2023 07:10:40 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB7518B3F; Mon, 30 Jan 2023 04:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675080569; x=1706616569; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JTY9WLS4wVtKo44V42B48degtPfcQUTsiQPaSpOWAqU=; b=Lr7WebiOVHyL2ZVAhEP/TicykpCLcQxpwKbglijyg4LJ1i3nQVELqewr wvW+By2SF9eFR23FINzK5KsL1UBzdkNAi5iEZKOejae3FAoDRo548dEnJ If0WYlAN8ZRZY+0RkhxT0XlaisK33CLX6A5kS1KL0RyLpghSGF44SMBdk 6LdbEd3psB0a+PGxWrhKa9lm+VNr+fIDJF5mIYrrhvrDBP1Oyxeb9U2HV T/6LBNz2B0riW5HcfVbOLwjdXBInz7D+PvLd2Sjfl9+vsqOqcXjKR21fV XbXWkF+LQnvZWLOjZAGRsFjojqD2rJhmPDf1ZduVq9BKm+ApJTE59tUGE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="328816522" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="328816522" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 04:08:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="614008770" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="614008770" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 30 Jan 2023 04:08:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pMSxG-00HKyC-24; Mon, 30 Jan 2023 14:08:10 +0200 Date: Mon, 30 Jan 2023 14:08:10 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 05/11] driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-6-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jan 27, 2023 at 11:34:11PM -0800, Saravana Kannan wrote: > On Fri, Jan 27, 2023 at 1:30 AM Andy Shevchenko > wrote: > > On Thu, Jan 26, 2023 at 04:11:32PM -0800, Saravana Kannan wrote: ... > > > DL_FLAG_AUTOREMOVE_SUPPLIER | \ > > > DL_FLAG_AUTOPROBE_CONSUMER | \ > > > DL_FLAG_SYNC_STATE_ONLY | \ > > > - DL_FLAG_INFERRED) > > > + DL_FLAG_INFERRED | \ > > > + DL_FLAG_CYCLE) > > > > You can make less churn by squeezing the new one above the last one. > > I feel like this part is getting bike shedded. I'm going to leave it > as is. It's done in the order it's defined in the header and keeping > it that way makes it way more easier to read than worry about a single > line churn. Not at all. What you are showing here is the additional churn for the sake of the churn. With a no-cost trick you may avoid that. Also, it will compress better the Git index and save some mW here and there and in the size of the world and amount of Git copies of the Linux kernel this may save the planet (I'm serious, no jokes). -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6A92C54EAA for ; Mon, 30 Jan 2023 17:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jzD8D4QbZ3Yk4bV9DBfKAHa/FEV/AEqPYq7r2VYTDn4=; b=JQhoxIm+ssrpH3 /CW3bYAvqRospPSdEssS0fAU4BHB8VqeDoQleZ2xQ3NtTrTsV2Br6Y09EJOLUKCv7myrXLLnRH5w6 9/mdLZRuPHfL7StU4L8UJvxFoSstVIiMQIde/CMlW0KcQIjQjddQo/K9BmJbwXUE8AXP80hMqy3NP /ZTuSCuwgkmGS0+aTfZ0blr4kxZbqllNWfN1Z2FBcnziDMilF8iFi7b650TLqz6e/YK+8r5Nef/Li ON9iobIdvgp8YB1too90uIqZkWgRGce4FFsKE/YyORz54kOpFD7mpGRdlSVm7p3WENhkeOj0HzmvM tFO+QW2eZ+2xycFBpKDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMXX4-004M34-Bf; Mon, 30 Jan 2023 17:01:26 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMXWP-004M1g-9x for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 17:00:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675098045; x=1706634045; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JTY9WLS4wVtKo44V42B48degtPfcQUTsiQPaSpOWAqU=; b=K4rxNbNPEm1V8kTqanxdYFL+0MXuJamQFNw7PL3Nhy4djHeZR2E1A+se etdtKCMKOtnFeNSSNv9ThPjk9ZJRVbRdacYAAtXQbTKTMdRHUn9Ilwygu RF1PZiLqk7u7J1ljUCnofdjN8AzjMvJsOp0cprStOxq0KRznp8/lvngES fhrbrowjHdkQO3kCdFoOMawpijuRLTeSUS0RUp2l+Zqz+ZIUsu0N32cEv E78vw3K+OQA5sRC8HXCs4d5CpUv5fFQrtruYmNaGUXyH2UyCYXdosh0K2 pwkNEy4gCEqUVFSYJvQnHqqzw2/x24vwmhfrOrhFgx/ZVesroI8aZAjNa g==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="328816530" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="328816530" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 04:08:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="614008770" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="614008770" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 30 Jan 2023 04:08:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pMSxG-00HKyC-24; Mon, 30 Jan 2023 14:08:10 +0200 Date: Mon, 30 Jan 2023 14:08:10 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 05/11] driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-6-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_090045_421564_C844A6F4 X-CRM114-Status: GOOD ( 23.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 11:34:11PM -0800, Saravana Kannan wrote: > On Fri, Jan 27, 2023 at 1:30 AM Andy Shevchenko > wrote: > > On Thu, Jan 26, 2023 at 04:11:32PM -0800, Saravana Kannan wrote: ... > > > DL_FLAG_AUTOREMOVE_SUPPLIER | \ > > > DL_FLAG_AUTOPROBE_CONSUMER | \ > > > DL_FLAG_SYNC_STATE_ONLY | \ > > > - DL_FLAG_INFERRED) > > > + DL_FLAG_INFERRED | \ > > > + DL_FLAG_CYCLE) > > > > You can make less churn by squeezing the new one above the last one. > > I feel like this part is getting bike shedded. I'm going to leave it > as is. It's done in the order it's defined in the header and keeping > it that way makes it way more easier to read than worry about a single > line churn. Not at all. What you are showing here is the additional churn for the sake of the churn. With a no-cost trick you may avoid that. Also, it will compress better the Git index and save some mW here and there and in the size of the world and amount of Git copies of the Linux kernel this may save the planet (I'm serious, no jokes). -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel