From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6759BC636D0 for ; Mon, 30 Jan 2023 12:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236768AbjA3MMK (ORCPT ); Mon, 30 Jan 2023 07:12:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236792AbjA3MLv (ORCPT ); Mon, 30 Jan 2023 07:11:51 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8093C37B58; Mon, 30 Jan 2023 04:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675080649; x=1706616649; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=F7kz/t7goqTvjK8l9cj5cpA+WN6lVLHQofCFYgKQjgM=; b=Aub4vzzByvl995Nq/Eae36nOWF+39w2/pU82SLe6C9hmeMwOlfuI9b+O Uf0bdncd29F7r7mkcdGN7MZvTOIAaU7O3G1sBo0PGndkh8foBDpb6UBCy LBj9eM78iWKpFzdgYCnhGTyniLG6Wh7zGI2o4q1VqKKlVLXEb2dK/gGN2 +jMMpesFTQPK3Hk+RYm6ouuPvachQT+BDykaypjIYwn3jiLSNmPsB1RJf DBTpoEVxPZMdhAKRePctHROFkVmPQTUI4aBSISSnlparUHiy8KKKabvwp XYCtpqMsDQyeZ9yVDqtKyqaT06k2+d4s9uu63UceFZ4Zksx9fv2sl7BM/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="389906024" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="389906024" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 04:10:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="806649751" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="806649751" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 30 Jan 2023 04:09:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pMSyc-00HKzp-19; Mon, 30 Jan 2023 14:09:34 +0200 Date: Mon, 30 Jan 2023 14:09:34 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 06/11] driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-7-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jan 27, 2023 at 11:34:19PM -0800, Saravana Kannan wrote: > On Fri, Jan 27, 2023 at 1:33 AM Andy Shevchenko > wrote: > > On Thu, Jan 26, 2023 at 04:11:33PM -0800, Saravana Kannan wrote: ... > > > - if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) && > > > - !fw_devlink_is_permissive()) { > > > - sup_fw = list_first_entry(&dev->fwnode->suppliers, > > > - struct fwnode_link, > > > - c_hook)->supplier; > > > + sup_fw = fwnode_links_check_suppliers(dev->fwnode); > > > > dev_fwnode() ? > > > > ... > > > > > - val = !list_empty(&dev->fwnode->suppliers); > > > + mutex_lock(&fwnode_link_lock); > > > + val = !!fwnode_links_check_suppliers(dev->fwnode); > > > > Ditto? > > Similar response as Patch 1 and Patch 4. Same. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BA39C636D3 for ; Mon, 30 Jan 2023 18:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gMVIsm0180hjZTSjJEqQ0OZdoNgw849AEjVfjF3eZvw=; b=46w4CYAlTHbeHc zXWP5twXuhktHOt+eYacHycKFafDLlqbOi4uAyAk+k0JUKH76hLG8V4AqA4MMRw82YiAHi6Wmg6Yk h7PWc6AcsTGI4jrrNBHkk5ZRHwGXyFLQE9b90lFS5ncbNp6P33RStXjDLQtugO2u1mpD77u0t09UU yajt1qdX5IYFUBNgl+unb+K4KR1Lo59RKGGNJF6s7Euz6VsVxmjt24VaactfKjrPiEMgEsMD8zzrW 67awtVKqFw5XtTLDfpZH3TEoiyhC83CrntE0+7IBPi/naFQtOD3Xh6p9NWfF7nLFMhL8ezEjSM+TC VM5OJ4RognhlqKMKENLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMZ9u-0055lB-SF; Mon, 30 Jan 2023 18:45:39 +0000 Received: from mga06b.intel.com ([134.134.136.31] helo=mga06.intel.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMY0X-004ZwX-Id for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 17:31:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675099913; x=1706635913; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=F7kz/t7goqTvjK8l9cj5cpA+WN6lVLHQofCFYgKQjgM=; b=f8sTs7Qluc97m6u0iXSeB1pseW5mdFwBZzpkFHgUgyuzmPWweRxEbuKH 3VONV2rckcUPfll5djU8DwZGmLflU2bhsOWeatbiFbBbZsv2cU0N+drDV scNemWSFq9PTkQZfvVqA+gd0hj4dgrYmcTCn2fDCCV7VF7Me8EZtGIQy9 /RI67OxiaEya+NOdFhYosvHAx33G1JtYZQiwR0FuJqul2w+R6GgT037Hl K9tvDvsYMCoI5oAcTAHn8q/pijJULuhcZjxJMvU9zyiEDClG3Ck9w4KIY z6QQ33v7Bd6daTn7hMd9EuV6cCW9/5wQ8gKqq0PHZbsBPRqZHi8v+r3DA g==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="389906034" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="389906034" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 04:10:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="806649751" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="806649751" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 30 Jan 2023 04:09:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pMSyc-00HKzp-19; Mon, 30 Jan 2023 14:09:34 +0200 Date: Mon, 30 Jan 2023 14:09:34 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 06/11] driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-7-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_093153_683732_88352AAE X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 11:34:19PM -0800, Saravana Kannan wrote: > On Fri, Jan 27, 2023 at 1:33 AM Andy Shevchenko > wrote: > > On Thu, Jan 26, 2023 at 04:11:33PM -0800, Saravana Kannan wrote: ... > > > - if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) && > > > - !fw_devlink_is_permissive()) { > > > - sup_fw = list_first_entry(&dev->fwnode->suppliers, > > > - struct fwnode_link, > > > - c_hook)->supplier; > > > + sup_fw = fwnode_links_check_suppliers(dev->fwnode); > > > > dev_fwnode() ? > > > > ... > > > > > - val = !list_empty(&dev->fwnode->suppliers); > > > + mutex_lock(&fwnode_link_lock); > > > + val = !!fwnode_links_check_suppliers(dev->fwnode); > > > > Ditto? > > Similar response as Patch 1 and Patch 4. Same. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel