From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939A0C636CB for ; Mon, 30 Jan 2023 15:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237912AbjA3PSc (ORCPT ); Mon, 30 Jan 2023 10:18:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238050AbjA3PS2 (ORCPT ); Mon, 30 Jan 2023 10:18:28 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15B80C15C; Mon, 30 Jan 2023 07:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675091875; x=1706627875; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4jfbSarMFyi7cMttwvDR5yy006KKKlZ6jChWvaFjhEk=; b=YzBqa9ltyfekpYfTOa4cifNKNPR+88bOa3O8Wv+rESqnn2J+LHMlI/rI o6A8U4fHRSqF1WPTqJvkdqAf5d7MoodgCFRylMYlJYjVAZtkcfGTPKfHN ubEyEKoLEe5DoBjEIB2wpnnwiojIqDqJkewioulYGMzySAFgVOuJOj7T7 nmyEslTOIqYdadL+m6edgJx9LbgJtS/bXO9uLFHDWfAWAZ2PCzAE2KwVN EDbNeEfesgBBHObNEIqwdJ7YDnmsMjU7nJvP+ZugdKKa31A+7trTi7XGI 5yt1y9LevJD03nYULxtPQWKX18NcYe1zUWhJYc+BrWJ1poBsqhN/T/ylZ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="354898535" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="354898535" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 07:16:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="992938805" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="992938805" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 30 Jan 2023 07:16:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pMVtc-00HPM7-2k; Mon, 30 Jan 2023 17:16:36 +0200 Date: Mon, 30 Jan 2023 17:16:36 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 08/11] driver core: fw_devlink: Make cycle detection more robust Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-9-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jan 30, 2023 at 03:36:04PM +0100, Geert Uytterhoeven wrote: > On Mon, Jan 30, 2023 at 1:16 PM Andy Shevchenko > wrote: > > On Fri, Jan 27, 2023 at 11:34:28PM -0800, Saravana Kannan wrote: > > > On Fri, Jan 27, 2023 at 1:43 AM Andy Shevchenko > > > wrote: > > > > On Thu, Jan 26, 2023 at 04:11:35PM -0800, Saravana Kannan wrote: > > > > > +static bool __fw_devlink_relax_cycles(struct device *con, > > > > > + struct fwnode_handle *sup_handle) > > > > > +{ > > > > > + struct fwnode_link *link; > > > > > + struct device_link *dev_link; > > > > > > > > > + struct device *sup_dev = NULL, *par_dev = NULL; > > > > > > > > You can put it the first line since it's long enough. > > > > > > Wait, is that a style guideline to have the longer lines first? > > > > No, but it's easier to read. > > Yes it is, "reverse xmas tree" local variable ordering: > https://elixir.bootlin.com/linux/v6.2-rc6/source/Documentation/process/maintainer-netdev.rst#L272 Good to know, thanks! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6046C54EED for ; Mon, 30 Jan 2023 17:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R4Zf/ZofNrX4fQCZF/Hbb9cr9TZ6OTaeOBQJ+Ql+81I=; b=Ps3RVFzZOkGm8q HWwWqGuvadLA4OuaN2zAXwqdCjrEPXsl0Y599H0XqtOds+Nkgpr7di9U0hncgz7LIX4SzsFXJkor7 J5FoURwJGfvpGNgkgpXnSPZA3JPZlNEDs1qZ5hRiKEIOnXlZ9aa8Ddl0WQv2NOdpId803hLy78DhN UQSsXOgEHgf2WVkngeAxmIrZXiNiYZwQ66W7v/geeF/NKnCVTBlYpaPi6XrWBWsHhHHGrsuZSAd4F ecbBnF2lctGCnve7eGHAphgZzxGgawskrGHaNaBxftP8p8A6znOn2GlctqdnW31ZuhGDU1fosMziN /Oa94mqWoCS175W/kIzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMYAg-004f3L-Sf; Mon, 30 Jan 2023 17:42:24 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMY7K-004dZY-37 for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 17:38:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675100334; x=1706636334; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4jfbSarMFyi7cMttwvDR5yy006KKKlZ6jChWvaFjhEk=; b=lBgG5aYCCvSfKUf892ECAnS3vjD8g1mvYxTs975pvVH3YfKTNe5J/LYf PFjT6XhSNZdc5PqagqGf9fwHUE8NhWj5ONb3zXNGtGv2hUDa2AbdWBA1j MlJEIzwJ7EvYZonNe0niiT6pXrtCq8YQAChxXIEz6qnQPfp1ZVlbudl6M GPA2TgE6Iuuyt7QCAyNQZMpnHj0a6V5FE1zfZtEf5Is/Ac2q1Rg5hQ0u4 Pz0ELu80F4k51tRfiqahZZ1PJVH5UCvmMywXFaJ8s3RvGakmHtE6ENfuR WDiZ3c1yfkXEzUS1LkmbxMkx29AQvm8lMJtFJ3XrN5q4t2+FeAmnPekAa w==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="354898547" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="354898547" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 07:16:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="992938805" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="992938805" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 30 Jan 2023 07:16:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pMVtc-00HPM7-2k; Mon, 30 Jan 2023 17:16:36 +0200 Date: Mon, 30 Jan 2023 17:16:36 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 08/11] driver core: fw_devlink: Make cycle detection more robust Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-9-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_093854_224218_C6BBBD8B X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 03:36:04PM +0100, Geert Uytterhoeven wrote: > On Mon, Jan 30, 2023 at 1:16 PM Andy Shevchenko > wrote: > > On Fri, Jan 27, 2023 at 11:34:28PM -0800, Saravana Kannan wrote: > > > On Fri, Jan 27, 2023 at 1:43 AM Andy Shevchenko > > > wrote: > > > > On Thu, Jan 26, 2023 at 04:11:35PM -0800, Saravana Kannan wrote: > > > > > +static bool __fw_devlink_relax_cycles(struct device *con, > > > > > + struct fwnode_handle *sup_handle) > > > > > +{ > > > > > + struct fwnode_link *link; > > > > > + struct device_link *dev_link; > > > > > > > > > + struct device *sup_dev = NULL, *par_dev = NULL; > > > > > > > > You can put it the first line since it's long enough. > > > > > > Wait, is that a style guideline to have the longer lines first? > > > > No, but it's easier to read. > > Yes it is, "reverse xmas tree" local variable ordering: > https://elixir.bootlin.com/linux/v6.2-rc6/source/Documentation/process/maintainer-netdev.rst#L272 Good to know, thanks! -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel