From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 988F6C38142 for ; Tue, 31 Jan 2023 09:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uvCbDojx/rn2HUhwwISSh/ZG0cwOPW4VsGcmwU83OOc=; b=yx7O8wmtuh41Qi SXB+RdSDIV47l8x9diFFWCGz1ua8KMCcI4HX7Gv2rAFkjFRCzQilC4oqswRKaVvv3+5qApC/7W7yh mge8SoXXswKxho6VBDkigPMAvw7Pd6eV/C9imj9g/6FB7PlYCauXM7NEDKeJX1hrYGLjjZw4hfYC5 wVgWhyu5yS4M2OZyOZqNtHheOd67SPj0q3tqLAJRDcM7qmA3gCSf9bSGeFXfYbBHd4Ep8c6frc86f iGZhjvQxN2zrCVCFEtDXBP6RHIoK/6LhESBKaitBlSlpOT2us8u1oZ+fhsGGK4SoAyQXb/JPyI4Q6 Pnlnxf37luZupO7wLvLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMmkb-006wGT-Vx; Tue, 31 Jan 2023 09:16:26 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMmkZ-006wFD-D6 for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 09:16:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C9870B81A85; Tue, 31 Jan 2023 09:16:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D69C433EF; Tue, 31 Jan 2023 09:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675156580; bh=Ih0PYVI/3v1QhepfBfxFY1m0AXsNHpDVO9Rf3HfzqBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WT+v+xoSece8tMv4HjZWh8n8CBdtY0Uzh9ZzJlggooz8th19r9/9y8xpxkb8JSJw2 odAEqCizxdKCSiPmbsRaTYa/yv0O5XFAsGoTTWO+oPRoGWtRBSGAG/BbN5crUSbTod nhqU8/jlcOOn9O9aVnFwJd9NBMiagbC1rU2Do4uE= Date: Tue, 31 Jan 2023 10:16:17 +0100 From: Greg Kroah-Hartman To: Neil Armstrong Cc: Heikki Krogerus , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Message-ID: References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_011623_613390_6B3BAAE1 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote: > Introduce the UCSI PMIC Glink aux driver that communicates > with the aDSP firmware with the UCSI protocol which handles > the USB-C Port(s) Power Delivery. > > The UCSI messaging is necessary on newer Qualcomm SoCs to > provide USB role switch and altmode notifications. > > Signed-off-by: Neil Armstrong > --- > drivers/usb/typec/ucsi/Kconfig | 7 + > drivers/usb/typec/ucsi/Makefile | 1 + > drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 329 insertions(+) > > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig > index 8f9c4b9f31f7..dee6069e46a2 100644 > --- a/drivers/usb/typec/ucsi/Kconfig > +++ b/drivers/usb/typec/ucsi/Kconfig > @@ -58,4 +58,11 @@ config UCSI_STM32G0 > To compile the driver as a module, choose M here: the module will be > called ucsi_stm32g0. > > +config UCSI_PMIC_GLINK > + tristate "UCSI Qualcomm PMIC GLINK Interface Driver" > + depends on QCOM_PMIC_GLINK No way to test build this code without this option? > + help > + This driver enables UCSI support on platforms that expose UCSI > + interface as PMIC GLINK device. Module name when built? A follow-on patch can be sent, this is minor. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4863C636CD for ; Tue, 31 Jan 2023 09:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232417AbjAaJRw (ORCPT ); Tue, 31 Jan 2023 04:17:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232439AbjAaJRb (ORCPT ); Tue, 31 Jan 2023 04:17:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DBFB4859F; Tue, 31 Jan 2023 01:16:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FF616146B; Tue, 31 Jan 2023 09:16:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D69C433EF; Tue, 31 Jan 2023 09:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675156580; bh=Ih0PYVI/3v1QhepfBfxFY1m0AXsNHpDVO9Rf3HfzqBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WT+v+xoSece8tMv4HjZWh8n8CBdtY0Uzh9ZzJlggooz8th19r9/9y8xpxkb8JSJw2 odAEqCizxdKCSiPmbsRaTYa/yv0O5XFAsGoTTWO+oPRoGWtRBSGAG/BbN5crUSbTod nhqU8/jlcOOn9O9aVnFwJd9NBMiagbC1rU2Do4uE= Date: Tue, 31 Jan 2023 10:16:17 +0100 From: Greg Kroah-Hartman To: Neil Armstrong Cc: Heikki Krogerus , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Message-ID: References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote: > Introduce the UCSI PMIC Glink aux driver that communicates > with the aDSP firmware with the UCSI protocol which handles > the USB-C Port(s) Power Delivery. > > The UCSI messaging is necessary on newer Qualcomm SoCs to > provide USB role switch and altmode notifications. > > Signed-off-by: Neil Armstrong > --- > drivers/usb/typec/ucsi/Kconfig | 7 + > drivers/usb/typec/ucsi/Makefile | 1 + > drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 329 insertions(+) > > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig > index 8f9c4b9f31f7..dee6069e46a2 100644 > --- a/drivers/usb/typec/ucsi/Kconfig > +++ b/drivers/usb/typec/ucsi/Kconfig > @@ -58,4 +58,11 @@ config UCSI_STM32G0 > To compile the driver as a module, choose M here: the module will be > called ucsi_stm32g0. > > +config UCSI_PMIC_GLINK > + tristate "UCSI Qualcomm PMIC GLINK Interface Driver" > + depends on QCOM_PMIC_GLINK No way to test build this code without this option? > + help > + This driver enables UCSI support on platforms that expose UCSI > + interface as PMIC GLINK device. Module name when built? A follow-on patch can be sent, this is minor. thanks, greg k-h