From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, Michael Guralnik <michaelgur@nvidia.com>
Subject: Re: [PATCH rdma-next 1/2] RDMA/mlx5: Fix MR cache debugfs in switchdev mode
Date: Thu, 2 Feb 2023 11:07:54 -0400 [thread overview]
Message-ID: <Y9vRytF3hVU1BH95@nvidia.com> (raw)
In-Reply-To: <Y9vDHixeSgYvhVVT@unreal>
On Thu, Feb 02, 2023 at 04:05:18PM +0200, Leon Romanovsky wrote:
> On Thu, Feb 02, 2023 at 09:56:51AM -0400, Jason Gunthorpe wrote:
> > On Thu, Feb 02, 2023 at 11:03:06AM +0200, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@nvidia.com>
> > >
> > > Block MR cache debugfs creation while in switchdev mode and add missing
> > > debugfs cleanup in error path.
> >
> > Why does switchdev have anything to do with this?
> >
>
> Because we always had the following code in cleanup:
> 697 static void mlx5_mkey_cache_debugfs_cleanup(struct mlx5_ib_dev *dev)
> 698 {
> 699 if (!mlx5_debugfs_root || dev->is_rep)
> 700 return;
> 701
>
> MR cache shouldn't be used at all for IB representors, and more
> comprehensive patch will take more work than this simple solution.
That make sense, the commit message should explain it..
Jason
next prev parent reply other threads:[~2023-02-02 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 9:03 [PATCH rdma-next 0/2] Two small fixes to MR cache series Leon Romanovsky
2023-02-02 9:03 ` [PATCH rdma-next 1/2] RDMA/mlx5: Fix MR cache debugfs in switchdev mode Leon Romanovsky
2023-02-02 13:56 ` Jason Gunthorpe
2023-02-02 14:05 ` Leon Romanovsky
2023-02-02 15:07 ` Jason Gunthorpe [this message]
2023-02-06 13:44 ` Leon Romanovsky
2023-02-02 9:03 ` [PATCH rdma-next 2/2] RDMA/mlx5: Remove impossible check of mkey cache cleanup failure Leon Romanovsky
2023-02-06 13:44 ` [PATCH rdma-next 0/2] Two small fixes to MR cache series Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9vRytF3hVU1BH95@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.