From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12396C61DA4 for ; Thu, 2 Feb 2023 15:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232292AbjBBPgM (ORCPT ); Thu, 2 Feb 2023 10:36:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232708AbjBBPfn (ORCPT ); Thu, 2 Feb 2023 10:35:43 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06695485AC for ; Thu, 2 Feb 2023 07:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675352104; x=1706888104; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hU+Gt/5Yu9M/7rlNN+qDySQonUycDkbqLPa/l+PoyVE=; b=XLKF5jGkzYmwjfKC63NEtle1L0RH6qkHH1ioLJNTxds/YvPjKwcxfy8i plObl+dV9kwDZk6dFGKWc6ryy6cnXKAQ/aDxka2IuM2P7uzXW2oLzejzG yCgtMlb4an/v50B28RgUsaXyoI2161Z4RNsg2qsX7UgcFQsq1JQklyWAs Ryl0xE8ecWimVi57oxwKIajjVjr1D/bt5cDNJ5iyg368bC6VF4HDYhla5 OvuQhH5hGIPRQcbymbdpY5+B8fydqYCcIljo0L6J/+Zyoe/N3sSHUJm5i +wL6/74fzMOj+pEJcfIhgxCfzuuT2C+Q8XvkKZEDhJl83/3SYdNAPnm+L w==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="393056460" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="393056460" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 07:31:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="667317636" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="667317636" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 02 Feb 2023 07:31:20 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pNbYV-001EcV-0b; Thu, 02 Feb 2023 17:31:19 +0200 Date: Thu, 2 Feb 2023 17:31:18 +0200 From: Andy Shevchenko To: Christoph Hellwig Cc: Greg Kroah-Hartman , Daniele Ceraolo Spurio , Alexander Usyskin , linux-kernel@vger.kernel.org, Tomas Winkler , Arnd Bergmann Subject: Re: [PATCH v1 1/1] mei: Move uuid_le_cmp() to its only user Message-ID: References: <20230202145412.87569-1-andriy.shevchenko@linux.intel.com> <20230202151759.GA28861@lst.de> <20230202152234.GA28999@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202152234.GA28999@lst.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2023 at 04:22:34PM +0100, Christoph Hellwig wrote: > On Thu, Feb 02, 2023 at 05:21:52PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 02, 2023 at 04:17:59PM +0100, Christoph Hellwig wrote: > > > On Thu, Feb 02, 2023 at 04:54:12PM +0200, Andy Shevchenko wrote: > > > > There is only a single user of uuid_le_cmp() API, let's make it private > > > > to that user. > > > > > > Any reason this code can't just use guid_t and guid_equal? > > > > It's part of ABI, while guid_* are for the internal use. > > > > Eventually they may switch to the internal types, but it's up to MEI. > > How can a type name be part of a binary interface? If I'm not mistaken there is a difference between simple __u8[16] and struct { __u8[16] } due to alignment. But data wise it's the same, of course. That said, it depends on how this type is being used in the any of ABI. >From the API perspective the guid_* are not visible to uAPI. -- With Best Regards, Andy Shevchenko