From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB6BC05027 for ; Thu, 2 Feb 2023 15:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231949AbjBBPnc (ORCPT ); Thu, 2 Feb 2023 10:43:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231482AbjBBPnb (ORCPT ); Thu, 2 Feb 2023 10:43:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5454C59249; Thu, 2 Feb 2023 07:43:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3462B8269D; Thu, 2 Feb 2023 15:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE839C433EF; Thu, 2 Feb 2023 15:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675352510; bh=lD97WjMFfzRMg6df8DJW2vEHvzACjBV63gqtOgCSXF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eKXfNXArz4F/hgG3clG1VGCWffyY+a47+vgraFfY6acFiDbl82ruo1kfw8NWqWrbU c9ediAvBlYT4Ak2XQ4N08aouJB0p/+/DoK5Uw+iVOaaJqQTJrNeqBuRaddNli/rrYl v2yuld3w40knXzUcIGo/2pL/5QViwKa73hgi83LQ= Date: Thu, 2 Feb 2023 16:41:47 +0100 From: Greg KH To: Gary Guo Cc: Peter Zijlstra , Boqun Feng , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , Mark Rutland , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Vincenzo Palazzo Subject: Re: [RFC 2/5] rust: sync: Arc: Introduces ArcInner::count() Message-ID: References: <20230201232244.212908-1-boqun.feng@gmail.com> <20230201232244.212908-3-boqun.feng@gmail.com> <20230202142153.352ba479.gary@garyguo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202142153.352ba479.gary@garyguo.net> Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On Thu, Feb 02, 2023 at 02:21:53PM +0000, Gary Guo wrote: > On Thu, 2 Feb 2023 10:14:06 +0100 > Peter Zijlstra wrote: > > > On Wed, Feb 01, 2023 at 03:22:41PM -0800, Boqun Feng wrote: > > > This allows reading the current count of a refcount in an `ArcInner`. > > > > > > Signed-off-by: Boqun Feng > > > --- > > > rust/helpers.c | 6 ++++++ > > > rust/kernel/sync/arc.rs | 9 +++++++++ > > > 2 files changed, 15 insertions(+) > > > > > > diff --git a/rust/helpers.c b/rust/helpers.c > > > index 09a4d93f9d62..afc5f1a39fef 100644 > > > --- a/rust/helpers.c > > > +++ b/rust/helpers.c > > > @@ -46,6 +46,12 @@ bool rust_helper_refcount_dec_and_test(refcount_t *r) > > > } > > > EXPORT_SYMBOL_GPL(rust_helper_refcount_dec_and_test); > > > > > > +unsigned int rust_helper_refcount_read(refcount_t *r) > > > +{ > > > + return refcount_read(r); > > > +} > > > +EXPORT_SYMBOL_GPL(rust_helper_refcount_read); > > > + > > > /* > > > * We use `bindgen`'s `--size_t-is-usize` option to bind the C `size_t` type > > > * as the Rust `usize` type, so we can use it in contexts where Rust > > > diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs > > > index fc680a4a795c..fbfceaa3096e 100644 > > > --- a/rust/kernel/sync/arc.rs > > > +++ b/rust/kernel/sync/arc.rs > > > @@ -127,6 +127,15 @@ struct ArcInner { > > > data: T, > > > } > > > > > > +impl ArcInner { > > > + /// Returns the current reference count of [`ArcInner`]. > > > + fn count(&self) -> u32 { > > > + // SAFETY: `self.refcount.get()` is always a valid pointer, and `refcount_read()` is a > > > + // normal atomic read (i.e. no data race) only requiring on the address is valid. > > > + unsafe { bindings::refcount_read(self.refcount.get()) } > > > + } > > > +} > > > > This is completely unsafe vs concurrency. In order to enable correct > > tracing of refcount manipulations we have the __refcount_*(.oldp) API. > > Retrieving the reference count is safe. It's just that in many > scenarios it's very hard to use the retrieved reference count > correctly, because it might be concurrently changed. Yes, so you really should never ever ever care about the value, and that includes printing it out as it will be wrong the instant you read it. > But there are correct ways to use a refcount, e.g. if you own > `Arc` and `.count()` returns 1, then you know that you are the > exclusive owner of the `Arc` and nobody else is going to touch it. But you should never know this, as it is not relevant. So no, please don't allow printing out of a reference count, that will only cause problems and allow people to think it is safe to do so. Peter is right, please don't do this. thanks, greg k-h