All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Moshe Shemesh <moshe@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@nvidia.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] devlink: Move devlink dev code to a separate file
Date: Thu, 2 Feb 2023 16:44:17 +0100	[thread overview]
Message-ID: <Y9vaUZkiERmasO/9@nanopsycho> (raw)
In-Reply-To: <1675349226-284034-1-git-send-email-moshe@nvidia.com>

Thu, Feb 02, 2023 at 03:46:59PM CET, moshe@nvidia.com wrote:
>This patchset is moving code from the file leftover.c to new file dev.c.
>About 1.3K lines are moved by this patchset covering most of the devlink
>dev object callbacks and functionality: reload, eswitch, info, flash and
>selftest.
>
>Moshe Shemesh (7):
>  devlink: Split out dev get and dump code
>  devlink: Move devlink dev reload code to dev
>  devlink: Move devlink dev eswitch code to dev
>  devlink: Move devlink dev info code to dev
>  devlink: Move devlink dev flash code to dev
>  devlink: Move devlink_info_req struct to be local
>  devlink: Move devlink dev selftest code to dev
>
> net/devlink/Makefile        |    2 +-
> net/devlink/dev.c           | 1343 ++++++++++++++++++++++++++++++++
> net/devlink/devl_internal.h |   30 +
> net/devlink/leftover.c      | 1470 ++---------------------------------
> 4 files changed, 1435 insertions(+), 1410 deletions(-)
> create mode 100644 net/devlink/dev.c

Looks fine to me.

Thanks Moshe!

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

  parent reply	other threads:[~2023-02-02 15:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 14:46 [PATCH net-next 0/7] devlink: Move devlink dev code to a separate file Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 1/7] devlink: Split out dev get and dump code Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 2/7] devlink: Move devlink dev reload code to dev Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 3/7] devlink: Move devlink dev eswitch " Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 4/7] devlink: Move devlink dev info " Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 5/7] devlink: Move devlink dev flash " Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 6/7] devlink: Move devlink_info_req struct to be local Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 7/7] devlink: Move devlink dev selftest code to dev Moshe Shemesh
2023-02-02 18:17   ` Jakub Kicinski
2023-02-02 19:33     ` Moshe Shemesh
2023-02-02 19:46       ` Jakub Kicinski
2023-02-03  8:02         ` Jiri Pirko
2023-02-02 15:44 ` Jiri Pirko [this message]
2023-02-04  3:30 ` [PATCH net-next 0/7] devlink: Move devlink dev code to a separate file patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9vaUZkiERmasO/9@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.