From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2848C61DA4 for ; Thu, 2 Feb 2023 16:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232415AbjBBQg2 (ORCPT ); Thu, 2 Feb 2023 11:36:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232039AbjBBQgU (ORCPT ); Thu, 2 Feb 2023 11:36:20 -0500 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D2B06A32A; Thu, 2 Feb 2023 08:36:19 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 10E625C00EE; Thu, 2 Feb 2023 11:36:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 02 Feb 2023 11:36:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675355779; x=1675442179; bh=TIhEi6ttvP0lJU+5WCdxSL+GeMSa 1GjHCMM3WgC2HbI=; b=VSnQjrveDF/yWKN17jbl9A9KQ/20d/BLeyFmh0sJKD56 mr2sArWTxPJqrq0t21IsDdsmuGPwzjV8N3BCxZkYApxD4AySNsR8Q5pubCcrm6N9 v0HNjbvyq7XNxz9EYe+S74z9J/64clwZjICyOemliKqsmTlJfD7umrgNMaGtDvZF 7JacA/sjYffBIvZagOMjNOrS0z10yFIYqa8FiZMC5IFBwQCfv4xQy+FRhe582e1k A8T2NY+LPGDILcFXSBNzbXL2a2UtxlBylDyeMxSkQTdTwfh7P3BFj3neTk9MmiRM rIWs41yaVPnc6rZqsp87EV/xcK6pkXDGagWgLvyOJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepjeekleettddtgfeuvdffieffudegffetgedtteffvefgjeejvefhffehtddv ueevnecuffhomhgrihhnpehpohhrthdrshhhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 11:36:17 -0500 (EST) Date: Thu, 2 Feb 2023 18:36:14 +0200 From: Ido Schimmel To: netdev@kapio-technology.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 0/5] ATU and FDB synchronization on locked ports Message-ID: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2023 at 05:19:07PM +0100, netdev@kapio-technology.com wrote: > On 2023-02-02 16:43, Ido Schimmel wrote: > > On Thu, Feb 02, 2023 at 08:37:08AM +0100, netdev@kapio-technology.com > > wrote: > > > On 2023-01-31 20:25, Ido Schimmel wrote: > > > > > > > > Will try to review tomorrow, but it looks like this set is missing > > > > selftests. What about extending bridge_locked_port.sh? > > > > > > I knew you would take this up. :-) > > > But I am not sure that it's so easy to have selftests here as it is > > > timing > > > based and it would take the 5+ minutes just waiting to test in the > > > stadard > > > case, and there is opnly support for mv88e6xxx driver with this > > > patch set. > > > > The ageing time is configurable: See commit 081197591769 ("selftests: > > net: bridge: Parameterize ageing timeout"). Please add test cases in the > > next version. > > When I was looking at configuring the ageing time last time, my finding was > that the ageing time could not be set very low as there was some part in the > DSA layer etc, and confusion wrt units. I think the minimum secured was like > around 2 min. (not validated), which is not that much of an improvement for > fast testing. If you know what would be a good low timeout to set, I would > like to know. My point is that the ageing time is parametrized via 'LOW_AGEING_TIME' in forwarding.config so just use '$LOW_AGEING_TIME' in the selftest and set it as high as it needs to be for mv88e6xxx in your own forwarding.config. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 421BFC61DA4 for ; Thu, 2 Feb 2023 16:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PDLjOhntRyZz7+nb4UKBgZ7WRCH3zqzdAtOTPoxhvRo=; b=pg2CW4+hDyhMCb idbBpMQs6MtWS47LmBWjDV/+FJyPAoa11dcBcU9cOrHW3koiIc3QfgdtIS0vFuo4Hdx7Bof4CcChQ 1Gjp1rJ5+D9Lh9m8FzoF3A97XaQehyhr0nxoVzNC+roRP/hi0tnVDa0WwvLy/q118fp/li9Hw+jJz mV+KHmbaclzYlsfzar6LHd5FLS6WaiLjdE0yzFKNdxYXur2r2gMGjl1RsLUljz4Ntu6uf9KYS8u7u flQXf7x+y0WnRJp9L2scsspAtE/Nx8yHM+ofgUNBt1N/JsW3EpyMHRfyn9JClt0Ghg2gHml0jShhV h10Km2k9KPaZfGe+6rOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNcZT-00GfzO-4P; Thu, 02 Feb 2023 16:36:23 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNcZQ-00Gfxy-3P; Thu, 02 Feb 2023 16:36:21 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 10E625C00EE; Thu, 2 Feb 2023 11:36:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 02 Feb 2023 11:36:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675355779; x=1675442179; bh=TIhEi6ttvP0lJU+5WCdxSL+GeMSa 1GjHCMM3WgC2HbI=; b=VSnQjrveDF/yWKN17jbl9A9KQ/20d/BLeyFmh0sJKD56 mr2sArWTxPJqrq0t21IsDdsmuGPwzjV8N3BCxZkYApxD4AySNsR8Q5pubCcrm6N9 v0HNjbvyq7XNxz9EYe+S74z9J/64clwZjICyOemliKqsmTlJfD7umrgNMaGtDvZF 7JacA/sjYffBIvZagOMjNOrS0z10yFIYqa8FiZMC5IFBwQCfv4xQy+FRhe582e1k A8T2NY+LPGDILcFXSBNzbXL2a2UtxlBylDyeMxSkQTdTwfh7P3BFj3neTk9MmiRM rIWs41yaVPnc6rZqsp87EV/xcK6pkXDGagWgLvyOJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepjeekleettddtgfeuvdffieffudegffetgedtteffvefgjeejvefhffehtddv ueevnecuffhomhgrihhnpehpohhrthdrshhhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 11:36:17 -0500 (EST) Date: Thu, 2 Feb 2023 18:36:14 +0200 From: Ido Schimmel To: netdev@kapio-technology.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 0/5] ATU and FDB synchronization on locked ports Message-ID: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_083620_235331_163FB606 X-CRM114-Status: GOOD ( 22.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 02, 2023 at 05:19:07PM +0100, netdev@kapio-technology.com wrote: > On 2023-02-02 16:43, Ido Schimmel wrote: > > On Thu, Feb 02, 2023 at 08:37:08AM +0100, netdev@kapio-technology.com > > wrote: > > > On 2023-01-31 20:25, Ido Schimmel wrote: > > > > > > > > Will try to review tomorrow, but it looks like this set is missing > > > > selftests. What about extending bridge_locked_port.sh? > > > > > > I knew you would take this up. :-) > > > But I am not sure that it's so easy to have selftests here as it is > > > timing > > > based and it would take the 5+ minutes just waiting to test in the > > > stadard > > > case, and there is opnly support for mv88e6xxx driver with this > > > patch set. > > > > The ageing time is configurable: See commit 081197591769 ("selftests: > > net: bridge: Parameterize ageing timeout"). Please add test cases in the > > next version. > > When I was looking at configuring the ageing time last time, my finding was > that the ageing time could not be set very low as there was some part in the > DSA layer etc, and confusion wrt units. I think the minimum secured was like > around 2 min. (not validated), which is not that much of an improvement for > fast testing. If you know what would be a good low timeout to set, I would > like to know. My point is that the ageing time is parametrized via 'LOW_AGEING_TIME' in forwarding.config so just use '$LOW_AGEING_TIME' in the selftest and set it as high as it needs to be for mv88e6xxx in your own forwarding.config. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A633760AD2 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 034F861180 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675355779; x=1675442179; bh=TIhEi6ttvP0lJU+5WCdxSL+GeMSa 1GjHCMM3WgC2HbI=; b=VSnQjrveDF/yWKN17jbl9A9KQ/20d/BLeyFmh0sJKD56 mr2sArWTxPJqrq0t21IsDdsmuGPwzjV8N3BCxZkYApxD4AySNsR8Q5pubCcrm6N9 v0HNjbvyq7XNxz9EYe+S74z9J/64clwZjICyOemliKqsmTlJfD7umrgNMaGtDvZF 7JacA/sjYffBIvZagOMjNOrS0z10yFIYqa8FiZMC5IFBwQCfv4xQy+FRhe582e1k A8T2NY+LPGDILcFXSBNzbXL2a2UtxlBylDyeMxSkQTdTwfh7P3BFj3neTk9MmiRM rIWs41yaVPnc6rZqsp87EV/xcK6pkXDGagWgLvyOJQ== Date: Thu, 2 Feb 2023 18:36:14 +0200 From: Ido Schimmel Message-ID: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> Subject: Re: [Bridge] [PATCH net-next 0/5] ATU and FDB synchronization on locked ports List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: netdev@kapio-technology.com Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , Ivan Vecera , Florian Fainelli , "moderated list:ETHERNET BRIDGE" , Russell King , Roopa Prabhu , kuba@kernel.org, Paolo Abeni , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Christian Marangi , Woojung Huh , Landen Chao , Jiri Pirko , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev@vger.kernel.org, open list , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , Vladimir Oltean , davem@davemloft.net On Thu, Feb 02, 2023 at 05:19:07PM +0100, netdev@kapio-technology.com wrote: > On 2023-02-02 16:43, Ido Schimmel wrote: > > On Thu, Feb 02, 2023 at 08:37:08AM +0100, netdev@kapio-technology.com > > wrote: > > > On 2023-01-31 20:25, Ido Schimmel wrote: > > > > > > > > Will try to review tomorrow, but it looks like this set is missing > > > > selftests. What about extending bridge_locked_port.sh? > > > > > > I knew you would take this up. :-) > > > But I am not sure that it's so easy to have selftests here as it is > > > timing > > > based and it would take the 5+ minutes just waiting to test in the > > > stadard > > > case, and there is opnly support for mv88e6xxx driver with this > > > patch set. > > > > The ageing time is configurable: See commit 081197591769 ("selftests: > > net: bridge: Parameterize ageing timeout"). Please add test cases in the > > next version. > > When I was looking at configuring the ageing time last time, my finding was > that the ageing time could not be set very low as there was some part in the > DSA layer etc, and confusion wrt units. I think the minimum secured was like > around 2 min. (not validated), which is not that much of an improvement for > fast testing. If you know what would be a good low timeout to set, I would > like to know. My point is that the ageing time is parametrized via 'LOW_AGEING_TIME' in forwarding.config so just use '$LOW_AGEING_TIME' in the selftest and set it as high as it needs to be for mv88e6xxx in your own forwarding.config.