From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6901C433E0 for ; Tue, 26 Jan 2021 08:44:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 413CA20793 for ; Tue, 26 Jan 2021 08:44:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 413CA20793 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4Jxi-0004uA-M5 for qemu-devel@archiver.kernel.org; Tue, 26 Jan 2021 03:44:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4JuA-0003ZE-L0; Tue, 26 Jan 2021 03:40:54 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:54759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4Ju8-0004c9-BR; Tue, 26 Jan 2021 03:40:54 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 8EABB58094D; Tue, 26 Jan 2021 03:40:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 26 Jan 2021 03:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=PMsbskp7osdjoAEx1RrE2uXCnrM ywwykNLMVi0nX6yE=; b=z40VsxLXo9GjBNUxYWYWVuhvntsSWdnypxWJCmaG+oM OLi0qhY/NycasEbFKJtHB/G5jBbVDITWLu7MA+WYiPMH5SamNj+O6Ahxu020N5Bg 0oytvEUmJUit+p74bgl4n63uN5NMakTRyFil6iq3uQ1vOiuQDMlQpFeQ5QGbOlna Rik+M3avHgr/SCk/6Y/HP4rrAQLwRB+BpXFmKpbKon+mmo31oz+cAZ3L1TgjB4xh SIkyT7b0STt8h4Yo6DDap/yifHNzcK0yxs5MPAPKoNul5o4lAF0isnuG+Tq3a/HK RhkT3BnLIvXh+epX/OJl5qVzpRMOpYu3aBcheWyG6FQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PMsbsk p7osdjoAEx1RrE2uXCnrMywwykNLMVi0nX6yE=; b=V5OcIkYwxBQ2QiQV8omNot aJEl8r5o7OkM69qqkcELFwCnDFVapY7PNjAbi9bbREVsxsZS+XikYCeKJNKckflA gGVI12cI8OqmwimBqikkRYSlD9gEoWOdn9U2gWknA1FHTsHBrPNcBzOb54NrC2uO DiYgp1uzmZRlDPr1H4k0+HWvYJ7UT69C8gUjq8w7E9fx1XRyChkQhx0+T6q7N+S2 1uj636t1emrE1vGZchllcbZvIaV+WL+Vc20LM+Xcyc0LTkz3WBVQstrtVsNpOMKs xeyTmEtkgmYOZS3hNYo21mCeq/M66l6usUR9lhhqxzrjX/yPdyPoKtyNnwZSYrJw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeggdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeejgeduffeuieetkeeileekvdeuleetveejudeileduffefjeegfffhuddvudff keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 31761108005F; Tue, 26 Jan 2021 03:40:46 -0500 (EST) Date: Tue, 26 Jan 2021 09:40:44 +0100 From: Klaus Jensen To: Dmitry Fomichev Subject: Re: [PATCH 0/3] Fix zone write validation Message-ID: References: <20210126050248.9077-1-dmitry.fomichev@wdc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3DFXH55EJH6hxP4D" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.229; envelope-from=its@irrelevant.dk; helo=new3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Niklas Cassel , Damien Le Moal , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --3DFXH55EJH6hxP4D Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jan 26 09:21, Klaus Jensen wrote: > On Jan 26 14:02, Dmitry Fomichev wrote: > > These patches solve a few problems that exist in zoned Write > > ans Zone Append validation code. > >=20 > > Dmitry Fomichev (3): > > hw/block/nvme: Check for zone boundary during append > > hw/block/nvme: Check zone state before checking boundaries > > hw/block/nvme: Add trace events for zone boundary violations > >=20 > > hw/block/nvme.c | 35 ++++++++++++++++++++--------------- > > hw/block/trace-events | 3 +++ > > 2 files changed, 23 insertions(+), 15 deletions(-) > >=20 >=20 > I don't think there are any obvious benefits to this series over my fix > and since you didn't identify any functional issues with it, I'm > thinking we go with that. >=20 > My fix additionally removes setting ALBA in the CQE for regular writes > and bundles the endianness fix by changing the related logic in > do_write. >=20 > I have a couple of series in queue that also includes zoned writes and > there is no reason they have to indirectly deal with append. It's just > cleaner to move this special case closer to where it's used. Keith, I think this calls for your +1 tiebreaking special ability. --3DFXH55EJH6hxP4D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmAP1YoACgkQTeGvMW1P DemikAgAgPUlzF6kEZvwJE6mfeHupSaVf/wKbfLGBP3rPSZqZGPJRHg/XlgiZEw0 E3vIuMGq3OZ3kcV24hLG3jdE18ypKCjJp57M/18jHJgaKjNNXUpCwuRG9PYTkcXE TRhvFkNVj+Kvv7Hg0gOLxsRlwouILmNXoqRKyZcZ8aShaSAtIO/Usrn6Ydrx23zu LI3ZgcqKXtWqCKqGQ44I2keMeGsJvnfmHF5APFqepbPEbi1iLa8v77/4WKFXSIwO uoWX0x/JIKshKxeLQgximZAYLl+ew2V3yHzXXR5VdpugcSEe02dvGUwuE/QErLJu 476zPYq9HEe3bx4kpL0s6z79OVdOLQ== =vIJj -----END PGP SIGNATURE----- --3DFXH55EJH6hxP4D--