From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lee Shawn C <shawn.c.lee@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: support two CSC module on gen11 and later
Date: Thu, 14 Jan 2021 17:31:42 +0200 [thread overview]
Message-ID: <YABj3sk5eF43yhwm@intel.com> (raw)
In-Reply-To: <20210114092236.20477-1-shawn.c.lee@intel.com>
On Thu, Jan 14, 2021 at 05:22:36PM +0800, Lee Shawn C wrote:
> There are two CSC on pipeline on gen11 and later platform.
> User space application is allowed to enable CTM and RGB
> to YCbCr coversion at the same time now.
>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: Shankar Uma <uma.shankar@intel.com>
>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 1a0f00f37ca9..721d5ce1ed2b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -8303,7 +8303,8 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc,
> return -EINVAL;
> }
>
> - if ((pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
> + if ((INTEL_GEN(dev_priv) < 11) &&
> + (pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
> pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR444) &&
> pipe_config->hw.ctm) {
Didn't realize we had this check here. It should really be moved
into {ivb,glk}_color_check().
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-14 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 9:22 [Intel-gfx] [PATCH] drm/i915: support two CSC module on gen11 and later Lee Shawn C
2021-01-14 10:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-14 14:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-14 15:31 ` Ville Syrjälä [this message]
2021-01-15 5:45 ` [Intel-gfx] [PATCH] " Lee, Shawn C
2021-01-15 5:46 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
2021-01-15 16:04 ` Ville Syrjälä
2021-01-15 6:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: support two CSC module on gen11 and later (rev2) Patchwork
2021-01-15 12:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-18 2:27 ` [Intel-gfx] [PATCH v3] drm/i915: support two CSC module on gen11 and later Lee Shawn C
2021-01-18 15:08 ` Ville Syrjälä
2021-01-18 3:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: support two CSC module on gen11 and later (rev3) Patchwork
2021-01-18 9:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YABj3sk5eF43yhwm@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=cooper.chiou@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shawn.c.lee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.