From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2557DC433E0 for ; Thu, 14 Jan 2021 15:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBB79238E7 for ; Thu, 14 Jan 2021 15:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729547AbhANPzs (ORCPT ); Thu, 14 Jan 2021 10:55:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728608AbhANPzs (ORCPT ); Thu, 14 Jan 2021 10:55:48 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34ACC061574; Thu, 14 Jan 2021 07:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c2nISwHQ1sx1QefEbT/WP5EtkYbOPh92hLF5ZFROw5s=; b=Z7qUy0klmVjhHzu7z3/kBZZ980 BDKXGXlv1KfhzvOE8LNibSsP/SSpcv6nIiEaeVcHE28jt3hKYvGogPOfBXCmXDqT3Pa5iZV6ox00u GEQEdu5l8wneIoXlP9FxK3yMAaenV8rfZZT2PyzgQk4rPDabTdzsGmRkbEgfyx4MkKFB3dNuTA/TC xKg4PGtQn2obK2nOt6RtgADNbI1xAQFzhAsHOsUbcArN7b/zWl0Wg5z9F73mXwoViZsrWeeNmYwu0 fWhSKrztLVudzCnlHcsOfVwFwUpPIytO3A7/ryPjZsMFyM/Kz7k27jA73pN7BKjag9FW79YOtbfa4 EtpduV3g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l04vm-007kuA-SO; Thu, 14 Jan 2021 15:53:22 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 0306D301324; Thu, 14 Jan 2021 16:53:01 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D5EDC20079488; Thu, 14 Jan 2021 16:53:01 +0100 (CET) Date: Thu, 14 Jan 2021 16:53:01 +0100 From: Peter Zijlstra To: Borislav Petkov Cc: Nick Desaulniers , Josh Poimboeuf , Mark Brown , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Fangrui Song , Arnd Bergmann , Jonathan Corbet , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Nathan Chancellor , Miguel Ojeda , Jiri Slaby , Joe Perches , Linux Doc Mailing List , LKML , clang-built-linux Subject: Re: [PATCH] x86/entry: Remove put_ret_addr_in_rdi THUNK macro argument Message-ID: References: <20210112115421.GB13086@zn.tnic> <20210112194625.4181814-1-ndesaulniers@google.com> <20210112210154.GI4646@sirena.org.uk> <20210113165923.acvycpcu5tzksbbi@treble> <20210114103928.GB12284@zn.tnic> <20210114132809.GC12284@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210114132809.GC12284@zn.tnic> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2021 at 02:28:09PM +0100, Borislav Petkov wrote: > On Thu, Jan 14, 2021 at 12:36:45PM +0100, Peter Zijlstra wrote: > > And while looking, I suppose we can delete the put_ret_addr_in_rdi crud, > > but that's another patch. > > --- > From: Borislav Petkov > Date: Thu, 14 Jan 2021 14:25:35 +0100 > Subject: [PATCH] x86/entry: Remove put_ret_addr_in_rdi THUNK macro argument > > That logic is unused since > > 320100a5ffe5 ("x86/entry: Remove the TRACE_IRQS cruft") > > Remove it. > > Suggested-by: Peter Zijlstra > Signed-off-by: Borislav Petkov Acked-by; Peter Zijlstra (Intel)