From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Caleb Connolly <caleb@connolly.tech>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] arm64: dts: sdm845: add oneplus6/6t devices
Date: Fri, 15 Jan 2021 08:16:35 -0600 [thread overview]
Message-ID: <YAGjw4Vz21IFk9yL@builder.lan> (raw)
In-Reply-To: <061f8c37-533f-b694-f9a8-393cb9a34e01@somainline.org>
On Fri 15 Jan 06:28 CST 2021, Konrad Dybcio wrote:
>
> Please move gpio-keys before reserved-memory to keep things sorted.
>
>
> > + vreg_l25a_3p3: ldo25 {
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3312000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > + };
> > + vdda_mipi_dsi0_1p2:
>
>
> Add a newline between the "};" and "vdda_mipi_dsi0_1p2:" to keep it consistent.
>
Done and merged.
>
> After that, you can add:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>
Thanks for the patch and the review!
Regards,
Bjorn
next prev parent reply other threads:[~2021-01-15 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 20:31 [PATCH v4] Add support for the OnePlus 6 and 6T Caleb Connolly
2021-01-14 20:31 ` [PATCH v4 1/2] arm64: dts: sdm845: add oneplus6/6t devices Caleb Connolly
2021-01-15 12:28 ` Konrad Dybcio
2021-01-15 14:16 ` Bjorn Andersson [this message]
2021-01-14 20:32 ` [PATCH v4 2/2] dt-bindings: Document bindings for new SDM845 devices Caleb Connolly
2021-01-25 22:18 ` Rob Herring
2021-02-26 21:03 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAGjw4Vz21IFk9yL@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=anton@enomsg.org \
--cc=caleb@connolly.tech \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.