All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime@cerno.tech>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible
Date: Mon, 18 Jan 2021 12:39:11 +0200	[thread overview]
Message-ID: <YAVlT1RKeymzDxoK@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAGb2v64o84POSVAHMeRkKrAtd7gPr6-4H133RfsjJAnfwQNSjw@mail.gmail.com>

Hi Chen-Yu,

On Mon, Jan 18, 2021 at 06:22:15PM +0800, Chen-Yu Tsai wrote:
> On Mon, Jan 18, 2021 at 6:03 PM Maxime Ripard <maxime@cerno.tech> wrote:
> > On Fri, Jan 15, 2021 at 09:16:30AM +0200, Laurent Pinchart wrote:
> > > On Thu, Jan 14, 2021 at 12:35:23PM +0100, Maxime Ripard wrote:
> > > > The corpro,gm7123 was in use in a DT but was never properly documented,
> > > > let's add it.
> > > >
> > > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > > ---
> > > >  .../devicetree/bindings/display/bridge/simple-bridge.yaml     | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > index 64e8a1c24b40..97ca07b56cbc 100644
> > > > --- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > +++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > @@ -22,6 +22,10 @@ properties:
> > > >                - ti,ths8134a
> > > >                - ti,ths8134b
> > > >            - const: ti,ths8134
> > > > +      - items:
> > > > +          - const: corpro,gm7123
> > > > +          - const: adi,adv7123
> > >
> > > Do we need adi,adv7123 ?
> >
> > I'm not sure: it looks like having both the adv7123 and the dumb-vga-dac
> > compatible was never an option, so we can also change the DT to have
> > corpro,gm7123, dumb-vga-dac
> 
> FYI I used the adi,adv7123 fallback because the gm7123 datasheet compares
> the two, with the gm7123 having lower standby current, but only limited to
> 3.3V power supply. Maximum resolution, conversion rate, and the range of
> output current are all the same. The package is the same as well. I
> believe the gm7123 is intended as a drop-in clone of the adv7123.

That's a good point. I don't mind either way.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: devicetree <devicetree@vger.kernel.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>, Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <maxime@cerno.tech>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible
Date: Mon, 18 Jan 2021 12:39:11 +0200	[thread overview]
Message-ID: <YAVlT1RKeymzDxoK@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAGb2v64o84POSVAHMeRkKrAtd7gPr6-4H133RfsjJAnfwQNSjw@mail.gmail.com>

Hi Chen-Yu,

On Mon, Jan 18, 2021 at 06:22:15PM +0800, Chen-Yu Tsai wrote:
> On Mon, Jan 18, 2021 at 6:03 PM Maxime Ripard <maxime@cerno.tech> wrote:
> > On Fri, Jan 15, 2021 at 09:16:30AM +0200, Laurent Pinchart wrote:
> > > On Thu, Jan 14, 2021 at 12:35:23PM +0100, Maxime Ripard wrote:
> > > > The corpro,gm7123 was in use in a DT but was never properly documented,
> > > > let's add it.
> > > >
> > > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > > ---
> > > >  .../devicetree/bindings/display/bridge/simple-bridge.yaml     | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > index 64e8a1c24b40..97ca07b56cbc 100644
> > > > --- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > +++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > @@ -22,6 +22,10 @@ properties:
> > > >                - ti,ths8134a
> > > >                - ti,ths8134b
> > > >            - const: ti,ths8134
> > > > +      - items:
> > > > +          - const: corpro,gm7123
> > > > +          - const: adi,adv7123
> > >
> > > Do we need adi,adv7123 ?
> >
> > I'm not sure: it looks like having both the adv7123 and the dumb-vga-dac
> > compatible was never an option, so we can also change the DT to have
> > corpro,gm7123, dumb-vga-dac
> 
> FYI I used the adi,adv7123 fallback because the gm7123 datasheet compares
> the two, with the gm7123 having lower standby current, but only limited to
> 3.3V power supply. Maximum resolution, conversion rate, and the range of
> output current are all the same. The package is the same as well. I
> believe the gm7123 is intended as a drop-in clone of the adv7123.

That's a good point. I don't mind either way.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-18 20:31 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 11:35 [PATCH 01/19] dt-bindings: sunxi: Fix the pinecube compatible Maxime Ripard
2021-01-14 11:35 ` Maxime Ripard
2021-01-14 11:35 ` [PATCH 02/19] dt-bindings: iio: adc: Add AXP803 compatible Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:10   ` Jernej Škrabec
2021-01-14 20:10     ` Jernej Škrabec
2021-01-17 12:41     ` Jonathan Cameron
2021-01-17 12:41       ` Jonathan Cameron
2021-01-14 11:35 ` [PATCH 03/19] dt-bindings: rtc: sun6i-a31-rtc: Loosen the requirements on the clocks Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:11   ` Jernej Škrabec
2021-01-14 20:11     ` Jernej Škrabec
2021-01-19 21:43   ` Alexandre Belloni
2021-01-19 21:43     ` Alexandre Belloni
2021-01-14 11:35 ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible Maxime Ripard
2021-01-14 11:35   ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible Maxime Ripard
2021-01-14 20:14   ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible Jernej Škrabec
2021-01-14 20:14     ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible Jernej Škrabec
2021-01-15  7:16   ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible Laurent Pinchart
2021-01-15  7:16     ` Laurent Pinchart
2021-01-18 10:03     ` Maxime Ripard
2021-01-18 10:03       ` Maxime Ripard
2021-01-18 10:22       ` Chen-Yu Tsai
2021-01-18 10:22         ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible Chen-Yu Tsai
2021-01-18 10:39         ` Laurent Pinchart [this message]
2021-01-18 10:39           ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible Laurent Pinchart
2021-01-18 10:38       ` Laurent Pinchart
2021-01-18 10:38         ` Laurent Pinchart
2021-01-25 21:21   ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible Rob Herring
2021-01-25 21:21     ` Rob Herring
2021-01-14 11:35 ` [PATCH 05/19] dt-bindings: bluetooth: realtek: Switch to unevaluatedProperties Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:14   ` Jernej Škrabec
2021-01-14 20:14     ` Jernej Škrabec
2021-01-14 22:54   ` Rob Herring
2021-01-14 22:54     ` Rob Herring
2021-01-15  1:37   ` Rob Herring
2021-01-15  1:37     ` Rob Herring
2021-01-18 10:15     ` Maxime Ripard
2021-01-18 10:15       ` Maxime Ripard
2021-01-22 14:40       ` Rob Herring
2021-01-22 14:40         ` Rob Herring
2021-01-14 11:35 ` [PATCH 06/19] ARM: dts: sunxi: Fix the LED node names Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:33   ` Jernej Škrabec
2021-01-14 20:33     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 07/19] ARM: dts: sunxi: Add missing backlight supply Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:25   ` Jernej Škrabec
2021-01-14 20:25     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 08/19] ARM: dts: sunxi: Fix CPU thermal zone node name Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:34   ` Jernej Škrabec
2021-01-14 20:34     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 09/19] ARM: dts: sunxi: Remove thermal zones without trip points Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:36   ` Jernej Škrabec
2021-01-14 20:36     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 10/19] ARM: dts: sun6i: primo81: Remove useless io-channel-cells Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:37   ` Jernej Škrabec
2021-01-14 20:37     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 11/19] ARM: dts: sun8i: nanopi-r1: Fix GPIO regulator state array Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:38   ` Jernej Škrabec
2021-01-14 20:38     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 12/19] ARM: dts: sun8i-s3: impetus: Fix the USB PHY ID detect GPIO properties Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:39   ` Jernej Škrabec
2021-01-14 20:39     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 13/19] ARM: dts: sun8i-s3: pinecube: Fix Display Engine DTC warnings Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:40   ` Jernej Škrabec
2021-01-14 20:40     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 14/19] ARM: dts: sun8i-a83t: Remove empty CSI port Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:40   ` Jernej Škrabec
2021-01-14 20:40     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 15/19] ARM: dts: sun8i-a33: sina33: Add missing panel power supply Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:41   ` Jernej Škrabec
2021-01-14 20:41     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 16/19] arm64: dts: allwinner: h6: Use - instead of @ for DT OPP entries Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:42   ` Jernej Škrabec
2021-01-14 20:42     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 17/19] arm64: dts: allwinner: pinephone: Remove useless light sensor supplies Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:44   ` Jernej Škrabec
2021-01-14 20:44     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 18/19] arm64: dts: allwinner: pinetab: Fix the panel compatible Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:46   ` Jernej Škrabec
2021-01-14 20:46     ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 19/19] arm64: dts: allwinner: pine-h64: Fix typos in BT GPIOs Maxime Ripard
2021-01-14 11:35   ` Maxime Ripard
2021-01-14 20:49   ` Jernej Škrabec
2021-01-14 20:49     ` Jernej Škrabec
2021-01-14 20:07 ` [PATCH 01/19] dt-bindings: sunxi: Fix the pinecube compatible Jernej Škrabec
2021-01-14 20:07   ` Jernej Škrabec
2021-01-15  2:41 ` Chen-Yu Tsai
2021-01-15  2:41   ` Chen-Yu Tsai
2021-01-15  9:31   ` Maxime Ripard
2021-01-15  9:31     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAVlT1RKeymzDxoK@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=jernej.skrabec@siol.net \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.