From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] xfs: create convenience wrappers for incore quota block reservations
Date: Tue, 19 Jan 2021 07:44:03 +0100 [thread overview]
Message-ID: <YAZ/s1a0c7drWZv3@infradead.org> (raw)
In-Reply-To: <161100791039.88678.6897577495997060048.stgit@magnolia>
> - error = xfs_trans_reserve_quota_nblks(NULL, ip, (long)alen, 0,
> - XFS_QMOPT_RES_REGBLKS);
> + error = xfs_quota_reserve_blkres(ip, alen, XFS_QMOPT_RES_REGBLKS);
This is the only callsite outside of xfs_quota_unreserve_blkres,
so I'm not sure how useful the wrapper is. Also even on the unreserved
side we always pass XFS_QMOPT_RES_REGBLKS except for one case that
conditionally passes XFS_QMOPT_RES_RTBLKS. So if we think these helpers
are useful enough I'd at least just pass a bool is_rt argument and hide
the flags entirely.
next prev parent reply other threads:[~2021-01-19 6:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 22:11 [PATCHSET 0/4] xfs: minor cleanups of the quota functions Darrick J. Wong
2021-01-18 22:11 ` [PATCH 1/4] xfs: clean up quota reservation callsites Darrick J. Wong
2021-01-19 6:35 ` Christoph Hellwig
2021-01-18 22:11 ` [PATCH 2/4] xfs: clean up quota reservation wrappers Darrick J. Wong
2021-01-19 6:38 ` Christoph Hellwig
2021-01-18 22:11 ` [PATCH 3/4] xfs: create convenience wrappers for incore quota block reservations Darrick J. Wong
2021-01-19 6:44 ` Christoph Hellwig [this message]
2021-01-19 19:47 ` Darrick J. Wong
2021-01-19 20:26 ` Darrick J. Wong
2021-01-20 4:33 ` [PATCH v2.1 " Darrick J. Wong
2021-01-18 22:11 ` [PATCH 4/4] xfs: clean up icreate quota reservation calls Darrick J. Wong
2021-01-19 6:46 ` Christoph Hellwig
2021-01-23 18:51 [PATCHSET v2 0/4] xfs: minor cleanups of the quota functions Darrick J. Wong
2021-01-23 18:51 ` [PATCH 3/4] xfs: create convenience wrappers for incore quota block reservations Darrick J. Wong
2021-01-24 9:33 ` Christoph Hellwig
2021-01-25 15:15 ` Brian Foster
2021-01-26 20:37 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAZ/s1a0c7drWZv3@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.