From: Jeff King <peff@peff.net>
To: Jacob Vosmaer <jacob@gitlab.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] builtin/pack-objects.c: avoid iterating all refs
Date: Tue, 19 Jan 2021 18:15:11 -0500 [thread overview]
Message-ID: <YAdn/zdQP1Hz70ba@coredump.intra.peff.net> (raw)
In-Reply-To: <20210119143348.27535-2-jacob@gitlab.com>
On Tue, Jan 19, 2021 at 03:33:48PM +0100, Jacob Vosmaer wrote:
> In git-pack-objects, we iterate over all the tags if the --include-tag
> option is passed on the command line. For some reason this uses
> for_each_ref which is expensive if the repo has many refs. We should
> use a prefix iterator instead.
> [...]
> - for_each_ref(add_ref_tag, NULL);
> + for_each_fullref_in("refs/tags/", add_ref_tag, NULL, 0);
Yeah, this is trivially correct, since the first thing we check in
add_ref_tag() is whether it starts with refs/tags/. It would be safe to
remove that check as part of this patch (and unlike the multi-prefix
one, I am comfortable assuming that for_each_fullref_in() will not
return anything outside of the prefix).
I also wondered if we could just use for_each_ref_in() here, but I think
we are better having the full refname to feed to peel_ref().
-Peff
next prev parent reply other threads:[~2021-01-19 23:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 14:33 [PATCH 0/1] builtin/pack-objects.c: avoid iterating all refs Jacob Vosmaer
2021-01-19 14:33 ` [PATCH 1/1] " Jacob Vosmaer
2021-01-19 23:08 ` Taylor Blau
2021-01-19 23:33 ` Jeff King
2021-01-19 23:54 ` Taylor Blau
2021-01-19 23:15 ` Jeff King [this message]
2021-01-20 8:50 ` Ævar Arnfjörð Bjarmason
2021-01-20 15:02 ` Taylor Blau
2021-01-20 16:32 ` Ævar Arnfjörð Bjarmason
2021-01-20 19:53 ` Jeff King
2021-01-21 10:26 ` Ævar Arnfjörð Bjarmason
2021-01-21 15:34 ` Jeff King
2021-01-19 23:26 ` [PATCH 0/1] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAdn/zdQP1Hz70ba@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jacob@gitlab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.