From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6DEC433E6 for ; Wed, 20 Jan 2021 08:03:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D88542332B for ; Wed, 20 Jan 2021 08:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730277AbhATIC6 (ORCPT ); Wed, 20 Jan 2021 03:02:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:49744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728945AbhATIAF (ORCPT ); Wed, 20 Jan 2021 03:00:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 410A02313A; Wed, 20 Jan 2021 07:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611129564; bh=eEJWyrqrVaGjriITxtdpVRQGIOFRYlpNHJ5gIDAfIrY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UPaJXNx8iVS6G5hOuKTZJO8/9ChIfvSA1m/LI16GUcZBjcH7UTcwg41c65eerfPeH Mr+gMTM711E9NGLLV6BR3IkvnKBYXf43CU8WWZYe2wp6n8es73Nf8GBwzdsXOTW1VF eHoqCMFk3Y2sXjmU7vtyIquJY2QEI5c5Lvla5q+Q= Date: Wed, 20 Jan 2021 08:59:20 +0100 From: Greg Kroah-Hartman To: Scott Branden Cc: Olof Johansson , Arnd Bergmann , Desmond Yan , Kees Cook , Linux Kernel Mailing List , Broadcom Kernel Feedback List Subject: Re: [PATCH v8 00/13] Add Broadcom VK driver Message-ID: References: <20201130184200.5095-1-scott.branden@broadcom.com> <09b6e829-75b8-4f16-3e01-c7193640d9c6@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09b6e829-75b8-4f16-3e01-c7193640d9c6@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2021 at 12:21:32PM -0800, Scott Branden wrote: > Hi Greg, > > On 2021-01-18 3:06 p.m., Olof Johansson wrote: > > On Sun, Jan 17, 2021 at 11:17 PM Greg Kroah-Hartman > > wrote: > >> On Sun, Jan 17, 2021 at 10:47:59AM -0800, Olof Johansson wrote: > >>> Hi, > >>> > >>> On Mon, Nov 30, 2020 at 10:42 AM Scott Branden > >>> wrote: > >>>> This patch series drops previous patches in [1] > >>>> that were incorporated by Kees Cook into patch series > >>>> "Introduce partial kernel_read_file() support" [2]. > >>>> > >>>> Remaining patches are contained in this series to add Broadcom VK driver. > >>>> (which depends on request_firmware_into_buf API addition which has > >>>> now been accepted into the upstream kernel as of v5.10-rc1). > >>>> > >>>> [1] https://lore.kernel.org/lkml/20200706232309.12010-1-scott.branden@broadcom.com/ > >>>> [2] https://lore.kernel.org/lkml/20201002173828.2099543-1-keescook@chromium.org/ > >>> > >>> I've been following this series for some time, and I think the code is > >>> ready to go in. > >>> > >>> Greg, mind queuing this up in the misc tree? > >> I will need a new version, this is long gone from my queue. > > I'll let Scott repost then (with acks applied etc) > I can send another patch version with Olof's acks applied to each patch. > Please let me know if that is what you are looking for? Yes please. > >> And hopefully the tty layer abuse is gone... :) > > There's a simple tty driver as the final patch in the series, but it's > > pretty straightforward. > > > > If you've still got concerns with it, the rest of the series should > > stand on its own and should be mergeable without that piece. > Yes, I placed the patch at the end of the series so it can be dropped > if that is what is required to accept the rest of the patches. > > There has been no viable solution suggested for replacing this functionality. > We need a tty-like interface that works via access to the circular buffers > in PCIe BAR space and interrupts. > > The vk tty devices are a direct replacement to attaching serial cables. > In real production environment it is not possible to attach such cables. > > I can work on an alternative tty solution and send such patch later > but I don't know what is going to prevent the tty "abuse". I can't remember the specifics (I review hundreds of patches a week), but please just resend and I'll deal with it then :) thanks, greg k-h