All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Holidays and LTP release
Date: Wed, 20 Jan 2021 14:33:14 +0100	[thread overview]
Message-ID: <YAgxGvg/FXcUq8R6@yuki.lan> (raw)
In-Reply-To: <YAgFQnIazPBpkWwL@yuki.lan>

Hi!
> > do you mean something like this ?
> > But this change did not solve the problem (ioctl_sg01) i have reported.
> > 
> > diff --git a/lib/tst_memutils.c b/lib/tst_memutils.c
> > index f134d90c9..00bf45e9c 100644
> > --- a/lib/tst_memutils.c
> > +++ b/lib/tst_memutils.c
> > @@ -20,7 +20,7 @@ void tst_pollute_memory(size_t maxsize, int fillchar)
> >         struct sysinfo info;
> > 
> >         SAFE_SYSINFO(&info);
> > -       safety = 4096 * SAFE_SYSCONF(_SC_PAGESIZE) / info.mem_unit;
> > +       safety = 8192 * SAFE_SYSCONF(_SC_PAGESIZE) / info.mem_unit;
> 
> Actually Martin sugessted a different patch that chooses the margin to
> be the greater of 4096 pages or 64MB, which would effectivelly set the
> safety to "16384 * SAFE_SYSCONF(_SC_PAGESIZE) / info.mem_unit" on most
> systems.
> 
> Also I've been playing with a VM and I've been able to reproduce
> occasional failures with swap turned off and memory_overcommit set to 1
> that Martin's patch fixed for me.

And it looks like the patch for tst_memutils.c is the last one that
should be taken care of before the release.

It would be nice if you could check if that fixes your failures as well.

However it made the situation better, at least for me, so I will push it
tomorrow morning and proceed with the release.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2021-01-20 13:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 12:18 [LTP] Holidays and LTP release Cyril Hrubis
2021-01-06 12:19 ` Cyril Hrubis
2021-01-07 11:51   ` Cyril Hrubis
2021-01-08  1:23     ` Yang Xu
2021-01-08 13:28       ` Cyril Hrubis
2021-01-11 14:38     ` Cyril Hrubis
2021-01-12 10:29       ` Petr Vorel
2021-01-13  8:57   ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
2021-01-14 11:12     ` Naresh Kamboju
2021-01-14 14:14       ` Martin Doucha
2021-01-20  9:31         ` Naresh Kamboju
2021-01-20 10:26           ` Cyril Hrubis
2021-01-20 13:33             ` Cyril Hrubis [this message]
2021-01-14 14:36       ` Cyril Hrubis
2021-01-15  8:27         ` Naresh Kamboju
2021-01-15 14:00           ` Cyril Hrubis
2021-01-15 14:27             ` Cyril Hrubis
2021-01-14  9:17   ` Martin Doucha
2021-01-14 10:41     ` Cyril Hrubis
2021-01-14 15:01 gengcixi
2021-01-15 15:08 gengcixi
2021-01-19 10:43 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAgxGvg/FXcUq8R6@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.