From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Al Cooper <alcooperx@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
devicetree <devicetree@vger.kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver
Date: Wed, 20 Jan 2021 18:15:08 +0100 [thread overview]
Message-ID: <YAhlHL67rDmWSWdr@kroah.com> (raw)
In-Reply-To: <CAHp75Vf-ZmPuOjRYwNbURJXP3g_-m1LUDbsWtKHMvP49jseprw@mail.gmail.com>
On Wed, Jan 20, 2021 at 07:09:46PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 20, 2021 at 7:05 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Wed, Jan 20, 2021 at 06:47:52PM +0200, Andy Shevchenko wrote:
> > > On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> > > > On 1/19/2021 7:21 AM, Andy Shevchenko wrote:
> > > > > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper <alcooperx@gmail.com> wrote:
>
> ...
>
> > > > Not sure this makes sense, given that the DMA hardware that was added to
> > > > this UART block is only used by the UART block and no other pieces of HW
> > > > in the system, nor will they ever be. Not sure it makes sense to pay the
> > > > cost of an extra indirection and subsystem unless there are at least two
> > > > consumers of that DMA hardware to warrant modeling it after a dmaengine
> > > > driver. I also remember that Al researched before whether 8250_dma.c
> > > > could work, and came to the conclusion that it would not, but I will let
> > > > him comment on the specifics.
> > >
> > > I see. In any case I still believe that the driver can be shrinked by
> > > a notable amount of lines.
> >
> > Patches always gladly accepted :)
>
> Or a good review... :-)
Please do so!
next prev parent reply other threads:[~2021-01-20 17:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 21:15 [PATCH v2 0/2] serial: 8250: Add driver for Broadcom UART Al Cooper
2021-01-15 21:15 ` [PATCH v2 1/2] dt-bindings: Add support for the Broadcom UART driver Al Cooper
2021-01-17 15:45 ` Rob Herring
2021-01-15 21:15 ` [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver Al Cooper
2021-01-18 17:45 ` Greg Kroah-Hartman
2021-01-18 20:32 ` Al Cooper
2021-01-19 12:33 ` Greg Kroah-Hartman
2021-01-19 15:21 ` Andy Shevchenko
2021-01-19 18:16 ` Florian Fainelli
2021-01-20 16:47 ` Andy Shevchenko
2021-01-20 17:05 ` Greg Kroah-Hartman
2021-01-20 17:09 ` Andy Shevchenko
2021-01-20 17:15 ` Greg Kroah-Hartman [this message]
2021-01-20 17:30 ` Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAhlHL67rDmWSWdr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.