From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D135FC433E0 for ; Wed, 20 Jan 2021 20:00:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76BE223440 for ; Wed, 20 Jan 2021 20:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388438AbhATUAD (ORCPT ); Wed, 20 Jan 2021 15:00:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728314AbhATT7M (ORCPT ); Wed, 20 Jan 2021 14:59:12 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBB05C0613CF for ; Wed, 20 Jan 2021 11:58:25 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id g15so2894343pjd.2 for ; Wed, 20 Jan 2021 11:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oJo4M6632K9snaVFDSf1XhUlP1UsmMayuk5fe53umD4=; b=G36BNaYtJB6cOJoO+cpkrFo5Rz9jEBz7sRhWIAY/mH8XN+L1MplSuDdMu05dGss2+a FWnFgtSL2g9zo8K2f0ne0cvRGXQXJ5zNq437oiHkqdLkiXzN2VbNYR+2tER3XvQk+ji1 G7PoqF8r6rJniXOnWROmGVzbbgW6CBWPg9Zyg39tcc52LpcCmYsYhSNhrlnqJheOnZgK SZueUzaRCQeFBcKVKXWTjrHNqcbsYv5mJr1lH7nI5IUoDLvyloOSVtDgrmqLp1vHgwwK lIjv7zT4Jl+/gktHmyPUi6+y/tb+WgX6zJH2p5iqyNAG4fqQnVyQGXVPBhzMTZm9c2FE mzBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oJo4M6632K9snaVFDSf1XhUlP1UsmMayuk5fe53umD4=; b=En+wFfME0hvQEeu8eGw6f7kwEfZniMVerGoW/JdMWST0+O5h4YVmt2G7TLFIN28igI f8eH4AxRdC51zmbE1RESLWxk8XChZeVzeZyYraN4afgOmGYjsKp+bI3ymja3q4ifbBO5 K6tVM49LgHca9lewt86ysgJPlXgciHuZ3wL6bJMa8XlmbobBBCIixjTLmJZCb0tZzXF+ 2y9X3GHWz/A+9iDxD7MAlX7P0ESplCJpKVbsKlLAHMo1jwJhVUd5sXL+OUloF3YDRV+R xNUKRiuZg2wA7t4UKbVj42OfeurOfoQZ0p6WMnNEdxz/+GQFMJzt5/E7t3soCxTPTeRB vqoQ== X-Gm-Message-State: AOAM530T3LbofHkSqFuQW0wRihADSfkGGHMFXrMDbbHvwo9ErFyR9qux pYlSkE2fl+D8RScqXk09AaKzUw== X-Google-Smtp-Source: ABdhPJwCwKNfimf1xsCwD1k7DYvvlx0rSdT1gRA6HWHsXoJ1WS7/+jmqt8GZoVPe6rGidhNonVQPBg== X-Received: by 2002:a17:90a:f692:: with SMTP id cl18mr1789209pjb.124.1611172705222; Wed, 20 Jan 2021 11:58:25 -0800 (PST) Received: from google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) by smtp.gmail.com with ESMTPSA id w7sm3087741pfb.62.2021.01.20.11.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 11:58:24 -0800 (PST) Date: Wed, 20 Jan 2021 11:58:17 -0800 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong Subject: Re: [PATCH 08/24] kvm: x86/mmu: Add lockdep when setting a TDP MMU SPTE Message-ID: References: <20210112181041.356734-1-bgardon@google.com> <20210112181041.356734-9-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112181041.356734-9-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021, Ben Gardon wrote: > Add lockdep to __tdp_mmu_set_spte to ensure that SPTEs are only modified > under the MMU lock. This lockdep will be updated in future commits to > reflect and validate changes to the TDP MMU's synchronization strategy. I'd omit the "updated in future commits" justification. IMO this is a good change even if we never build on it, and the extra justification would be confusing if this is merged separately from the parallelization patches. > No functional change intended. > > Reviewed-by: Peter Feiner > > Signed-off-by: Ben Gardon Reviewed-by: Sean Christopherson