All of
 help / color / mirror / Atom feed
From: Bjorn Andersson <>
To: Linus Walleij <>
Cc: Andy Gross <>, Rob Herring <>,
	MSM <>,
	"open list:GPIO SUBSYSTEM" <>,
	"" <>
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding
Date: Thu, 21 Jan 2021 11:18:18 -0600	[thread overview]
Message-ID: <YAm3Wjpfg2yIE9Wt@builder.lan> (raw)
In-Reply-To: <>

On Thu 21 Jan 07:20 CST 2021, Linus Walleij wrote:

> On Wed, Jan 20, 2021 at 11:21 PM Bjorn Andersson
> <> wrote:
> > Several properties are shared between all TLMM bindings. By providing a
> > common binding to define these properties each platform's binding can be
> > reduced to just listing which of these properties should be checked for
> > - or further specified.
> >
> > Signed-off-by: Bjorn Andersson <>
> Overall it looks good, just cutting some slack for reviewers (especially
> DT people) before applying.
> > +description:
> > +  This defines the common properties used to describe all Qualcomm TLMM
> > +  bindings and pinconf/pinmux states for these.
> I vaguely recall asking you in the past what the acronym TLMM actually
> means. This would be a good place to expand the acronym so people
> know what these four letters actually represent.

As Vinod said, it's used in a few places and I agree that we should
spell it out here.

In particular I had to include "phandle" in the list of valid properties
for for the dtbs_check to pass when there are references to state nodes,
so I would like to hear from Rob about that.

Will respin this after getting his input - hopefully with his Ack ;)

> (There, I finally gave you an official reason to go and poke Qualcomm
> hardware engineers about this. ;)



  parent reply	other threads:[~2021-01-21 17:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 22:21 [PATCH 0/3] pinctrl: qcom: TLMM driver for SC8180x Bjorn Andersson
2021-01-20 22:21 ` [PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding Bjorn Andersson
2021-01-21 13:20   ` Linus Walleij
2021-01-21 17:06     ` Vinod Koul
2021-01-21 17:18     ` Bjorn Andersson [this message]
2021-01-20 22:21 ` [PATCH 2/3] dt-bindings: pinctrl: qcom: Add sc8180x binding Bjorn Andersson
2021-01-20 22:21 ` [PATCH 3/3] pinctrl: qcom: Add sc8180x TLMM driver Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAm3Wjpfg2yIE9Wt@builder.lan \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.