From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DBF6C433DB for ; Fri, 22 Jan 2021 12:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6CD723A3A for ; Fri, 22 Jan 2021 12:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727256AbhAVMT2 (ORCPT ); Fri, 22 Jan 2021 07:19:28 -0500 Received: from mga02.intel.com ([134.134.136.20]:44424 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728007AbhAVMJO (ORCPT ); Fri, 22 Jan 2021 07:09:14 -0500 IronPort-SDR: J1cRqzL8Yg5NuWT2ihPY3JWXzdJplrWkxKvBhuijh5kFyqnDpncI3xiaJsiw7PYDYQH4L1Qhb2 GOOikGKB8L8A== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="166537736" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="166537736" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 04:07:28 -0800 IronPort-SDR: LI7d1B/P80MeyJkVkKXKN7OEzVq/WmfB9ZPT+CyMbHq5Dbr0B1vmeqlILwhcjOQ2ieQXgKqBA2 BA4zdrJP78EQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="427949436" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga001.jf.intel.com with SMTP; 22 Jan 2021 04:07:22 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 22 Jan 2021 14:07:22 +0200 Date: Fri, 22 Jan 2021 14:07:22 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Sean Paul , freedreno@lists.freedesktop.org, Tomi Valkeinen , Sascha Hauer , Jyri Sarha , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-msm@vger.kernel.org, Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-6-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210121163537.1466118-6-maxime@cerno.tech> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Jan 21, 2021 at 05:35:31PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_check hook, which would be the old > plane state in the global atomic state since _swap_state hasn't happened > when atomic_check is run. > > Use the drm_atomic_get_old_plane_state helper to get that state to make > it more obvious. > > This was made using the coccinelle script below: > > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > > static struct drm_plane_helper_funcs helpers = { > ..., > .atomic_check = func, > ..., > }; > > @ replaces_old_state @ > identifier plane_atomic_func.func; > identifier plane, state, plane_state; > @@ > > func(struct drm_plane *plane, struct drm_atomic_state *state) { > ... > - struct drm_plane_state *plane_state = plane->state; > + struct drm_plane_state *plane_state = drm_atomic_get_old_plane_state(state, plane); > ... > } > > @@ > identifier plane_atomic_func.func; > identifier plane, state, plane_state; > @@ > > func(struct drm_plane *plane, struct drm_atomic_state *state) { > struct drm_plane_state *plane_state = drm_atomic_get_old_plane_state(state, plane); > ... > - plane->state > + plane_state > ... We don't need the <... ...> style here? It's been a while since I did any serious cocci so I'm getting a bit rusty on the details... Otherwise looks great Reviewed-by: Ville Syrjälä > } > > @ adds_old_state @ > identifier plane_atomic_func.func; > identifier plane, state; > @@ > > func(struct drm_plane *plane, struct drm_atomic_state *state) { > + struct drm_plane_state *old_plane_state = drm_atomic_get_old_plane_state(state, plane); > ... > - plane->state > + old_plane_state > ... > } > > @ include depends on adds_old_state || replaces_old_state @ > @@ > > #include > > @ no_include depends on !include && (adds_old_state || replaces_old_state) @ > @@ > > + #include > #include > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/imx/ipuv3-plane.c | 3 ++- > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 +++- > drivers/gpu/drm/tilcdc/tilcdc_plane.c | 3 ++- > 3 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c > index b5f6123850bb..6484592e3f86 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -341,7 +341,8 @@ static int ipu_plane_atomic_check(struct drm_plane *plane, > { > struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, > plane); > - struct drm_plane_state *old_state = plane->state; > + struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state, > + plane); > struct drm_crtc_state *crtc_state; > struct device *dev = plane->dev->dev; > struct drm_framebuffer *fb = new_state->fb; > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > index 4aac6217a5ad..6ce6ce09fecc 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > @@ -406,12 +406,14 @@ static int mdp5_plane_atomic_check_with_state(struct drm_crtc_state *crtc_state, > static int mdp5_plane_atomic_check(struct drm_plane *plane, > struct drm_atomic_state *state) > { > + struct drm_plane_state *old_plane_state = drm_atomic_get_old_plane_state(state, > + plane); > struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, > plane); > struct drm_crtc *crtc; > struct drm_crtc_state *crtc_state; > > - crtc = new_plane_state->crtc ? new_plane_state->crtc : plane->state->crtc; > + crtc = new_plane_state->crtc ? new_plane_state->crtc : old_plane_state->crtc; > if (!crtc) > return 0; > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_plane.c b/drivers/gpu/drm/tilcdc/tilcdc_plane.c > index ebdd42dcaf82..c86258132432 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_plane.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_plane.c > @@ -26,7 +26,8 @@ static int tilcdc_plane_atomic_check(struct drm_plane *plane, > struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, > plane); > struct drm_crtc_state *crtc_state; > - struct drm_plane_state *old_state = plane->state; > + struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state, > + plane); > unsigned int pitch; > > if (!new_state->crtc) > -- > 2.29.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A148EC433DB for ; Fri, 22 Jan 2021 12:09:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58AEA23437 for ; Fri, 22 Jan 2021 12:09:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58AEA23437 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WSdu5u+2Oz2CXvG/MrulsPo1Efrf//gJCgay0cqctu8=; b=qCaBdZwUp987U9bRBgbQThreb jprSORr7SX4wFtSmgzflMu3BBQlGuoc/Z2VyMiZWMEV9PCgcHoLMY69XOUbGMFkpwh4CYpcN5LH3e v5I30Jp462wLxV2ozokds6bwmRXKhNCHYbFIB090cwk5jTF7fR50yXbnk83m5ZM17goXYDoS2Px/4 qZN9spXjgo87xWyLnbSkbVKqo+xjQgaG2DG1mKkBT8eaGbTmC5vtV7Tc3aPhrA60r66mAFzfOivq3 jtwiH6H6dS/bvWZgKJzT82jA7oR/V9CV1Cr1Jkd7WjzObLcdlWpZCpcEVLq1EOpkg/J8ttjzpUogH J8fec+zJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2vE4-0006Xk-RS; Fri, 22 Jan 2021 12:07:40 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2vDv-0006TK-MN for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 12:07:38 +0000 IronPort-SDR: l0hr89jXkqXcrImWxqRDXdqTlk2zb5mq2dIzr9Xwnzp9LWprLhiAFMBzjEXje6N+/bDnUWLTrr 6VOSrL0VU1VQ== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="198190656" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="198190656" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 04:07:28 -0800 IronPort-SDR: LI7d1B/P80MeyJkVkKXKN7OEzVq/WmfB9ZPT+CyMbHq5Dbr0B1vmeqlILwhcjOQ2ieQXgKqBA2 BA4zdrJP78EQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="427949436" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga001.jf.intel.com with SMTP; 22 Jan 2021 04:07:22 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 22 Jan 2021 14:07:22 +0200 Date: Fri, 22 Jan 2021 14:07:22 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-6-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163537.1466118-6-maxime@cerno.tech> X-Patchwork-Hint: comment X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_070731_913726_F66AA2EF X-CRM114-Status: GOOD ( 25.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pengutronix Kernel Team , Tomi Valkeinen , David Airlie , freedreno@lists.freedesktop.org, Sascha Hauer , Maarten Lankhorst , Jyri Sarha , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, NXP Linux Team , Thomas Zimmermann , linux-arm-msm@vger.kernel.org, Daniel Vetter , Sean Paul , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 05:35:31PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_check hook, which would be the old > plane state in the global atomic state since _swap_state hasn't happened > when atomic_check is run. > = > Use the drm_atomic_get_old_plane_state helper to get that state to make > it more obvious. > = > This was made using the coccinelle script below: > = > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > = > static struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_check =3D func, > ..., > }; > = > @ replaces_old_state @ > identifier plane_atomic_func.func; > identifier plane, state, plane_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) { > ... > - struct drm_plane_state *plane_state =3D plane->state; > + struct drm_plane_state *plane_state =3D drm_atomic_get_old_plane_state(= state, plane); > ... > } > = > @@ > identifier plane_atomic_func.func; > identifier plane, state, plane_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) { > struct drm_plane_state *plane_state =3D drm_atomic_get_old_plane_state(= state, plane); > ... > - plane->state > + plane_state > ... We don't need the <... ...> style here? It's been a while since I did any serious cocci so I'm getting a bit rusty on the details... Otherwise looks great Reviewed-by: Ville Syrj=E4l=E4 > } > = > @ adds_old_state @ > identifier plane_atomic_func.func; > identifier plane, state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) { > + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_st= ate(state, plane); > ... > - plane->state > + old_plane_state > ... > } > = > @ include depends on adds_old_state || replaces_old_state @ > @@ > = > #include > = > @ no_include depends on !include && (adds_old_state || replaces_old_state= ) @ > @@ > = > + #include > #include > = > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/imx/ipuv3-plane.c | 3 ++- > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 +++- > drivers/gpu/drm/tilcdc/tilcdc_plane.c | 3 ++- > 3 files changed, 7 insertions(+), 3 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv= 3-plane.c > index b5f6123850bb..6484592e3f86 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -341,7 +341,8 @@ static int ipu_plane_atomic_check(struct drm_plane *p= lane, > { > struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, > plane); > - struct drm_plane_state *old_state =3D plane->state; > + struct drm_plane_state *old_state =3D drm_atomic_get_old_plane_state(st= ate, > + plane); > struct drm_crtc_state *crtc_state; > struct device *dev =3D plane->dev->dev; > struct drm_framebuffer *fb =3D new_state->fb; > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm= /msm/disp/mdp5/mdp5_plane.c > index 4aac6217a5ad..6ce6ce09fecc 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > @@ -406,12 +406,14 @@ static int mdp5_plane_atomic_check_with_state(struc= t drm_crtc_state *crtc_state, > static int mdp5_plane_atomic_check(struct drm_plane *plane, > struct drm_atomic_state *state) > { > + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_st= ate(state, > + plane); > struct drm_plane_state *new_plane_state =3D drm_atomic_get_new_plane_st= ate(state, > plane); > struct drm_crtc *crtc; > struct drm_crtc_state *crtc_state; > = > - crtc =3D new_plane_state->crtc ? new_plane_state->crtc : plane->state->= crtc; > + crtc =3D new_plane_state->crtc ? new_plane_state->crtc : old_plane_stat= e->crtc; > if (!crtc) > return 0; > = > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_plane.c b/drivers/gpu/drm/tilc= dc/tilcdc_plane.c > index ebdd42dcaf82..c86258132432 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_plane.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_plane.c > @@ -26,7 +26,8 @@ static int tilcdc_plane_atomic_check(struct drm_plane *= plane, > struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, > plane); > struct drm_crtc_state *crtc_state; > - struct drm_plane_state *old_state =3D plane->state; > + struct drm_plane_state *old_state =3D drm_atomic_get_old_plane_state(st= ate, > + plane); > unsigned int pitch; > = > if (!new_state->crtc) > -- = > 2.29.2 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0511C433E0 for ; Fri, 22 Jan 2021 12:07:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73C5523437 for ; Fri, 22 Jan 2021 12:07:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73C5523437 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC2186E965; Fri, 22 Jan 2021 12:07:31 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 161D66E965; Fri, 22 Jan 2021 12:07:30 +0000 (UTC) IronPort-SDR: zE1sXM3dTW4VcOVQpfulhGQ53fPayYeO9Inkhz6XWIg0cmrcx7vLazhnZMuUVtwi4wUtrODIg/ 6AoLp3RN74Lw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="243514008" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="243514008" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 04:07:28 -0800 IronPort-SDR: LI7d1B/P80MeyJkVkKXKN7OEzVq/WmfB9ZPT+CyMbHq5Dbr0B1vmeqlILwhcjOQ2ieQXgKqBA2 BA4zdrJP78EQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="427949436" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga001.jf.intel.com with SMTP; 22 Jan 2021 04:07:22 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 22 Jan 2021 14:07:22 +0200 Date: Fri, 22 Jan 2021 14:07:22 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-6-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163537.1466118-6-maxime@cerno.tech> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pengutronix Kernel Team , Tomi Valkeinen , David Airlie , freedreno@lists.freedesktop.org, Sascha Hauer , Jyri Sarha , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, NXP Linux Team , Thomas Zimmermann , linux-arm-msm@vger.kernel.org, Daniel Vetter , Sean Paul , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 21, 2021 at 05:35:31PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_check hook, which would be the old > plane state in the global atomic state since _swap_state hasn't happened > when atomic_check is run. > = > Use the drm_atomic_get_old_plane_state helper to get that state to make > it more obvious. > = > This was made using the coccinelle script below: > = > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > = > static struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_check =3D func, > ..., > }; > = > @ replaces_old_state @ > identifier plane_atomic_func.func; > identifier plane, state, plane_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) { > ... > - struct drm_plane_state *plane_state =3D plane->state; > + struct drm_plane_state *plane_state =3D drm_atomic_get_old_plane_state(= state, plane); > ... > } > = > @@ > identifier plane_atomic_func.func; > identifier plane, state, plane_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) { > struct drm_plane_state *plane_state =3D drm_atomic_get_old_plane_state(= state, plane); > ... > - plane->state > + plane_state > ... We don't need the <... ...> style here? It's been a while since I did any serious cocci so I'm getting a bit rusty on the details... Otherwise looks great Reviewed-by: Ville Syrj=E4l=E4 > } > = > @ adds_old_state @ > identifier plane_atomic_func.func; > identifier plane, state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) { > + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_st= ate(state, plane); > ... > - plane->state > + old_plane_state > ... > } > = > @ include depends on adds_old_state || replaces_old_state @ > @@ > = > #include > = > @ no_include depends on !include && (adds_old_state || replaces_old_state= ) @ > @@ > = > + #include > #include > = > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/imx/ipuv3-plane.c | 3 ++- > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 +++- > drivers/gpu/drm/tilcdc/tilcdc_plane.c | 3 ++- > 3 files changed, 7 insertions(+), 3 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv= 3-plane.c > index b5f6123850bb..6484592e3f86 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -341,7 +341,8 @@ static int ipu_plane_atomic_check(struct drm_plane *p= lane, > { > struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, > plane); > - struct drm_plane_state *old_state =3D plane->state; > + struct drm_plane_state *old_state =3D drm_atomic_get_old_plane_state(st= ate, > + plane); > struct drm_crtc_state *crtc_state; > struct device *dev =3D plane->dev->dev; > struct drm_framebuffer *fb =3D new_state->fb; > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm= /msm/disp/mdp5/mdp5_plane.c > index 4aac6217a5ad..6ce6ce09fecc 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > @@ -406,12 +406,14 @@ static int mdp5_plane_atomic_check_with_state(struc= t drm_crtc_state *crtc_state, > static int mdp5_plane_atomic_check(struct drm_plane *plane, > struct drm_atomic_state *state) > { > + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_st= ate(state, > + plane); > struct drm_plane_state *new_plane_state =3D drm_atomic_get_new_plane_st= ate(state, > plane); > struct drm_crtc *crtc; > struct drm_crtc_state *crtc_state; > = > - crtc =3D new_plane_state->crtc ? new_plane_state->crtc : plane->state->= crtc; > + crtc =3D new_plane_state->crtc ? new_plane_state->crtc : old_plane_stat= e->crtc; > if (!crtc) > return 0; > = > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_plane.c b/drivers/gpu/drm/tilc= dc/tilcdc_plane.c > index ebdd42dcaf82..c86258132432 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_plane.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_plane.c > @@ -26,7 +26,8 @@ static int tilcdc_plane_atomic_check(struct drm_plane *= plane, > struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, > plane); > struct drm_crtc_state *crtc_state; > - struct drm_plane_state *old_state =3D plane->state; > + struct drm_plane_state *old_state =3D drm_atomic_get_old_plane_state(st= ate, > + plane); > unsigned int pitch; > = > if (!new_state->crtc) > -- = > 2.29.2 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel