From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E4CC433E0 for ; Fri, 22 Jan 2021 07:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E28FE238D7 for ; Fri, 22 Jan 2021 07:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726920AbhAVHrw (ORCPT ); Fri, 22 Jan 2021 02:47:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbhAVHrn (ORCPT ); Fri, 22 Jan 2021 02:47:43 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E10F1C06174A; Thu, 21 Jan 2021 23:47:02 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A3BF4FB; Fri, 22 Jan 2021 08:47:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1611301620; bh=wt62T3G4ia9eC/+Hx1MTLqggmcGJG89Uw0CwF+nOj0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B+5jIAgtdhCwh6iyyJE+oAfkUmA3kWISa8YRKNA/9z3gQGgxr6Y18UIECrV4FsxYt HNsZWmw90R7jwXKqrsV9ibSaUOhZPiOdKI7SlYtaQvMVdpkLAiNtQNDj3rmdFRCyxE ULjBvpL3whCTRtMSg4RQ74lVzXXPbN6J+IldOHME= Date: Fri, 22 Jan 2021 09:46:41 +0200 From: Laurent Pinchart To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] arm64: dts: zynqmp: Wire up the DisplayPort subsystem Message-ID: References: <9769d4d103b6eb75e3324825117f6832a746004e.1611232558.git.michal.simek@xilinx.com> <80b7a167-86ad-3012-b080-b380e7013f18@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <80b7a167-86ad-3012-b080-b380e7013f18@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On Fri, Jan 22, 2021 at 08:19:15AM +0100, Michal Simek wrote: > On 1/21/21 11:37 PM, Laurent Pinchart wrote: > > On Thu, Jan 21, 2021 at 01:36:07PM +0100, Michal Simek wrote: > >> From: Laurent Pinchart > >> > >> Enable the dpsub device and wire it up to the PS-GTR PHY lanes routed to > >> the DisplayPort connector. > >> > >> Signed-off-by: Laurent Pinchart > >> Signed-off-by: Michal Simek > >> --- > >> > >> Wire all the boards > >> > >> --- > >> .../boot/dts/xilinx/zynqmp-zcu100-revC.dts | 31 +++++++++++++++++++ > >> .../boot/dts/xilinx/zynqmp-zcu102-revA.dts | 10 ++++++ > >> .../boot/dts/xilinx/zynqmp-zcu104-revA.dts | 11 +++++++ > >> .../boot/dts/xilinx/zynqmp-zcu104-revC.dts | 11 +++++++ > >> .../boot/dts/xilinx/zynqmp-zcu106-revA.dts | 11 +++++++ > >> .../boot/dts/xilinx/zynqmp-zcu111-revA.dts | 11 +++++++ > >> 6 files changed, 85 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts > >> index 71ebcaadb7c8..a53598c3624b 100644 > >> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts > >> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts > >> @@ -15,6 +15,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> > >> / { > >> model = "ZynqMP ZCU100 RevC"; > >> @@ -108,6 +109,18 @@ ina226 { > >> compatible = "iio-hwmon"; > >> io-channels = <&u35 0>, <&u35 1>, <&u35 2>, <&u35 3>; > >> }; > >> + > >> + si5335a_0: clk26 { > >> + compatible = "fixed-clock"; > >> + #clock-cells = <0>; > >> + clock-frequency = <26000000>; > >> + }; > >> + > >> + si5335a_1: clk27 { > >> + compatible = "fixed-clock"; > >> + #clock-cells = <0>; > >> + clock-frequency = <27000000>; > >> + }; > > > > This is fine as a workaround for now, but I'm still wondering how we'll > > solve this properly. We can declare the SI5335A in DT without wiring the > > output that provides the clock to the PS, otherwise it will be disabled > > as part of the boot process. > > All these clock chips are preprogrammed to certain rate and enabled by > default. It means there doesn't need to be any SW handling to enable it. > When driver for these clock chips comes we can change this that's why I > used labels which are saying which output it is. Unless I'm mistaken, on the ZCU106 board, the chip is an SI5341B, which has a driver already. I tried to declare it in DT, but the PS_REF_CLK then got disabled at the end of boot, and the system wasn't happy about it :-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D946C433E0 for ; Fri, 22 Jan 2021 07:48:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 250F822DBF for ; Fri, 22 Jan 2021 07:48:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 250F822DBF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ut8TU384dGncaex46iFTjfZ3WUOwDFvm7jZqow/r9dA=; b=BtVeGo+fvgZGRN056d848HPJZ wdt/Itx14+n62MFaKJUrl/ENbWkCcTL+Snf7NtT63xu7jSWrS5czDrwFIDWVO5/rttoBfWYGtsuHn HJ11JjBhqKI0U119Cz/PVgUSnJpLlm5hdNCYHBdX1CSjiMT6byglaQ78/DLQP9yX11/BUeftB0m6p 5XJ4zBRHmYLpkoDBath6bPoPZXZENCgLOQPcYHSKC4OjzDKkPY/TrM5j4EqV7W6oC6Ppm5rqlyaWz QlvcKPf3rBe24Sy6a8Ll3yVsmYqRFBj9iLa5Y9kqDHKPBCVpKGyrhaN4l+9ggBp71zOUTBIDZW/0E 31ty4PQAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2r9t-0002XE-6P; Fri, 22 Jan 2021 07:47:05 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2r9q-0002WY-Qp for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 07:47:03 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A3BF4FB; Fri, 22 Jan 2021 08:47:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1611301620; bh=wt62T3G4ia9eC/+Hx1MTLqggmcGJG89Uw0CwF+nOj0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B+5jIAgtdhCwh6iyyJE+oAfkUmA3kWISa8YRKNA/9z3gQGgxr6Y18UIECrV4FsxYt HNsZWmw90R7jwXKqrsV9ibSaUOhZPiOdKI7SlYtaQvMVdpkLAiNtQNDj3rmdFRCyxE ULjBvpL3whCTRtMSg4RQ74lVzXXPbN6J+IldOHME= Date: Fri, 22 Jan 2021 09:46:41 +0200 From: Laurent Pinchart To: Michal Simek Subject: Re: [PATCH 3/3] arm64: dts: zynqmp: Wire up the DisplayPort subsystem Message-ID: References: <9769d4d103b6eb75e3324825117f6832a746004e.1611232558.git.michal.simek@xilinx.com> <80b7a167-86ad-3012-b080-b380e7013f18@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <80b7a167-86ad-3012-b080-b380e7013f18@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_024703_089597_D38B876D X-CRM114-Status: GOOD ( 25.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, monstr@monstr.eu, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , git@xilinx.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, On Fri, Jan 22, 2021 at 08:19:15AM +0100, Michal Simek wrote: > On 1/21/21 11:37 PM, Laurent Pinchart wrote: > > On Thu, Jan 21, 2021 at 01:36:07PM +0100, Michal Simek wrote: > >> From: Laurent Pinchart > >> > >> Enable the dpsub device and wire it up to the PS-GTR PHY lanes routed to > >> the DisplayPort connector. > >> > >> Signed-off-by: Laurent Pinchart > >> Signed-off-by: Michal Simek > >> --- > >> > >> Wire all the boards > >> > >> --- > >> .../boot/dts/xilinx/zynqmp-zcu100-revC.dts | 31 +++++++++++++++++++ > >> .../boot/dts/xilinx/zynqmp-zcu102-revA.dts | 10 ++++++ > >> .../boot/dts/xilinx/zynqmp-zcu104-revA.dts | 11 +++++++ > >> .../boot/dts/xilinx/zynqmp-zcu104-revC.dts | 11 +++++++ > >> .../boot/dts/xilinx/zynqmp-zcu106-revA.dts | 11 +++++++ > >> .../boot/dts/xilinx/zynqmp-zcu111-revA.dts | 11 +++++++ > >> 6 files changed, 85 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts > >> index 71ebcaadb7c8..a53598c3624b 100644 > >> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts > >> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts > >> @@ -15,6 +15,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> > >> / { > >> model = "ZynqMP ZCU100 RevC"; > >> @@ -108,6 +109,18 @@ ina226 { > >> compatible = "iio-hwmon"; > >> io-channels = <&u35 0>, <&u35 1>, <&u35 2>, <&u35 3>; > >> }; > >> + > >> + si5335a_0: clk26 { > >> + compatible = "fixed-clock"; > >> + #clock-cells = <0>; > >> + clock-frequency = <26000000>; > >> + }; > >> + > >> + si5335a_1: clk27 { > >> + compatible = "fixed-clock"; > >> + #clock-cells = <0>; > >> + clock-frequency = <27000000>; > >> + }; > > > > This is fine as a workaround for now, but I'm still wondering how we'll > > solve this properly. We can declare the SI5335A in DT without wiring the > > output that provides the clock to the PS, otherwise it will be disabled > > as part of the boot process. > > All these clock chips are preprogrammed to certain rate and enabled by > default. It means there doesn't need to be any SW handling to enable it. > When driver for these clock chips comes we can change this that's why I > used labels which are saying which output it is. Unless I'm mistaken, on the ZCU106 board, the chip is an SI5341B, which has a driver already. I tried to declare it in DT, but the PS_REF_CLK then got disabled at the end of boot, and the system wasn't happy about it :-) -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel