From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 129A9C433E6 for ; Sun, 7 Feb 2021 14:37:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D429A64E50 for ; Sun, 7 Feb 2021 14:37:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229719AbhBGOfv (ORCPT ); Sun, 7 Feb 2021 09:35:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:49348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbhBGOfp (ORCPT ); Sun, 7 Feb 2021 09:35:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 64B7764E42; Sun, 7 Feb 2021 14:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612708503; bh=3oAePvp7BtjsZE5pGFHqzeOfislh9iQnGI/HKJOc+Dc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZrYvmFzVRVgfpGW9Pgc47Zn3ZqU6prI1sq6jhYlMFGfimmperFwI+D1ZuW0IyzjpC QVEumeTmmBwDIXCXwlnkm4NH/p6cBS1+ELiGEiHnM/Z6l9kmuUxx3auTMlh6HVRBC2 0SkiiiTdmRGZDG6p2j/FhCdExFCcQRgLJgxYYAzQ= Date: Sun, 7 Feb 2021 15:35:00 +0100 From: Greg KH To: Mahak Gupta Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, rcy@google.com, benchan@chromium.org, toddpoynor@google.com, rspringer@google.com Subject: Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis Message-ID: References: <20210207140928.11029-1-gmahak1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210207140928.11029-1-gmahak1@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 07, 2021 at 07:39:28PM +0530, Mahak Gupta wrote: > This patch fixes warnings of 'checkpatch.pl'. According to > Linux coding guidelines, code should be aligned properly to > match with open parenthesis and lines should not end with > open parenthesis. > > Signed-off-by: Mahak Gupta > --- > drivers/staging/gasket/gasket_ioctl.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c > index e3047d36d8db..a966231bad42 100644 > --- a/drivers/staging/gasket/gasket_ioctl.c > +++ b/drivers/staging/gasket/gasket_ioctl.c > @@ -40,7 +40,7 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev, > > /* Read the size of the page table. */ > static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > { > int ret = 0; > struct gasket_page_table_ioctl ibuf; > @@ -51,8 +51,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > if (ibuf.page_table_index >= gasket_dev->num_page_tables) > return -EFAULT; > > - ibuf.size = gasket_page_table_num_entries( > - gasket_dev->page_table[ibuf.page_table_index]); > + ibuf.size = gasket_page_table_num_entries(gasket_dev->page_table[ibuf.page_table_index]); > > trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size, > ibuf.host_address, > @@ -66,7 +65,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > > /* Read the size of the simple page table. */ > static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > { > int ret = 0; > struct gasket_page_table_ioctl ibuf; > @@ -92,7 +91,7 @@ static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev, > > /* Set the boundary between the simple and extended page tables. */ > static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > { > int ret; > struct gasket_page_table_ioctl ibuf; > @@ -107,8 +106,8 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > > if (ibuf.page_table_index >= gasket_dev->num_page_tables) > return -EFAULT; > - max_page_table_size = gasket_page_table_max_size( > - gasket_dev->page_table[ibuf.page_table_index]); > + max_page_table_size = gasket_page_table_max_size > + (gasket_dev->page_table[ibuf.page_table_index]); > > if (ibuf.size > max_page_table_size) { > dev_dbg(gasket_dev->dev, > @@ -119,8 +118,7 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > > mutex_lock(&gasket_dev->mutex); > > - ret = gasket_page_table_partition( > - gasket_dev->page_table[ibuf.page_table_index], ibuf.size); > + ret = gasket_page_table_partition(gasket_dev->page_table[ibuf.page_table_index], ibuf.size); > mutex_unlock(&gasket_dev->mutex); > > return ret; > @@ -183,7 +181,7 @@ static int gasket_unmap_buffers(struct gasket_dev *gasket_dev, > * corresponding memory. > */ > static int gasket_config_coherent_allocator(struct gasket_dev *gasket_dev, > - struct gasket_coherent_alloc_config_ioctl __user *argp) > + struct gasket_coherent_alloc_config_ioctl __user *argp) > { > int ret; > struct gasket_coherent_alloc_config_ioctl ibuf; > -- > 2.17.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D53C2C433DB for ; Sun, 7 Feb 2021 14:35:10 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69A7C64E4E for ; Sun, 7 Feb 2021 14:35:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A7C64E4E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2A96A204B0; Sun, 7 Feb 2021 14:35:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OLRIi2j-dLmT; Sun, 7 Feb 2021 14:35:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 59E4E20468; Sun, 7 Feb 2021 14:35:08 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 4C80D1BF3F4 for ; Sun, 7 Feb 2021 14:35:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4226120481 for ; Sun, 7 Feb 2021 14:35:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xznAK6nWIOxO for ; Sun, 7 Feb 2021 14:35:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 419C9204B4 for ; Sun, 7 Feb 2021 14:35:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 64B7764E42; Sun, 7 Feb 2021 14:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612708503; bh=3oAePvp7BtjsZE5pGFHqzeOfislh9iQnGI/HKJOc+Dc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZrYvmFzVRVgfpGW9Pgc47Zn3ZqU6prI1sq6jhYlMFGfimmperFwI+D1ZuW0IyzjpC QVEumeTmmBwDIXCXwlnkm4NH/p6cBS1+ELiGEiHnM/Z6l9kmuUxx3auTMlh6HVRBC2 0SkiiiTdmRGZDG6p2j/FhCdExFCcQRgLJgxYYAzQ= Date: Sun, 7 Feb 2021 15:35:00 +0100 From: Greg KH To: Mahak Gupta Subject: Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis Message-ID: References: <20210207140928.11029-1-gmahak1@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210207140928.11029-1-gmahak1@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, rcy@google.com, rspringer@google.com, toddpoynor@google.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, Feb 07, 2021 at 07:39:28PM +0530, Mahak Gupta wrote: > This patch fixes warnings of 'checkpatch.pl'. According to > Linux coding guidelines, code should be aligned properly to > match with open parenthesis and lines should not end with > open parenthesis. > > Signed-off-by: Mahak Gupta > --- > drivers/staging/gasket/gasket_ioctl.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c > index e3047d36d8db..a966231bad42 100644 > --- a/drivers/staging/gasket/gasket_ioctl.c > +++ b/drivers/staging/gasket/gasket_ioctl.c > @@ -40,7 +40,7 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev, > > /* Read the size of the page table. */ > static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > { > int ret = 0; > struct gasket_page_table_ioctl ibuf; > @@ -51,8 +51,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > if (ibuf.page_table_index >= gasket_dev->num_page_tables) > return -EFAULT; > > - ibuf.size = gasket_page_table_num_entries( > - gasket_dev->page_table[ibuf.page_table_index]); > + ibuf.size = gasket_page_table_num_entries(gasket_dev->page_table[ibuf.page_table_index]); > > trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size, > ibuf.host_address, > @@ -66,7 +65,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > > /* Read the size of the simple page table. */ > static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > { > int ret = 0; > struct gasket_page_table_ioctl ibuf; > @@ -92,7 +91,7 @@ static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev, > > /* Set the boundary between the simple and extended page tables. */ > static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > { > int ret; > struct gasket_page_table_ioctl ibuf; > @@ -107,8 +106,8 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > > if (ibuf.page_table_index >= gasket_dev->num_page_tables) > return -EFAULT; > - max_page_table_size = gasket_page_table_max_size( > - gasket_dev->page_table[ibuf.page_table_index]); > + max_page_table_size = gasket_page_table_max_size > + (gasket_dev->page_table[ibuf.page_table_index]); > > if (ibuf.size > max_page_table_size) { > dev_dbg(gasket_dev->dev, > @@ -119,8 +118,7 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > > mutex_lock(&gasket_dev->mutex); > > - ret = gasket_page_table_partition( > - gasket_dev->page_table[ibuf.page_table_index], ibuf.size); > + ret = gasket_page_table_partition(gasket_dev->page_table[ibuf.page_table_index], ibuf.size); > mutex_unlock(&gasket_dev->mutex); > > return ret; > @@ -183,7 +181,7 @@ static int gasket_unmap_buffers(struct gasket_dev *gasket_dev, > * corresponding memory. > */ > static int gasket_config_coherent_allocator(struct gasket_dev *gasket_dev, > - struct gasket_coherent_alloc_config_ioctl __user *argp) > + struct gasket_coherent_alloc_config_ioctl __user *argp) > { > int ret; > struct gasket_coherent_alloc_config_ioctl ibuf; > -- > 2.17.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel