All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sjoerd Simons <sjoerd@collabora.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Trent Piepho <tpiepho@gmail.com>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Hilda Wu <hildawu@realtek.com>,
	Sathish Narasimman <sathish.narasimman@intel.com>,
	Chethan T N <chethan.tumkur.narayan@intel.com>,
	Hsin-Yu Chao <hychao@chromium.org>,
	Amit K Bag <amit.k.bag@intel.com>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	kernel@collabora.com
Subject: Re: [PATCH] Bluetooth: btusb: Always fallback to alt 1 for WBS
Date: Sat, 6 Feb 2021 16:56:53 +0100	[thread overview]
Message-ID: <YB68RUVLRGQKS+yH@dawn.lan> (raw)
In-Reply-To: <7ADF39E2-647E-49E2-9C5B-B0BF6A303B95@holtmann.org>

On Fri, Dec 18, 2020 at 10:23:08PM +0100, Marcel Holtmann wrote:
> Hi Trent,
> 
> > When alt mode 6 is not available, fallback to the kernel <= 5.7 behavior
> > of always using alt mode 1.
> > 
> > Prior to kernel 5.8, btusb would always use alt mode 1 for WBS (Wide
> > Band Speech aka mSBC aka transparent SCO).  In commit baac6276c0a9
> > ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") this
> > was changed to use alt mode 6, which is the recommended mode in the
> > Bluetooth spec (Specifications of the Bluetooth System, v5.0, Vol 4.B
> > §2.2.1).  However, many if not most BT USB adapters do not support alt
> > mode 6.  In fact, I have been unable to find any which do.

> patch has been applied to bluetooth-next tree.

For easier application to the stable tree(s) this should probably get:
  Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints")

In my testing this indeed fixes mSBC audio with both a Belkin (Broadcom
BCM20702A, 050d:065a) and an Intel Bluetooth (8087:0a2b) adapters.

  Tested-By: Sjoerd Simons <sjoerd@collabora.com>

Regards,
  Sjoerd

  reply	other threads:[~2021-02-06 15:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  1:20 Trent Piepho
2020-12-10  1:47 ` bluez.test.bot
2020-12-18 21:23 ` [PATCH] " Marcel Holtmann
2021-02-06 15:56   ` Sjoerd Simons [this message]
2021-02-21 20:35     ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YB68RUVLRGQKS+yH@dawn.lan \
    --to=sjoerd@collabora.com \
    --cc=amit.k.bag@intel.com \
    --cc=chethan.tumkur.narayan@intel.com \
    --cc=hildawu@realtek.com \
    --cc=hychao@chromium.org \
    --cc=johan.hedberg@gmail.com \
    --cc=kernel@collabora.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=sathish.narasimman@intel.com \
    --cc=tpiepho@gmail.com \
    --subject='Re: [PATCH] Bluetooth: btusb: Always fallback to alt 1 for WBS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.