From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13BD4C433E0 for ; Sat, 6 Feb 2021 14:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D654764E07 for ; Sat, 6 Feb 2021 14:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbhBFOsu (ORCPT ); Sat, 6 Feb 2021 09:48:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:45452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhBFOss (ORCPT ); Sat, 6 Feb 2021 09:48:48 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9076164E07; Sat, 6 Feb 2021 14:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612622885; bh=zzXvxVS+Xw1NCFGJcGNwRuw+NifbomFWMPorWMHezCc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ge9ccY8B+gmZ+goe5n6Si8kLaJoml9kcICYzs+Z0j7CdaW4rO6wb8LAsUvAzEWovM SACuKvR4UZNk7K+Fd20fIG9MwYNGpj0ICY1WB/HidXCE8coHZ8wzYF2Bbg8TMYm+yz KOaKUkaYa0A11KWBIoSq15jVoOv2ez3VL+QcHWfo= Date: Sat, 6 Feb 2021 15:48:02 +0100 From: Greg Kroah-Hartman To: Tomas Winkler Cc: Alexander Usyskin , linux-kernel@vger.kernel.org Subject: Re: [char-misc-next 6/6] mei: bus: add client dma interface Message-ID: References: <20210206144325.25682-1-tomas.winkler@intel.com> <20210206144325.25682-6-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210206144325.25682-6-tomas.winkler@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 06, 2021 at 04:43:25PM +0200, Tomas Winkler wrote: > From: Alexander Usyskin > > Expose the client dma mapping via mei client > bus interface. > > Signed-off-by: Alexander Usyskin > Signed-off-by: Tomas Winkler > --- > drivers/misc/mei/bus.c | 46 ++++++++++++++++++++++++++++++++++++++ > drivers/misc/mei/hw.h | 5 +++++ > include/linux/mei_cl_bus.h | 3 +++ > 3 files changed, 54 insertions(+) > > diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c > index 34fb5e541fe5..d430710a5fe5 100644 > --- a/drivers/misc/mei/bus.c > +++ b/drivers/misc/mei/bus.c > @@ -636,6 +636,52 @@ static void mei_cl_bus_vtag_free(struct mei_cl_device *cldev) > kfree(cl_vtag); > } > > +void *mei_cldev_dma_map(struct mei_cl_device *cldev, u8 buffer_id, size_t size) > +{ > + struct mei_device *bus; > + struct mei_cl *cl; > + int ret; > + > + if (!cldev || !buffer_id || !size) > + return ERR_PTR(-EINVAL); > + > + if (!IS_ALIGNED(size, MEI_FW_PAGE_SIZE)) { > + dev_err(&cldev->dev, "Map size should be aligned to %lu\n", > + MEI_FW_PAGE_SIZE); > + return ERR_PTR(-EINVAL); > + } > + > + cl = cldev->cl; > + bus = cldev->bus; > + > + mutex_lock(&bus->device_lock); > + ret = mei_cl_dma_alloc_and_map(cl, NULL, buffer_id, size); > + mutex_unlock(&bus->device_lock); > + if (ret) > + return ERR_PTR(ret); > + return cl->dma.vaddr; > +} > +EXPORT_SYMBOL_GPL(mei_cldev_dma_map); Why are you exporting symbols without a user of them? That's a sure way to get them removed by someone right after this lands in the tree :) Please only add infrastructure for when you have a real user. thanks, greg k-h