From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15EEDC433DB for ; Wed, 27 Jan 2021 14:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD4F120799 for ; Wed, 27 Jan 2021 14:16:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234128AbhA0OQR (ORCPT ); Wed, 27 Jan 2021 09:16:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:40558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233913AbhA0ONt (ORCPT ); Wed, 27 Jan 2021 09:13:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id DEF33207B3; Wed, 27 Jan 2021 14:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611756788; bh=91+FckkF0XsQXE8G5xq3ONP86dhD26FJMlpOx+Kbuoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W8+KGfUXGrGH4qYqQIY+nAVen4ZTYfKvnxOGcqhfoG913R+Gsx2EaPYD4gSiGHbVS xtLwgaMKy3EYdYI5fAnnB+fO4QG2DeNVFxoPEvxxAjmOROjfzQNVZb25FubocBNStR 321EdMt8sT45bFDyXKL2xSyXmY1vCM+SIw8av3X0= Date: Wed, 27 Jan 2021 15:13:05 +0100 From: Greg KH To: carlis Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, mh12gx2825@gmail.com, oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sbrivio@redhat.com, colin.king@canonical.com, zhangxuezhi1@yulong.com Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect Message-ID: References: <1611754972-151016-1-git-send-email-zhangxuezhi3@gmail.com> <20210127220809.000026fb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127220809.000026fb@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > On Wed, 27 Jan 2021 14:51:55 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > From: zhangxuezhi > > > > > > For st7789v ic,when we need continuous full screen refresh, it is > > > best to wait for the TE signal arrive to avoid screen tearing > > > > > > Signed-off-by: zhangxuezhi > > > > Please slow down and wait at least a day between patch submissions, > > there is no rush here. > > > > And also, ALWAYS run scripts/checkpatch.pl on your submissions, so > > that you don't have a maintainer asking you about basic problems, > > like are in this current patch :( > > > > thanks, > > > > greg k-h > > hi, > This is my first patch contribution to Linux, so some of the rules > are not very clear .In addition, I can confirm that before sending > patch, I check it with checkPatch.py every time.Thank you very much for > your help Please read Documentation/SubmittingPatches which has a link to the checklist and other documentation you should read. And I doubt you are running checkpatch on your submission, as there is obvious coding style issues in it. If so, please provide the output as it must be broken :( thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10578C433E6 for ; Wed, 27 Jan 2021 14:13:13 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9308120799 for ; Wed, 27 Jan 2021 14:13:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9308120799 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 22DA0867F8; Wed, 27 Jan 2021 14:13:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xLilII1MUXwg; Wed, 27 Jan 2021 14:13:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 6664886813; Wed, 27 Jan 2021 14:13:11 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D06851BF301 for ; Wed, 27 Jan 2021 14:13:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C4A50227AD for ; Wed, 27 Jan 2021 14:13:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QfMs7TktBwkA for ; Wed, 27 Jan 2021 14:13:08 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id D96502279B for ; Wed, 27 Jan 2021 14:13:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DEF33207B3; Wed, 27 Jan 2021 14:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611756788; bh=91+FckkF0XsQXE8G5xq3ONP86dhD26FJMlpOx+Kbuoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W8+KGfUXGrGH4qYqQIY+nAVen4ZTYfKvnxOGcqhfoG913R+Gsx2EaPYD4gSiGHbVS xtLwgaMKy3EYdYI5fAnnB+fO4QG2DeNVFxoPEvxxAjmOROjfzQNVZb25FubocBNStR 321EdMt8sT45bFDyXKL2xSyXmY1vCM+SIw8av3X0= Date: Wed, 27 Jan 2021 15:13:05 +0100 From: Greg KH To: carlis Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect Message-ID: References: <1611754972-151016-1-git-send-email-zhangxuezhi3@gmail.com> <20210127220809.000026fb@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210127220809.000026fb@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, mh12gx2825@gmail.com, oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sbrivio@redhat.com, colin.king@canonical.com, zhangxuezhi1@yulong.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > On Wed, 27 Jan 2021 14:51:55 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > From: zhangxuezhi > > > > > > For st7789v ic,when we need continuous full screen refresh, it is > > > best to wait for the TE signal arrive to avoid screen tearing > > > > > > Signed-off-by: zhangxuezhi > > > > Please slow down and wait at least a day between patch submissions, > > there is no rush here. > > > > And also, ALWAYS run scripts/checkpatch.pl on your submissions, so > > that you don't have a maintainer asking you about basic problems, > > like are in this current patch :( > > > > thanks, > > > > greg k-h > > hi, > This is my first patch contribution to Linux, so some of the rules > are not very clear .In addition, I can confirm that before sending > patch, I check it with checkPatch.py every time.Thank you very much for > your help Please read Documentation/SubmittingPatches which has a link to the checklist and other documentation you should read. And I doubt you are running checkpatch on your submission, as there is obvious coding style issues in it. If so, please provide the output as it must be broken :( thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54EA7C433DB for ; Wed, 27 Jan 2021 14:13:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E77A120799 for ; Wed, 27 Jan 2021 14:13:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E77A120799 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B1846E5CC; Wed, 27 Jan 2021 14:13:10 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id A91366E5CC for ; Wed, 27 Jan 2021 14:13:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DEF33207B3; Wed, 27 Jan 2021 14:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611756788; bh=91+FckkF0XsQXE8G5xq3ONP86dhD26FJMlpOx+Kbuoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W8+KGfUXGrGH4qYqQIY+nAVen4ZTYfKvnxOGcqhfoG913R+Gsx2EaPYD4gSiGHbVS xtLwgaMKy3EYdYI5fAnnB+fO4QG2DeNVFxoPEvxxAjmOROjfzQNVZb25FubocBNStR 321EdMt8sT45bFDyXKL2xSyXmY1vCM+SIw8av3X0= Date: Wed, 27 Jan 2021 15:13:05 +0100 From: Greg KH To: carlis Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect Message-ID: References: <1611754972-151016-1-git-send-email-zhangxuezhi3@gmail.com> <20210127220809.000026fb@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210127220809.000026fb@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, mh12gx2825@gmail.com, oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sbrivio@redhat.com, colin.king@canonical.com, zhangxuezhi1@yulong.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > On Wed, 27 Jan 2021 14:51:55 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > From: zhangxuezhi > > > > > > For st7789v ic,when we need continuous full screen refresh, it is > > > best to wait for the TE signal arrive to avoid screen tearing > > > > > > Signed-off-by: zhangxuezhi > > > > Please slow down and wait at least a day between patch submissions, > > there is no rush here. > > > > And also, ALWAYS run scripts/checkpatch.pl on your submissions, so > > that you don't have a maintainer asking you about basic problems, > > like are in this current patch :( > > > > thanks, > > > > greg k-h > > hi, > This is my first patch contribution to Linux, so some of the rules > are not very clear .In addition, I can confirm that before sending > patch, I check it with checkPatch.py every time.Thank you very much for > your help Please read Documentation/SubmittingPatches which has a link to the checklist and other documentation you should read. And I doubt you are running checkpatch on your submission, as there is obvious coding style issues in it. If so, please provide the output as it must be broken :( thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel