All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: olivier.moysan@st.com, alexandre.torgue@st.com,
	linux-doc@vger.kernel.org, mchehab+huawei@kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	jic23@kernel.org, lukas.bulwahn@gmail.com,
	fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] counter: stm32-lptimer-cnt: remove iio counter abi
Date: Fri, 29 Jan 2021 17:35:24 +0900	[thread overview]
Message-ID: <YBPIzBhxkcsqKmMM@shinobu> (raw)
In-Reply-To: <1611327803-882-1-git-send-email-fabrice.gasnier@foss.st.com>


[-- Attachment #1.1: Type: text/plain, Size: 1405 bytes --]

On Fri, Jan 22, 2021 at 04:03:23PM +0100, Fabrice Gasnier wrote:
> Currently, the STM32 LP Timer counter driver registers into both IIO and
> counter subsystems, which is redundant.
> 
> Remove the IIO counter ABI and IIO registration from the STM32 LP Timer
> counter driver since it's been superseded by the Counter subsystem
> as discussed in [1].
> 
> Keep only the counter subsystem related part.
> Move a part of the ABI documentation into a driver comment.
> 
> This also removes a duplicate ABI warning
> $ scripts/get_abi.pl validate
> ...
> /sys/bus/iio/devices/iio:deviceX/in_count0_preset is defined 2 times:
>   ./Documentation/ABI/testing/sysfs-bus-iio-timer-stm32:100
>   ./Documentation/ABI/testing/sysfs-bus-iio-lptimer-stm32:0
> 
> [1] https://lkml.org/lkml/2021/1/19/347
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
>  .../ABI/testing/sysfs-bus-iio-lptimer-stm32        |  62 -----
>  drivers/counter/stm32-lptimer-cnt.c                | 297 +++------------------
>  2 files changed, 36 insertions(+), 323 deletions(-)
>  delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lptimer-stm32

Hi Fabrice,

I noticed this is missing a Kconfig change to remove the IIO dependency
from the STM32_LPTIMER_CNT config option. I assume that dependency is no
longer necessary with the IIO code is removed.

William Breathitt Gray

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-29  8:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 15:03 [PATCH] counter: stm32-lptimer-cnt: remove iio counter abi Fabrice Gasnier
2021-01-22 15:03 ` Fabrice Gasnier
2021-01-24  6:52 ` William Breathitt Gray
2021-01-24  6:52   ` William Breathitt Gray
2021-01-29  8:35 ` William Breathitt Gray [this message]
2021-01-29  9:59   ` Fabrice Gasnier
2021-01-29 11:02     ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBPIzBhxkcsqKmMM@shinobu \
    --to=vilhelm.gray@gmail.com \
    --cc=alexandre.torgue@st.com \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=fabrice.gasnier@st.com \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=lukas.bulwahn@gmail.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=olivier.moysan@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.