All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Sean Christopherson <seanjc@google.com>,
	Shuah Khan <shuah@kernel.org>,
	x86@kernel.org, linux-sgx@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jia Zhang <zhang.jia@linux.alibaba.com>
Subject: Re: [PATCH v3 2/5] x86/sgx: Optimize the locking range in sgx_sanitize_section()
Date: Sat, 30 Jan 2021 15:24:49 +0200	[thread overview]
Message-ID: <YBVeIb+o2VGzEurU@kernel.org> (raw)
In-Reply-To: <20210124062907.88229-3-tianjia.zhang@linux.alibaba.com>

On Sun, Jan 24, 2021 at 02:29:04PM +0800, Tianjia Zhang wrote:
> The spin lock of sgx_epc_section only locks the page_list. The
> EREMOVE operation and init_laundry_list is not necessary in the
> protection range of the spin lock. This patch reduces the lock
> range of the spin lock in the function sgx_sanitize_section()
> and only protects the operation of the page_list.
> 
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

I prefer to use the word "optimize" only if there is supporting
data to show that the code change has significant value.

/Jarkko

  reply	other threads:[~2021-01-30 13:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24  6:29 [PATCH v3 0/5] Some optimizations related to sgx Tianjia Zhang
2021-01-24  6:29 ` [PATCH v3 1/5] selftests/x86: Simplify the code to get vdso base address in sgx Tianjia Zhang
2021-01-24  6:29 ` [PATCH v3 2/5] x86/sgx: Optimize the locking range in sgx_sanitize_section() Tianjia Zhang
2021-01-30 13:24   ` Jarkko Sakkinen [this message]
2021-01-24  6:29 ` [PATCH v3 3/5] x86/sgx: Optimize the free_cnt count in sgx_epc_section Tianjia Zhang
2021-01-27 17:40   ` Jarkko Sakkinen
2021-02-11  6:04     ` Tianjia Zhang
2021-02-12 12:19       ` Jarkko Sakkinen
2021-02-16  3:30         ` Tianjia Zhang
2021-01-24  6:29 ` [PATCH v3 4/5] x86/sgx: Allows ioctl PROVISION to execute before CREATE Tianjia Zhang
2021-01-30 13:26   ` Jarkko Sakkinen
2021-02-01 12:55     ` Tianjia Zhang
2021-01-24  6:29 ` [PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create Tianjia Zhang
2021-01-24  8:20   ` Greg KH
2021-01-25 18:46     ` Sean Christopherson
2021-01-30 14:33   ` Jarkko Sakkinen
2021-02-01 12:37     ` Tianjia Zhang
2021-01-25 17:22 ` [PATCH v3 0/5] Some optimizations related to sgx Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBVeIb+o2VGzEurU@kernel.org \
    --to=jarkko@kernel.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tianjia.zhang@linux.alibaba.com \
    --cc=x86@kernel.org \
    --cc=zhang.jia@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.