From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] meson: Turn off -Werror
Date: Mon, 1 Feb 2021 10:07:34 +0200 [thread overview]
Message-ID: <YBe2xlzoqepycMNu@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <161216649171.30865.13362995240619604363@build.alporthouse.com>
On Mon, Feb 01, 2021 at 08:01:31AM +0000, Chris Wilson wrote:
> Quoting Petri Latvala (2021-02-01 06:33:39)
> > No, we don't want all warnings ever to be errors. While being rid of
> > compile warnings (especially the more obscure ones from future
> > compilers) is great, having it on always is not acceptable. It's not
> > even on "by default", it was non-overrideably set on.
> >
> > Not to mention adding -Werror to compiler flags is the incorrect way
> > of turning it on. Use the meson command line flag --werror instead on
> > whatever local checkout or company-internal fork you're using, where
> > you have control over which compilers are used. Turning it on
> > unconditionally in an upstream repository for all current and future
> > compilers is never ok.
>
> Do you have a plan to enable --werror for CI?
For select distros, possibly.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-02-01 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 6:33 [igt-dev] [PATCH i-g-t] meson: Turn off -Werror Petri Latvala
2021-02-01 8:01 ` Chris Wilson
2021-02-01 8:07 ` Petri Latvala [this message]
2021-02-01 8:12 ` Chris Wilson
2021-02-01 8:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-01 10:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBe2xlzoqepycMNu@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.