All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Bart Van Assche <bvanassche@acm.org>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	Zang Leigang <zangleigang@hisilicon.com>,
	Avi Shchislowski <Avi.Shchislowski@wdc.com>,
	Bean Huo <beanhuo@micron.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: Re: [PATCH 3/8] scsi: ufshpb: Add region's reads counter
Date: Mon, 1 Feb 2021 08:30:51 +0100	[thread overview]
Message-ID: <YBeuK92cgBkvYpk1@kroah.com> (raw)
In-Reply-To: <DM6PR04MB657521540E2769C5F1BA2BBFFCB69@DM6PR04MB6575.namprd04.prod.outlook.com>

On Mon, Feb 01, 2021 at 07:12:53AM +0000, Avri Altman wrote:
> > > +#define WORK_PENDING 0
> > > +#define ACTIVATION_THRSHLD 4 /* 4 IOs */
> > Rather than fixing it with macro, how about using sysfs and make it
> > configurable?
> Yes.
> I will add a patch making all the logic configurable.
> As all those are hpb-related parameters, I think module parameters are more adequate.

No, this is not the 1990's, please never add new module parameters to
drivers.  If not for the basic problem of they do not work on a
per-device basis, but on a per-driver basis, which is what you almost
never want.

But why would you want to change this value, why can't the driver "just
work" and not need manual intervention?

thanks,

greg k-h

  reply	other threads:[~2021-02-01  7:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 15:12 [PATCH 0/8] Add Host control mode to HPB Avri Altman
2021-01-27 15:12 ` [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-01-27 15:19   ` Greg KH
2021-01-31  7:08     ` Avri Altman
2021-01-31  7:13       ` Greg KH
2021-01-31  7:17         ` Avri Altman
2021-01-27 15:12 ` [PATCH 2/8] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-01-27 15:20   ` Greg KH
2021-01-31  7:08     ` Avri Altman
2021-01-27 15:12 ` [PATCH 3/8] scsi: ufshpb: Add region's reads counter Avri Altman
2021-01-27 15:21   ` Greg KH
2021-01-31  7:25     ` Avri Altman
2021-01-31  7:35       ` Greg KH
2021-01-27 15:12 ` [PATCH 4/8] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-01-27 15:12 ` [PATCH 5/8] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-01-27 15:12 ` [PATCH 6/8] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-01-27 15:12 ` [PATCH 7/8] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-01-27 15:23   ` Greg KH
2021-01-31  7:30     ` Avri Altman
2021-01-27 15:12 ` [PATCH 8/8] scsi: ufshpb: Add support for host control mode Avri Altman
     [not found] ` <CGME20210127151311epcas2p1696c2b73f3b4777ac0e7f603790b552f@epcms2p2>
2021-02-01  3:51   ` [PATCH 3/8] scsi: ufshpb: Add region's reads counter Daejun Park
2021-02-01  7:12     ` Avri Altman
2021-02-01  7:30       ` gregkh [this message]
2021-02-01  7:51         ` Avri Altman
2021-02-01  8:01           ` gregkh
2021-02-01  8:17             ` Avri Altman
2021-02-01  8:44               ` gregkh
2021-02-01  9:04                 ` Avri Altman
     [not found] ` <CGME20210127151318epcas2p1cdad0118807907e55b8d8277daec6f1a@epcms2p4>
2021-02-01  3:59   ` [PATCH 4/8] scsi: ufshpb: Make eviction depends on region's reads Daejun Park
2021-02-01  7:14     ` Avri Altman
     [not found] ` <CGME20210127151338epcas2p2c323a148587e311f7f5e19b4edbe43ec@epcms2p4>
2021-02-01  5:10   ` [PATCH 6/8] scsi: ufshpb: Add hpb dev reset response Daejun Park
2021-02-01  7:20     ` Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBeuK92cgBkvYpk1@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Avi.Shchislowski@wdc.com \
    --cc=Avri.Altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=daejun7.park@samsung.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=ymhungry.lee@samsung.com \
    --cc=zangleigang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.