From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2828DC433DB for ; Mon, 1 Feb 2021 18:00:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDB5C64E97 for ; Mon, 1 Feb 2021 18:00:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231807AbhBASAU (ORCPT ); Mon, 1 Feb 2021 13:00:20 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37786 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229555AbhBASAS (ORCPT ); Mon, 1 Feb 2021 13:00:18 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 111HxPfR028486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Feb 2021 12:59:25 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 15A5B15C39D9; Mon, 1 Feb 2021 12:59:25 -0500 (EST) Date: Mon, 1 Feb 2021 12:59:25 -0500 From: "Theodore Ts'o" To: Lukas Bulwahn Cc: Greg KH , Dwaipayan Ray , Joe Perches , linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel Subject: Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 05:50:45PM +0100, Lukas Bulwahn wrote: > > Dwaipayan, there are two ways: > - We build a bot listening to mailing lists and check. I like that > implementation idea for various other checks. > - Stephen Rothwell could include this as a check on linux-next and > inform the git author and committer. > > I am wondering though if that is worth the effort, three instances of > a wrong date among 1M commits seems to be very seldom and the harm of > that mistake is quite small as well. Another solution might be to ask the git developers if they would be willing to have "git am" print a warning if the date is sufficiently insane (say, more than 3 months in the past or present). One could also imagine a request that "git log" would have a new format where normally the author time is printed, but if it's sufficiently different from the commit time, the commit time is also printed in parenthesis. Or you could set up your git config so that "git log" uses --pretty=fuller by default, which prints both the author date and commit date. Like Lukas, I'm not really sure it's worth the effort, however. - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39B0C433DB for ; Mon, 1 Feb 2021 17:59:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5641264E97 for ; Mon, 1 Feb 2021 17:59:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5641264E97 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 122F286FF2; Mon, 1 Feb 2021 17:59:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Px3BwnB7-POZ; Mon, 1 Feb 2021 17:59:30 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id EA34886FF5; Mon, 1 Feb 2021 17:59:30 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CFDF8C0FA7; Mon, 1 Feb 2021 17:59:30 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id E194EC013A for ; Mon, 1 Feb 2021 17:59:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C88AE8608B for ; Mon, 1 Feb 2021 17:59:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jkrqHleKCZEx for ; Mon, 1 Feb 2021 17:59:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by whitealder.osuosl.org (Postfix) with ESMTPS id E661386473 for ; Mon, 1 Feb 2021 17:59:28 +0000 (UTC) Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 111HxPfR028486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Feb 2021 12:59:25 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 15A5B15C39D9; Mon, 1 Feb 2021 12:59:25 -0500 (EST) Date: Mon, 1 Feb 2021 12:59:25 -0500 From: "Theodore Ts'o" To: Lukas Bulwahn Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Joe Perches , linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel , Dwaipayan Ray Subject: Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help? X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, Feb 01, 2021 at 05:50:45PM +0100, Lukas Bulwahn wrote: > > Dwaipayan, there are two ways: > - We build a bot listening to mailing lists and check. I like that > implementation idea for various other checks. > - Stephen Rothwell could include this as a check on linux-next and > inform the git author and committer. > > I am wondering though if that is worth the effort, three instances of > a wrong date among 1M commits seems to be very seldom and the harm of > that mistake is quite small as well. Another solution might be to ask the git developers if they would be willing to have "git am" print a warning if the date is sufficiently insane (say, more than 3 months in the past or present). One could also imagine a request that "git log" would have a new format where normally the author time is printed, but if it's sufficiently different from the commit time, the commit time is also printed in parenthesis. Or you could set up your git config so that "git log" uses --pretty=fuller by default, which prints both the author date and commit date. Like Lukas, I'm not really sure it's worth the effort, however. - Ted _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees