From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/6] zram01.sh: Generate test setup variables in setup
Date: Tue, 2 Feb 2021 08:17:00 +0100 [thread overview]
Message-ID: <YBj8bMKfxqvQ6lYt@pevik> (raw)
In-Reply-To: <CAEemH2ffReVSE_210nyRZVZHOwoMMy-F4Cye08RwPa5bh7PZ0w@mail.gmail.com>
Hi Li,
> Hi Petr,
> Petr Vorel <pvorel@suse.cz> wrote:
> > ...
> > diff --git a/testcases/kernel/device-drivers/zram/zram01.sh
> > b/testcases/kernel/device-drivers/zram/zram01.sh
> > index a795ff89f..c5d4a3e51 100755
> > --- a/testcases/kernel/device-drivers/zram/zram01.sh
> > +++ b/testcases/kernel/device-drivers/zram/zram01.sh
> > @@ -8,23 +8,25 @@
> > TST_CNT=7
> > TST_TESTFUNC="do_test"
> > -TST_NEEDS_CMDS="awk bc dd"
> > +TST_NEEDS_CMDS="awk bc dd grep"
> > . zram_lib.sh
> > +TST_SETUP="setup"
> > -# List of parameters for zram devices.
> > -# For each number the test creates own zram device.
> > -zram_max_streams="2 3 5 8"
> > -
> > -FS_SIZE="402653184"
> > -FS_TYPE="btrfs"
> > +get_btrfs_size()
> What about renaming at_least_1G_mem() or check_space_for_btrfs()?
Good point. I'm slightly for check_space_for_btrfs().
at_least_1G_mem() is also good, but for that I'd also move tst_res TINFO "not
enough space for Btrfs" out of the function and put it into generate_vars(). But
since it's used only for btrfs I slightly prefer check_space_for_btrfs(). But no
strong opinion about it.
Thanks for your review!
Kind regards,
Petr
next prev parent reply other threads:[~2021-02-02 7:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:41 [LTP] [PATCH v2 0/6] zram cleanup Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 1/6] zram: Calculate dev_num variable Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 2/6] zram01.sh: Generate test setup variables in setup Petr Vorel
2021-01-29 20:17 ` Petr Vorel
2021-01-30 5:37 ` Li Wang
2021-02-02 7:17 ` Petr Vorel [this message]
2021-02-02 11:16 ` Li Wang
2021-02-06 19:59 ` Petr Vorel
2021-02-08 7:11 ` Petr Vorel
2021-02-18 9:00 ` Li Wang
2021-03-01 14:34 ` Cyril Hrubis
2021-03-01 16:04 ` Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 3/6] zram: Move zram_compress_alg() to zram02.sh Petr Vorel
2021-03-01 14:55 ` Cyril Hrubis
2021-03-01 15:35 ` Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 4/6] zram: Move test specific functions out of zram_lib.sh Petr Vorel
2021-03-01 14:57 ` Cyril Hrubis
2021-01-29 19:41 ` [LTP] [RFC PATCH v2 5/6] tst_test.sh: Run _tst_setup_timer after $TST_SETUP Petr Vorel
2021-01-29 20:17 ` Petr Vorel
2021-03-01 15:06 ` Cyril Hrubis
2021-01-29 19:41 ` [LTP] [PATCH v2 6/6] zram: Increase timeout according to used devices Petr Vorel
2021-01-29 20:10 ` Petr Vorel
2021-01-29 20:15 ` Petr Vorel
2021-01-30 8:26 ` Li Wang
2021-02-02 7:38 ` Petr Vorel
2021-02-02 11:25 ` Li Wang
2021-03-01 15:14 ` Cyril Hrubis
2021-03-01 15:41 ` Petr Vorel
2021-03-01 15:45 ` Petr Vorel
2021-03-01 15:48 ` Cyril Hrubis
2021-03-01 16:18 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBj8bMKfxqvQ6lYt@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.