From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C51C433DB for ; Wed, 3 Feb 2021 05:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EEA864F4C for ; Wed, 3 Feb 2021 05:06:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbhBCFGV (ORCPT ); Wed, 3 Feb 2021 00:06:21 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42540 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229487AbhBCFGT (ORCPT ); Wed, 3 Feb 2021 00:06:19 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 11355O9M011510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 3 Feb 2021 00:05:24 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0188915C39E2; Wed, 3 Feb 2021 00:05:23 -0500 (EST) Date: Wed, 3 Feb 2021 00:05:23 -0500 From: "Theodore Ts'o" To: Daejun Park Cc: harshad shirwadkar , "adilger.kernel@dilger.ca" , "linux-kernel@vger.kernel.org" , "linux-ext4@vger.kernel.org" Subject: Re: [PATCH v2] ext4: Change list_for_each* to list_for_each_entry* Message-ID: References: <20210111013726epcms2p4579ae56040d7043db785bf0d0a785dc7@epcms2p4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111013726epcms2p4579ae56040d7043db785bf0d0a785dc7@epcms2p4> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 10:37:26AM +0900, Daejun Park wrote: > In the fast_commit.c, list_for_each* + list_entry can be changed to > list_for_each_entry*. It reduces number of variables and lines. > > Signed-off-by: Daejun Park Thanks, applied. - Ted