All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mihai Carabas <mihai.carabas@oracle.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
	andriy.shevchenko@linux.intel.com, bobo.shaobowang@huawei.com
Subject: Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent code
Date: Wed, 3 Feb 2021 16:44:04 +0100	[thread overview]
Message-ID: <YBrExCSbFu/SCcpW@kroah.com> (raw)
In-Reply-To: <1612363439-26656-2-git-send-email-mihai.carabas@oracle.com>

On Wed, Feb 03, 2021 at 04:43:58PM +0200, Mihai Carabas wrote:
> Split-up generic and platform dependent code in order to introduce pvpanic pci
> device driver later.

What is "later"?

And did you just create a new driver/module in this change?  Why?
And how did you test?  This new module looks to probably taint the
kernel, correct?

How about doing this at the very least, 2 patches, one to move to the
new directory, and the second to split into two modules.  And of course,
please TEST THIS!

thanks,

greg k-h

  reply	other threads:[~2021-02-03 15:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 14:43 [PATCH] add support for pci in the pvpanic driver Mihai Carabas
2021-02-03 14:43 ` [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent code Mihai Carabas
2021-02-03 15:44   ` Greg KH [this message]
2021-02-03 17:13   ` Randy Dunlap
2021-02-03 19:57   ` kernel test robot
2021-02-03 19:57     ` kernel test robot
2021-02-03 23:18   ` kernel test robot
2021-02-03 23:18     ` kernel test robot
2021-02-03 14:43 ` [PATCH 2/2] misc/pvpanic: add pci driver Mihai Carabas
2021-02-03 15:41   ` Greg KH
2021-02-03 15:44   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBrExCSbFu/SCcpW@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=bobo.shaobowang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.carabas@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.