From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17358C433DB for ; Thu, 18 Feb 2021 18:56:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C75BF64EB4 for ; Thu, 18 Feb 2021 18:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230306AbhBRS4T (ORCPT ); Thu, 18 Feb 2021 13:56:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231931AbhBRRH2 (ORCPT ); Thu, 18 Feb 2021 12:07:28 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAF60C061788 for ; Thu, 18 Feb 2021 09:06:45 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id 81so2779988qkf.4 for ; Thu, 18 Feb 2021 09:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zVENMey1EdFzZhk4Yon7dEXfrybku0MTAsUKJNMONig=; b=Y1SWeFTKNyObDh6T0tVdAgoEZMOAylAVj0RaiIh4kAxsIwLKcsBRG7tkJfxs3cHEKu NOWc39l8M1vBqjKsIMnc+AtNj0YWSFBUUDAUFpgpXHuzPzLnk3MRbun/IK0sJH9iZqCi RdKo6WX4ySkyoeKwlC94IFZsf1Ggdowq/47IJqc+GCWUnkGbAfJudf0kZ1qCFSoUNHHv dY/nu1cl5r8HS/JXRG7goGXAtXL1RrdpPQrPCdy4hfiG1WW/Jl8mkMBXUYgonM//jEni tEXmFMLO5cKxRzFHrI9OfkDp/+N6LspjAeUDpjjPIkd3xT5lsvZV4/93GtGUolxXXHfH c9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zVENMey1EdFzZhk4Yon7dEXfrybku0MTAsUKJNMONig=; b=lIEmdxlrQCUTFcqE2x3QbzKKtOJIIOOLYrJafsos2TqRuRXwkJSpcX2GMKTF2Kcotn Isl4FrEvi8lA5B7ZPdACQQ/rP334tTF6vdiNCdB1Bfaia6Yxbx2T7eAq4BNE1toun1Vv OLmtPCIKU4fbFVdu1crP6B2Ro1Im8vcuNaipj3QpoL1aS4QJVrj5nZys7XIlRbvEALni /OEoaQ9pVmWHU63IMjsXXaeo9NEPUieLR4FI5AN0GKy83AddE86MdUyRmxJWUc0KQHsQ UfbaZZ6BX3fnbSxXq8Nh+Gb2/8zRzlRdAU3QkQXFGfqfishiN4Osx/rjCAmfaTfgGRJD pCFg== X-Gm-Message-State: AOAM531p22CPlszwaVN09QydWlrX2XF8lDybACCiseBqm+Aesg8wUs4R Mw26lKnMKChxb1JWbAPEkJ1EBQ== X-Google-Smtp-Source: ABdhPJx9iIU6TFeUSb0A5vm+Lg9Nywr+deM4uatCuWy5lkLBvlxLa/67dT0NGQDC3PG+xNOK/X/C/Q== X-Received: by 2002:ae9:f309:: with SMTP id p9mr5127370qkg.111.1613668004287; Thu, 18 Feb 2021 09:06:44 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:b3a9]) by smtp.gmail.com with ESMTPSA id b9sm890037qkj.90.2021.02.18.09.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 09:06:43 -0800 (PST) Date: Thu, 18 Feb 2021 12:06:42 -0500 From: Johannes Weiner To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: Andrew Morton , Tejun Heo , Michal Hocko , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1 Message-ID: References: <20210209163304.77088-1-hannes@cmpxchg.org> <20210209163304.77088-5-hannes@cmpxchg.org> <20210217174232.GA19239@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 04:45:11PM +0100, Michal Koutný wrote: > On Wed, Feb 17, 2021 at 03:52:59PM -0500, Johannes Weiner wrote: > > In this case, we're talking about a relatively small data structure > > and the overhead is per mountpoint. > IIUC, it is per each mountpoint's number of cgroups. But I still accept > the argument above. Furthermore, this can be changed later. Oops, you're right of course. > > The default root group has statically preallocated percpu data before > > and after this patch. See cgroup.c: > I stand corrected, the comment is still valid. > > Therefore, > Reviewed-by: Michal Koutný Thanks for your reviews, Michal!