From: Andrew Lunn <andrew@lunn.ch>
To: Grant Grundler <grundler@chromium.org>
Cc: Oliver Neukum <oneukum@suse.com>, netdev <netdev@vger.kernel.org>,
davem@devemloft.org, Hayes Wang <hayeswang@realtek.com>,
Jakub Kicinski <kuba@kernel.org>,
Roland Dreier <roland@kernel.org>
Subject: Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings
Date: Thu, 18 Feb 2021 20:50:20 +0100 [thread overview]
Message-ID: <YC7E/LvO8+k83lIL@lunn.ch> (raw)
In-Reply-To: <CANEJEGu+fqkgu6whO_1BXFpnf5K6BG8Z7nUmHcJaYU9_tc7svg@mail.gmail.com>
On Thu, Feb 18, 2021 at 07:31:41PM +0000, Grant Grundler wrote:
> Oliver, Jakub,
> Can I post v4 and deal with the issues below?
You should probably wait for two weeks. We are far enough into the
merge window that i doubt it will get picked up. So please wait,
rebase, and then post.
> Nit: The v2/v3 lines should be included BELOW the '---' line since
> they don't belong in the commit message.
netdev actually prefers them above, so we see the history of how a
patched changed during review.
Andrew
next prev parent reply other threads:[~2021-02-18 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 10:20 [PATCHv3 0/3]usbnet: speed reporting for devices without MDIO Oliver Neukum
2021-02-18 10:20 ` [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings Oliver Neukum
2021-02-18 19:06 ` Jakub Kicinski
2021-02-18 19:31 ` Grant Grundler
2021-02-18 19:50 ` Andrew Lunn [this message]
2021-02-19 7:12 ` Grant Grundler
2021-02-18 10:20 ` [PATCHv3 2/3] usbnet: add method for reporting speed without MDIO Oliver Neukum
2021-02-18 19:06 ` Jakub Kicinski
2021-02-18 10:20 ` [PATCHv3 3/3] CDC-NCM: record speed in status method Oliver Neukum
2021-02-19 7:30 ` Grant Grundler
2021-02-22 10:14 ` Oliver Neukum
2021-02-24 5:24 ` Grant Grundler
2021-03-20 5:24 ` Grant Grundler
2021-02-19 7:43 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC7E/LvO8+k83lIL@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@devemloft.org \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.