From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA1EC433DB for ; Fri, 19 Feb 2021 08:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07202600CF for ; Fri, 19 Feb 2021 08:15:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbhBSIPO (ORCPT ); Fri, 19 Feb 2021 03:15:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:57520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbhBSIPG (ORCPT ); Fri, 19 Feb 2021 03:15:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A92664EBF; Fri, 19 Feb 2021 08:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613722465; bh=Sg/LmX0xgru7QZr+8/7sje3EDV8aKwgIztIGPvkrOA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fc8flGBUEQ1jUa4i4CBmCknlcdqj1QR+KjMIkGX6fjMR/wiPfPawzxOEayBOd1vfq MdD01/frONeQ+S1rVBpgG990GNhVluPklzn0ZJZflPEqSe7wiglSTGqE4RQU7/HdVA C6OEpmeH3wpJ+CCl8t71sXLleUhMeCQerVyYPCBg= Date: Fri, 19 Feb 2021 09:14:23 +0100 From: Greg KH To: Nikolay Kyx Cc: adawesomeguy222@gmail.com, dinghao.liu@zju.edu.cn, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fwserial: match alignment with open parenthesis Message-ID: References: <20210218194333.7115-1-knv418@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218194333.7115-1-knv418@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 10:43:33PM +0300, Nikolay Kyx wrote: > fwserial.c: Why is this here? > fix CHECK: Alignment should match open parenthesis What does this mean? Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_20,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03DD7C433DB for ; Fri, 19 Feb 2021 08:14:30 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89E2B64EB8 for ; Fri, 19 Feb 2021 08:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89E2B64EB8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2E35287449; Fri, 19 Feb 2021 08:14:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hvwM+MKAunPc; Fri, 19 Feb 2021 08:14:28 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id A7CD787426; Fri, 19 Feb 2021 08:14:28 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0A4311BF318 for ; Fri, 19 Feb 2021 08:14:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 060DB862BC for ; Fri, 19 Feb 2021 08:14:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a1CwY3QhvHlo for ; Fri, 19 Feb 2021 08:14:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 7C14F86CCC for ; Fri, 19 Feb 2021 08:14:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A92664EBF; Fri, 19 Feb 2021 08:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613722465; bh=Sg/LmX0xgru7QZr+8/7sje3EDV8aKwgIztIGPvkrOA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fc8flGBUEQ1jUa4i4CBmCknlcdqj1QR+KjMIkGX6fjMR/wiPfPawzxOEayBOd1vfq MdD01/frONeQ+S1rVBpgG990GNhVluPklzn0ZJZflPEqSe7wiglSTGqE4RQU7/HdVA C6OEpmeH3wpJ+CCl8t71sXLleUhMeCQerVyYPCBg= Date: Fri, 19 Feb 2021 09:14:23 +0100 From: Greg KH To: Nikolay Kyx Subject: Re: [PATCH] staging: fwserial: match alignment with open parenthesis Message-ID: References: <20210218194333.7115-1-knv418@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210218194333.7115-1-knv418@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dinghao.liu@zju.edu.cn, adawesomeguy222@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Feb 18, 2021 at 10:43:33PM +0300, Nikolay Kyx wrote: > fwserial.c: Why is this here? > fix CHECK: Alignment should match open parenthesis What does this mean? Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel