From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E0FC433DB for ; Mon, 8 Feb 2021 11:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42AED64DF6 for ; Mon, 8 Feb 2021 11:53:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232694AbhBHLxX (ORCPT ); Mon, 8 Feb 2021 06:53:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233273AbhBHL34 (ORCPT ); Mon, 8 Feb 2021 06:29:56 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A87F4C061786; Mon, 8 Feb 2021 03:29:15 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D8DA63D7; Mon, 8 Feb 2021 12:29:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1612783753; bh=rgeukeKI+OQT8iKjPgiXk2pV9ZGLh/sQEUrh16j6Kn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mc9PVt9G2Nmv5QQ4NKGm/4B5nV7bpdQ0tLLnEtJtAK3LZD4tYW44/TjWNFwjYeS5v 4NcIHl9SOs8IC9Jy4PtGDc08f23eBFn3OwKFz3psrT5dOmeg7yE9bIk7bUmM2ZSh7u vRnEN2Du8HyP2dbpG4BSi8bF2wWjkbWpx+o0PxfQ= Date: Mon, 8 Feb 2021 13:28:48 +0200 From: Laurent Pinchart To: Hans Verkuil Cc: Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Hyun Kwon , Manivannan Sadhasivam , sergei.shtylyov@gmail.com Subject: Re: [PATCH v8 1/5] media: i2c: Add driver for RDACM21 camera module Message-ID: References: <20210114170429.139762-1-jacopo+renesas@jmondi.org> <20210114170429.139762-2-jacopo+renesas@jmondi.org> <0b118385-70bc-01eb-8ddf-829c604d533b@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0b118385-70bc-01eb-8ddf-829c604d533b@xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On Mon, Feb 08, 2021 at 12:21:01PM +0100, Hans Verkuil wrote: > On 14/01/2021 18:04, Jacopo Mondi wrote: > > The RDACM21 is a GMSL camera supporting 1280x1080 resolution images > > developed by IMI based on an Omnivision OV10640 sensor, an Omnivision > > OV490 ISP and a Maxim MAX9271 GMSL serializer. > > > > The driver uses the max9271 library module, to maximize code reuse with > > other camera module drivers using the same serializer, such as rdacm20. > > > > Reviewed-by: Laurent Pinchart > > Signed-off-by: Jacopo Mondi > > --- > > MAINTAINERS | 12 + > > drivers/media/i2c/Kconfig | 13 + > > drivers/media/i2c/Makefile | 2 + > > drivers/media/i2c/rdacm21.c | 623 ++++++++++++++++++++++++++++++++++++ > > 4 files changed, 650 insertions(+) > > create mode 100644 drivers/media/i2c/rdacm21.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 14adf87d90c7..1822d73ed615 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -14967,6 +14967,18 @@ F: drivers/media/i2c/max9271.c > > F: drivers/media/i2c/max9271.h > > F: drivers/media/i2c/rdacm20.c > > > > +RDACM21 Camera Sensor > > +M: Jacopo Mondi > > +M: Kieran Bingham > > +M: Laurent Pinchart > > +M: Niklas Söderlund > > +L: linux-media@vger.kernel.org > > +S: Maintained > > +F: Documentation/devicetree/bindings/media/i2c/rdacm2x-gmsl.yaml > > +F: drivers/media/i2c/max9271.c > > +F: drivers/media/i2c/max9271.h > > +F: drivers/media/i2c/rdacm21.c > > + > > RDC R-321X SoC > > M: Florian Fainelli > > S: Maintained > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 2b9d81e4794a..d500edb8638b 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -1212,6 +1212,19 @@ config VIDEO_RDACM20 > > This camera should be used in conjunction with a GMSL > > deserialiser such as the MAX9286. > > > > +config VIDEO_RDACM21 > > + tristate "IMI RDACM21 camera support" > > + depends on I2C > > + select V4L2_FWNODE > > + select VIDEO_V4L2_SUBDEV_API > > + select MEDIA_CONTROLLER > > + help > > + This driver supports the IMI RDACM21 GMSL camera, used in > > + ADAS systems. > > + > > + This camera should be used in conjunction with a GMSL > > + deserialiser such as the MAX9286. > > + > > config VIDEO_RJ54N1 > > tristate "Sharp RJ54N1CB0C sensor support" > > depends on I2C && VIDEO_V4L2 > > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile > > index a3149dce21bb..85b1edc62508 100644 > > --- a/drivers/media/i2c/Makefile > > +++ b/drivers/media/i2c/Makefile > > @@ -124,6 +124,8 @@ obj-$(CONFIG_VIDEO_IMX355) += imx355.o > > obj-$(CONFIG_VIDEO_MAX9286) += max9286.o > > rdacm20-camera_module-objs := rdacm20.o max9271.o > > obj-$(CONFIG_VIDEO_RDACM20) += rdacm20-camera_module.o > > +rdacm21-camera_module-objs := rdacm21.o max9271.o > > +obj-$(CONFIG_VIDEO_RDACM21) += rdacm21-camera_module.o > > obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o > > This isn't right. The max9271 code exports various functions, but since it is > included with *two* modules (rdacm20/1-camera_module.ko) it is exported twice. > > Since max9271 is not a self-contained driver it should not export symbols. Shouldn't we instead make max9271 a stand-alone module ? > Can you provide a patch fixing that? -- Regards, Laurent Pinchart