From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5AC6C433DB for ; Mon, 8 Feb 2021 17:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DEBC64E54 for ; Mon, 8 Feb 2021 17:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233747AbhBHR46 (ORCPT ); Mon, 8 Feb 2021 12:56:58 -0500 Received: from muru.com ([72.249.23.125]:58984 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235043AbhBHRy4 (ORCPT ); Mon, 8 Feb 2021 12:54:56 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D39BD80A3; Mon, 8 Feb 2021 17:54:29 +0000 (UTC) Date: Mon, 8 Feb 2021 19:54:10 +0200 From: Tony Lindgren To: Andreas Kemnade Cc: Adam Ford , Linux-OMAP Subject: Re: DM3730 Suspend-Resume with 5.11-rc6 Message-ID: References: <20210208112735.02e85c3f@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208112735.02e85c3f@aktux> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Andreas Kemnade [210208 10:32]: > On Mon, 8 Feb 2021 11:15:48 +0200 > Tony Lindgren wrote: > > > * Adam Ford [210206 22:22]: > > > On Sat, Feb 6, 2021 at 3:57 PM Adam Ford wrote: > > > > > > > > I am having issues with suspend on a DM3730 running 5.11-rc6, and it > > > > seems like core_pwrdm may be the issue. > > > > That probably just means you did not configure off mode for idle. > > > > hmm, do you still need to configure anything for off mode? I rather > think it might be a misbehaving peripheral, not a general off mode > problem. So maybe try it with less modules loaded and add them step by > step to find out the misbehaving one. Right, that should no longer be needed. So then it's probably the lack of configuring uart timeouts that will keep the SoC power domains busy. > > echo -n 1 > /sys/kernel/debug/pm_debug/enable_off_mode > > > Is this line still needed? I thought I had patched it away. Yes you're right it should no longer be needed. Regards, Tony