From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68517C433DB for ; Wed, 10 Feb 2021 12:11:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DAB164E2A for ; Wed, 10 Feb 2021 12:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231462AbhBJMLU (ORCPT ); Wed, 10 Feb 2021 07:11:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:36252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbhBJMIG (ORCPT ); Wed, 10 Feb 2021 07:08:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A39564E2A; Wed, 10 Feb 2021 12:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612958841; bh=/KLTm1jFc8aXXde0ovdili+Cy21fYSRVYi8DZDefxl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1ZVEWowsT/o+KOg1boDtZd+gXVOUPIu+5U/1tGH7wSUGLdldOVmsFgxovlD/d4vc8 tNStQQPTWniAm8j550IbhgiXRGB8ThTj9qXn0eKQhK5ni5snmBQPpB1kFqDSNuj29u 96l0gpjj6ZEWv8fU/PXw5qP0m98MsrgotaFt1gjI= Date: Wed, 10 Feb 2021 13:07:18 +0100 From: Greg Kroah-Hartman To: Aakash Hemadri Cc: devel@driverdev.osuosl.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] staging: ralink-gdma: Fix checkpatch.pl CHECK Message-ID: References: <20210210120348.262328-1-aakashhemadri123@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210120348.262328-1-aakashhemadri123@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 05:33:48PM +0530, Aakash Hemadri wrote: > Remove CHECK: Lines should not end with a '(' > > Signed-off-by: Aakash Hemadri > --- > > drivers/staging/ralink-gdma/ralink-gdma.c | 28 ++++++++++++----------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c > index 655df317d0ee..a11f915f3308 100644 > --- a/drivers/staging/ralink-gdma/ralink-gdma.c > +++ b/drivers/staging/ralink-gdma/ralink-gdma.c > @@ -135,8 +135,7 @@ struct gdma_data { > int (*start_transfer)(struct gdma_dmaengine_chan *chan); > }; > > -static struct gdma_dma_dev *gdma_dma_chan_get_dev( > - struct gdma_dmaengine_chan *chan) > +static struct gdma_dma_dev *gdma_dma_chan_get_dev(struct gdma_dmaengine_chan *chan) > { > return container_of(chan->vchan.chan.device, struct gdma_dma_dev, > ddev); > @@ -510,10 +509,11 @@ static void gdma_dma_issue_pending(struct dma_chan *c) > spin_unlock_irqrestore(&chan->vchan.lock, flags); > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_slave_sg( > - struct dma_chan *c, struct scatterlist *sgl, > - unsigned int sg_len, enum dma_transfer_direction direction, > - unsigned long flags, void *context) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_slave_sg(struct dma_chan *c, struct scatterlist *sgl, > + unsigned int sg_len, > + enum dma_transfer_direction direction, > + unsigned long flags, void *context) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > @@ -558,9 +558,10 @@ static struct dma_async_tx_descriptor *gdma_dma_prep_slave_sg( > return NULL; > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_dma_memcpy( > - struct dma_chan *c, dma_addr_t dest, dma_addr_t src, > - size_t len, unsigned long flags) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_dma_memcpy(struct dma_chan *c, > + dma_addr_t dest, dma_addr_t src, > + size_t len, unsigned long flags) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > @@ -601,10 +602,11 @@ static struct dma_async_tx_descriptor *gdma_dma_prep_dma_memcpy( > return vchan_tx_prep(&chan->vchan, &desc->vdesc, flags); > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_dma_cyclic( > - struct dma_chan *c, dma_addr_t buf_addr, size_t buf_len, > - size_t period_len, enum dma_transfer_direction direction, > - unsigned long flags) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_dma_cyclic(struct dma_chan *c, dma_addr_t buf_addr, > + size_t buf_len, size_t period_len, > + enum dma_transfer_direction direction, > + unsigned long flags) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > -- > 2.30.0 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA13C43381 for ; Wed, 10 Feb 2021 12:07:28 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B030764E0D for ; Wed, 10 Feb 2021 12:07:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B030764E0D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 82F37866E7; Wed, 10 Feb 2021 12:07:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 42nWM6K0p+h5; Wed, 10 Feb 2021 12:07:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 952E6866C3; Wed, 10 Feb 2021 12:07:23 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id E7C2F1BF861 for ; Wed, 10 Feb 2021 12:07:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E4857870FC for ; Wed, 10 Feb 2021 12:07:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AtW9NaJotO5y for ; Wed, 10 Feb 2021 12:07:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id 52C0886F65 for ; Wed, 10 Feb 2021 12:07:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A39564E2A; Wed, 10 Feb 2021 12:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612958841; bh=/KLTm1jFc8aXXde0ovdili+Cy21fYSRVYi8DZDefxl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1ZVEWowsT/o+KOg1boDtZd+gXVOUPIu+5U/1tGH7wSUGLdldOVmsFgxovlD/d4vc8 tNStQQPTWniAm8j550IbhgiXRGB8ThTj9qXn0eKQhK5ni5snmBQPpB1kFqDSNuj29u 96l0gpjj6ZEWv8fU/PXw5qP0m98MsrgotaFt1gjI= Date: Wed, 10 Feb 2021 13:07:18 +0100 From: Greg Kroah-Hartman To: Aakash Hemadri Subject: Re: [PATCH] staging: ralink-gdma: Fix checkpatch.pl CHECK Message-ID: References: <20210210120348.262328-1-aakashhemadri123@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210210120348.262328-1-aakashhemadri123@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, Shuah Khan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Feb 10, 2021 at 05:33:48PM +0530, Aakash Hemadri wrote: > Remove CHECK: Lines should not end with a '(' > > Signed-off-by: Aakash Hemadri > --- > > drivers/staging/ralink-gdma/ralink-gdma.c | 28 ++++++++++++----------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c > index 655df317d0ee..a11f915f3308 100644 > --- a/drivers/staging/ralink-gdma/ralink-gdma.c > +++ b/drivers/staging/ralink-gdma/ralink-gdma.c > @@ -135,8 +135,7 @@ struct gdma_data { > int (*start_transfer)(struct gdma_dmaengine_chan *chan); > }; > > -static struct gdma_dma_dev *gdma_dma_chan_get_dev( > - struct gdma_dmaengine_chan *chan) > +static struct gdma_dma_dev *gdma_dma_chan_get_dev(struct gdma_dmaengine_chan *chan) > { > return container_of(chan->vchan.chan.device, struct gdma_dma_dev, > ddev); > @@ -510,10 +509,11 @@ static void gdma_dma_issue_pending(struct dma_chan *c) > spin_unlock_irqrestore(&chan->vchan.lock, flags); > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_slave_sg( > - struct dma_chan *c, struct scatterlist *sgl, > - unsigned int sg_len, enum dma_transfer_direction direction, > - unsigned long flags, void *context) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_slave_sg(struct dma_chan *c, struct scatterlist *sgl, > + unsigned int sg_len, > + enum dma_transfer_direction direction, > + unsigned long flags, void *context) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > @@ -558,9 +558,10 @@ static struct dma_async_tx_descriptor *gdma_dma_prep_slave_sg( > return NULL; > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_dma_memcpy( > - struct dma_chan *c, dma_addr_t dest, dma_addr_t src, > - size_t len, unsigned long flags) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_dma_memcpy(struct dma_chan *c, > + dma_addr_t dest, dma_addr_t src, > + size_t len, unsigned long flags) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > @@ -601,10 +602,11 @@ static struct dma_async_tx_descriptor *gdma_dma_prep_dma_memcpy( > return vchan_tx_prep(&chan->vchan, &desc->vdesc, flags); > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_dma_cyclic( > - struct dma_chan *c, dma_addr_t buf_addr, size_t buf_len, > - size_t period_len, enum dma_transfer_direction direction, > - unsigned long flags) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_dma_cyclic(struct dma_chan *c, dma_addr_t buf_addr, > + size_t buf_len, size_t period_len, > + enum dma_transfer_direction direction, > + unsigned long flags) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > -- > 2.30.0 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DB8C433E0 for ; Wed, 10 Feb 2021 12:07:29 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 907DE64E0D for ; Wed, 10 Feb 2021 12:07:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 907DE64E0D Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 49589866C3; Wed, 10 Feb 2021 12:07:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DuJ+AnWScgxs; Wed, 10 Feb 2021 12:07:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 5FA98866EF; Wed, 10 Feb 2021 12:07:24 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4C912C0174; Wed, 10 Feb 2021 12:07:24 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 18F06C013A for ; Wed, 10 Feb 2021 12:07:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0510D86F65 for ; Wed, 10 Feb 2021 12:07:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2+zt4s6nhh+R for ; Wed, 10 Feb 2021 12:07:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id 582E087016 for ; Wed, 10 Feb 2021 12:07:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A39564E2A; Wed, 10 Feb 2021 12:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612958841; bh=/KLTm1jFc8aXXde0ovdili+Cy21fYSRVYi8DZDefxl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1ZVEWowsT/o+KOg1boDtZd+gXVOUPIu+5U/1tGH7wSUGLdldOVmsFgxovlD/d4vc8 tNStQQPTWniAm8j550IbhgiXRGB8ThTj9qXn0eKQhK5ni5snmBQPpB1kFqDSNuj29u 96l0gpjj6ZEWv8fU/PXw5qP0m98MsrgotaFt1gjI= Date: Wed, 10 Feb 2021 13:07:18 +0100 From: Greg Kroah-Hartman To: Aakash Hemadri Message-ID: References: <20210210120348.262328-1-aakashhemadri123@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210210120348.262328-1-aakashhemadri123@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH] staging: ralink-gdma: Fix checkpatch.pl CHECK X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Wed, Feb 10, 2021 at 05:33:48PM +0530, Aakash Hemadri wrote: > Remove CHECK: Lines should not end with a '(' > > Signed-off-by: Aakash Hemadri > --- > > drivers/staging/ralink-gdma/ralink-gdma.c | 28 ++++++++++++----------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c > index 655df317d0ee..a11f915f3308 100644 > --- a/drivers/staging/ralink-gdma/ralink-gdma.c > +++ b/drivers/staging/ralink-gdma/ralink-gdma.c > @@ -135,8 +135,7 @@ struct gdma_data { > int (*start_transfer)(struct gdma_dmaengine_chan *chan); > }; > > -static struct gdma_dma_dev *gdma_dma_chan_get_dev( > - struct gdma_dmaengine_chan *chan) > +static struct gdma_dma_dev *gdma_dma_chan_get_dev(struct gdma_dmaengine_chan *chan) > { > return container_of(chan->vchan.chan.device, struct gdma_dma_dev, > ddev); > @@ -510,10 +509,11 @@ static void gdma_dma_issue_pending(struct dma_chan *c) > spin_unlock_irqrestore(&chan->vchan.lock, flags); > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_slave_sg( > - struct dma_chan *c, struct scatterlist *sgl, > - unsigned int sg_len, enum dma_transfer_direction direction, > - unsigned long flags, void *context) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_slave_sg(struct dma_chan *c, struct scatterlist *sgl, > + unsigned int sg_len, > + enum dma_transfer_direction direction, > + unsigned long flags, void *context) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > @@ -558,9 +558,10 @@ static struct dma_async_tx_descriptor *gdma_dma_prep_slave_sg( > return NULL; > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_dma_memcpy( > - struct dma_chan *c, dma_addr_t dest, dma_addr_t src, > - size_t len, unsigned long flags) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_dma_memcpy(struct dma_chan *c, > + dma_addr_t dest, dma_addr_t src, > + size_t len, unsigned long flags) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > @@ -601,10 +602,11 @@ static struct dma_async_tx_descriptor *gdma_dma_prep_dma_memcpy( > return vchan_tx_prep(&chan->vchan, &desc->vdesc, flags); > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_dma_cyclic( > - struct dma_chan *c, dma_addr_t buf_addr, size_t buf_len, > - size_t period_len, enum dma_transfer_direction direction, > - unsigned long flags) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_dma_cyclic(struct dma_chan *c, dma_addr_t buf_addr, > + size_t buf_len, size_t period_len, > + enum dma_transfer_direction direction, > + unsigned long flags) > { > struct gdma_dmaengine_chan *chan = to_gdma_dma_chan(c); > struct gdma_dma_desc *desc; > -- > 2.30.0 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees